IN PROGRESS - issue BATCH-7: Remove transaction synchronization and state management from input/output sources (formerly buffering)

http://jira.springframework.org/browse/BATCH-7

Remove RestartableItemOrientedTasklet (replaced with ItemOrientedTasklet).

spring-batch-execution/src/main/java/org/springframework/batch/execution/tasklet/RestartableItemOrientedTasklet.java

@@ -1,66 +0,0 @@
-/*
- * Copyright 2006-2007 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.springframework.batch.execution.tasklet;
-
-import org.springframework.batch.item.ItemReader;
-import org.springframework.batch.item.ItemStream;
-import org.springframework.batch.item.ItemWriter;
-import org.springframework.batch.item.StreamContext;
-import org.springframework.batch.item.StreamException;
-
-/**
- * An extension of {@link ItemOrientedTasklet} that delegates calls to
- * {@link ItemStream} to the reader and writer.
- * 
- * @see ItemReader
- * @see ItemWriter
- * @see ItemStream
- * 
- * @author Lucas Ward
- * @author Dave Syer
- * 
- */
-public class RestartableItemOrientedTasklet extends ItemOrientedTasklet implements ItemStream {
-
-	/**
-	 * @see ItemStream#getStreamContext()
-	 */
-	public StreamContext getStreamContext() {
-		throw new UnsupportedOperationException("This class is not used");
-	}
-
-	/**
-	 * @see ItemStream#restoreFrom(StreamContext)
-	 */
-	public void restoreFrom(StreamContext data) {
-		throw new UnsupportedOperationException("This class is not used");
-	}
-	
-	/* (non-Javadoc)
-	 * @see org.springframework.batch.item.ItemStream#open()
-	 */
-	public void open() throws StreamException {
-		throw new UnsupportedOperationException("Not implemented.");
-	}
-	
-	/* (non-Javadoc)
-	 * @see org.springframework.batch.item.ItemStream#close()
-	 */
-	public void close() throws StreamException {
-		throw new UnsupportedOperationException("Not implemented.");		
-	}
-}

spring-batch-samples/src/main/java/org/springframework/batch/sample/tasklet/ExceptionRestartableTasklet.java

@@ -18,7 +18,7 @@ package org.springframework.batch.sample.tasklet;
 
 
 import org.springframework.batch.core.tasklet.Tasklet;
-import org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet;
+import org.springframework.batch.execution.tasklet.ItemOrientedTasklet;
 import org.springframework.batch.io.exception.BatchCriticalException;
 import org.springframework.batch.repeat.ExitStatus;
 
@@ -29,7 +29,7 @@ import org.springframework.batch.repeat.ExitStatus;
  * @author Robert Kasanicky
  *
  */
-public class ExceptionRestartableTasklet extends RestartableItemOrientedTasklet {
+public class ExceptionRestartableTasklet extends ItemOrientedTasklet {
 
 	private int counter = 0;
 	private int throwExceptionOnRecordNumber = 4;
@@ -57,7 +57,5 @@ public class ExceptionRestartableTasklet extends RestartableItemOrientedTasklet
 	public int getThrowExceptionOnRecordNumber() {
 		return throwExceptionOnRecordNumber;
 	}
-	
-	
 
 }

spring-batch-samples/src/main/resources/jobs/beanWrapperMapperSampleJob.xml

@@ -16,7 +16,7 @@
 				<bean id="step1" parent="simpleStep">
 					<property name="tasklet">
 						<bean
-							class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+							class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 							<property name="itemReader">
 								<bean
 									class="org.springframework.batch.item.reader.ValidatingItemReader">
@@ -35,7 +35,7 @@
 				<bean id="step2" parent="simpleStep">
 					<property name="tasklet">
 						<bean
-							class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+							class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 							<property name="itemReader" ref="fileInputTemplate2" />
 							<property name="itemWriter">
 								<bean class="org.springframework.batch.sample.item.writer.PersonWriter" />

spring-batch-samples/src/main/resources/jobs/compositeProcessorSampleJob.xml

@@ -15,7 +15,7 @@
 			<bean id="step1" parent="simpleStep">
 				<property name="tasklet">
 					<bean
-						class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+						class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 						<property name="itemReader">
 							<bean
 								class="org.springframework.batch.item.reader.ValidatingItemReader">

spring-batch-samples/src/main/resources/jobs/fixedLengthImportJob.xml

@@ -15,7 +15,7 @@
 			<bean id="step1" parent="simpleStep">
 				<property name="tasklet">
 					<bean
-						class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+						class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 						<property name="itemReader">
 							<bean
 								class="org.springframework.batch.item.reader.ValidatingItemReader">

spring-batch-samples/src/main/resources/jobs/footballJob.xml

@@ -22,7 +22,7 @@
 					<property name="allowStartIfComplete" value="false" />
 					<property name="tasklet">
 						<bean
-							class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+							class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 							<property name="itemReader"
 								ref="playerFileItemReader" />
 							<property name="itemWriter">
@@ -45,7 +45,7 @@
 					<property name="startLimit" value="100" />
 					<property name="tasklet">
 						<bean
-							class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+							class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 							<property name="itemReader"
 								ref="gameFileItemReader" />
 							<property name="itemWriter">
@@ -63,7 +63,7 @@
 					<property name="startLimit" value="100" />
 					<property name="tasklet">
 						<bean
-							class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+							class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 							<property name="itemReader"
 								ref="playerSummarizationSource" />
 							<property name="itemWriter">

spring-batch-samples/src/main/resources/jobs/hibernateJob.xml

@@ -21,7 +21,7 @@
 			<bean id="step1" parent="repeatOperationsStep">
 				<property name="tasklet">
 					<bean
-						class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+						class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 						<property name="itemReader"
 							ref="hibernateItemReader" />
 						<property name="itemWriter"

spring-batch-samples/src/main/resources/jobs/ibatisJob.xml

@@ -19,7 +19,7 @@
 			<bean id="step1" parent="simpleStep">
 				<property name="tasklet">
 					<bean
-						class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+						class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 						<property name="itemReader" ref="ibatisItemReader" />
 						<property name="itemWriter">
 							<bean class="org.springframework.batch.sample.item.writer.CustomerCreditIncreaseWriter">

spring-batch-samples/src/main/resources/jobs/multilineJob.xml

@@ -15,7 +15,7 @@
 			<bean id="step1" parent="simpleStep">
 				<property name="tasklet">
 					<bean
-						class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+						class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 						<property name="itemReader">
 							<bean
 								class="org.springframework.batch.item.reader.AggregateItemReader">

spring-batch-samples/src/main/resources/jobs/multilineOrderJob.xml

@@ -18,7 +18,7 @@
 			<bean id="step1" parent="simpleStep">
 				<property name="tasklet">
 					<bean
-						class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+						class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 						<property name="itemReader">
 							<bean class="org.springframework.batch.sample.item.reader.OrderItemReader">
 								<property name="itemReader" ref="fileInputTemplate" />

spring-batch-samples/src/main/resources/jobs/parallelJob.xml

@@ -18,7 +18,7 @@
 				<bean id="staging" parent="simpleStep">
 					<property name="tasklet">
 						<bean
-							class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+							class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 							<property name="itemReader">
 								<bean
 									class="org.springframework.batch.item.reader.ValidatingItemReader">

spring-batch-samples/src/main/resources/jobs/rollbackJob.xml

@@ -42,7 +42,7 @@
 					</property>
 					<property name="tasklet">
 						<bean
-							class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+							class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 							<property name="itemReader">
 								<bean
 									class="org.springframework.batch.item.reader.ValidatingItemReader">
@@ -64,7 +64,7 @@
 				<bean id="step2" parent="simpleStep">
 					<property name="tasklet">
 						<bean
-							class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+							class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 							<property name="itemReader"
 								ref="tradeSqlItemReader" />
 							<property name="itemWriter">

spring-batch-samples/src/main/resources/jobs/tradeJob.xml

@@ -19,7 +19,7 @@
 				<bean id="step1" parent="simpleStep">
 					<property name="tasklet">
 						<bean
-							class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+							class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 							<property name="itemReader">
 								<bean
 									class="org.springframework.batch.item.reader.ValidatingItemReader">
@@ -40,7 +40,7 @@
 				<bean id="step2" parent="simpleStep">
 					<property name="tasklet">
 						<bean
-							class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+							class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 							<property name="itemReader" ref="tradeSqlItemReader" />
 							<property name="itemWriter">
 								<bean
@@ -53,7 +53,7 @@
 				<bean id="step3" parent="simpleStep">
 					<property name="tasklet">
 						<bean
-							class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+							class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 							<property name="itemReader" ref="customerSqlItemReader" />
 							<property name="itemWriter">
 								<bean

spring-batch-samples/src/main/resources/jobs/xmlStaxJob.xml

@@ -19,7 +19,7 @@
 			<bean id="step1" parent="simpleStep">
 				<property name="tasklet">
 					<bean
-						class="org.springframework.batch.execution.tasklet.RestartableItemOrientedTasklet">
+						class="org.springframework.batch.execution.tasklet.ItemOrientedTasklet">
 						<property name="itemReader">
 							<bean
 								class="org.springframework.batch.io.xml.StaxEventItemReader"