Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BATCH-325:Added close() to readers and writers.

Browse Source
This commit is contained in:
lucasward
2008-01-29 17:15:11 +00:00
parent 16c59d915f
commit 4e51cf13ea
5 changed files with 30 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
spring-batch-execution/src/test/java/org/springframework/batch/execution/launch/EmptyItemWriter.java
View File

@@ -58,4 +58,7 @@ public class EmptyItemWriter implements ItemWriter, InitializingBean {
return list;
}
public void close() throws Exception {
}
}

7
spring-batch-execution/src/test/java/org/springframework/batch/execution/launch/SimpleJobTests.java
View File

@@ -40,6 +40,7 @@ import org.springframework.batch.item.ItemReader;
import org.springframework.batch.item.ItemRecoverer;
import org.springframework.batch.item.ItemWriter;
import org.springframework.batch.item.reader.ListItemReader;
import org.springframework.batch.item.writer.AbstractItemWriter;
import org.springframework.batch.repeat.RepeatContext;
import org.springframework.batch.repeat.exception.handler.ExceptionHandler;
import org.springframework.batch.repeat.support.RepeatTemplate;
@@ -55,7 +56,7 @@ public class SimpleJobTests extends TestCase {
private List processed = new ArrayList();
private ItemWriter processor = new ItemWriter() {
private ItemWriter processor = new AbstractItemWriter() {
public void write(Object data) throws Exception {
processed.add((String) data);
}
@@ -144,7 +145,7 @@ public class SimpleJobTests extends TestCase {
step.setChunkOperations(chunkOperations);
step.setJobRepository(repository);
step.setTransactionManager(new ResourcelessTransactionManager());
module.setItemWriter(new ItemWriter() {
module.setItemWriter(new AbstractItemWriter() {
public void write(Object data) throws Exception {
throw new RuntimeException("Try again Dummy!");
}
@@ -169,7 +170,7 @@ public class SimpleJobTests extends TestCase {
AbstractStep step = new SimpleStep(module);
step.setJobRepository(repository);
step.setTransactionManager(new ResourcelessTransactionManager());
module.setItemWriter(new ItemWriter() {
module.setItemWriter(new AbstractItemWriter() {
public void write(Object data) throws Exception {
throw new RuntimeException("Foo");
}

3
spring-batch-execution/src/test/java/org/springframework/batch/execution/step/simple/SimpleStepExecutorTests.java
View File

@@ -42,6 +42,7 @@ import org.springframework.batch.execution.tasklet.ItemOrientedTasklet;
import org.springframework.batch.item.ItemReader;
import org.springframework.batch.item.ItemWriter;
import org.springframework.batch.item.reader.ListItemReader;
import org.springframework.batch.item.writer.AbstractItemWriter;
import org.springframework.batch.repeat.ExitStatus;
import org.springframework.batch.repeat.RepeatContext;
import org.springframework.batch.repeat.exception.handler.DefaultExceptionHandler;
@@ -60,7 +61,7 @@ public class SimpleStepExecutorTests extends TestCase {
ArrayList processed = new ArrayList();
ItemWriter processor = new ItemWriter() {
ItemWriter processor = new AbstractItemWriter() {
public void write(Object data) throws Exception {
processed.add((String) data);
}

18
spring-batch-execution/src/test/java/org/springframework/batch/execution/tasklet/ItemOrientedTaskletTests.java
View File

@@ -28,6 +28,7 @@ import org.springframework.batch.item.ItemReader;
import org.springframework.batch.item.ItemRecoverer;
import org.springframework.batch.item.ItemWriter;
import org.springframework.batch.item.reader.AbstractItemReader;
import org.springframework.batch.item.writer.AbstractItemWriter;
import org.springframework.batch.repeat.context.RepeatContextSupport;
import org.springframework.batch.repeat.synch.RepeatSynchronizationManager;
import org.springframework.batch.retry.policy.SimpleRetryPolicy;
@@ -57,9 +58,12 @@ public class ItemOrientedTaskletTests extends TestCase {
}
return null;
}
public void close() throws Exception {
}
};
private ItemWriter itemWriter = new ItemWriter() {
private ItemWriter itemWriter = new AbstractItemWriter() {
public void write(Object data) throws Exception {
list.add(data);
}
@@ -176,9 +180,12 @@ public class ItemOrientedTaskletTests extends TestCase {
public Object read() throws Exception {
return "bar";
}
public void close() throws Exception {
}
});
module.setItemWriter(new ItemWriter() {
module.setItemWriter(new AbstractItemWriter() {
public void write(Object data) throws Exception {
throw new RuntimeException("FOO");
}
@@ -215,7 +222,7 @@ public class ItemOrientedTaskletTests extends TestCase {
return "foo";
}
});
module.setItemWriter(new ItemWriter() {
module.setItemWriter(new AbstractItemWriter() {
public void write(Object data) throws Exception {
throw new RuntimeException("FOO");
}
@@ -274,6 +281,8 @@ public class ItemOrientedTaskletTests extends TestCase {
public Properties getStatistics() {
return PropertiesConverter.stringToProperties("foo=bar");
}
public void close() throws Exception {
}
}
private class SkippableItemWriter implements ItemWriter, Skippable,
@@ -300,5 +309,8 @@ public class ItemOrientedTaskletTests extends TestCase {
public Properties getStatistics() {
return PropertiesConverter.stringToProperties(props);
}
public void close() throws Exception {
}
}
}

6
spring-batch-execution/src/test/java/org/springframework/batch/execution/tasklet/RestartableItemOrientedTaskletTests.java
View File

@@ -63,6 +63,9 @@ public class RestartableItemOrientedTaskletTests extends TestCase {
return false;
}
public void close() throws Exception {
}
}
private static class MockWriter implements ItemWriter, Restartable {
@@ -85,6 +88,9 @@ public class RestartableItemOrientedTaskletTests extends TestCase {
assertEquals(this.data.getProperties(), data.getProperties());
}
public void close() throws Exception {
}
}
private ItemReader itemProvider;