Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BATCH-2096: 'chunk-completion-policy' or 'commit-interval' with '#{jobParameters[...]}' is ignored when 'retry-limit' exists.

Browse Source 
* Added a call for a completionPolicy  when creating FaultTolerantStep
* Added an assertion for the chunkCompletionPolicy in the unit test.

JIRA: https://jira.springsource.org/browse/BATCH-2096
This commit is contained in:
Sanghyuk Jung
2013-09-07 05:21:01 +09:00
committed by Michael Minella
parent 56ccca6b2d
commit 69e047801a
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
spring-batch-core/src/main/java/org/springframework/batch/core/configuration/xml/StepParserStepFactoryBean.java
View File

@@ -301,6 +301,7 @@ class StepParserStepFactoryBean<I, O> implements FactoryBean, BeanNameAware {
if (commitInterval != null) {
builder.chunk(commitInterval);
}
builder.chunk(chunkCompletionPolicy);
enhanceTaskletStepBuilder(builder);
builder.reader(itemReader);

4
spring-batch-core/src/test/java/org/springframework/batch/core/configuration/xml/StepParserStepFactoryBeanTests.java
View File

@@ -248,6 +248,10 @@ public class StepParserStepFactoryBeanTests {
assertEquals(new Integer(10), throttleLimit);
Object tasklet = ReflectionTestUtils.getField(step, "tasklet");
assertTrue(tasklet instanceof ChunkOrientedTasklet<?>);
Object chunkProvider = ReflectionTestUtils.getField(tasklet, "chunkProvider");
Object repeatOperations = ReflectionTestUtils.getField(chunkProvider, "repeatOperations");
Object completionPolicy = ReflectionTestUtils.getField(repeatOperations, "completionPolicy");
assertTrue(completionPolicy instanceof DummyCompletionPolicy);
}
@Test