Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - BATCH-570: Job.getSteps() does not need to be exposed in the interface

Browse Source 
removed the getSteps() method
This commit is contained in:
robokaso
2008-07-18 09:17:26 +00:00
parent 7166a88a43
commit 6d34dff7d8
6 changed files with 1 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
spring-batch-core/src/main/java/org/springframework/batch/core/Job.java
View File

@@ -15,7 +15,6 @@
*/
package org.springframework.batch.core;
import java.util.List;
/**
* Batch domain object representing a job. Job is an explicit abstraction
@@ -30,12 +29,6 @@ public interface Job {
String getName();
/**
* @deprecated planned for removal in 2.0
* @return the {@link Step}s executed as part of this job.
*/
List<Step> getSteps();
boolean isRestartable();
/**

11
spring-batch-core/src/main/java/org/springframework/batch/core/configuration/support/ClassPathXmlApplicationContextJobFactory.java
View File

@@ -15,12 +15,9 @@
*/
package org.springframework.batch.core.configuration.support;
import java.util.List;
import org.springframework.batch.core.Job;
import org.springframework.batch.core.JobExecution;
import org.springframework.batch.core.JobExecutionException;
import org.springframework.batch.core.Step;
import org.springframework.batch.core.configuration.JobFactory;
import org.springframework.beans.BeansException;
import org.springframework.context.ApplicationContext;
@@ -138,14 +135,6 @@ public class ClassPathXmlApplicationContextJobFactory implements JobFactory, App
return delegate.getName();
}
/**
* @deprecated planned for removal in 2.0
* @see org.springframework.batch.core.Job#getSteps()
*/
public List<Step> getSteps() {
return delegate.getSteps();
}
/**
* @see org.springframework.batch.core.Job#isRestartable()
*/

2
spring-batch-core/src/main/java/org/springframework/batch/core/job/AbstractJob.java
View File

@@ -103,7 +103,7 @@ public abstract class AbstractJob implements Job, BeanNameAware, InitializingBea
/* (non-Javadoc)
* @see org.springframework.batch.core.domain.IJob#getSteps()
*/
public List<Step> getSteps() {
protected List<Step> getSteps() {
return steps;
}

7
spring-batch-core/src/test/java/org/springframework/batch/core/job/JobSupport.java
View File

@@ -95,13 +95,6 @@ public class JobSupport implements BeanNameAware, Job {
return name;
}
/* (non-Javadoc)
* @see org.springframework.batch.core.domain.IJob#getSteps()
*/
public List<Step> getSteps() {
return steps;
}
public void setSteps(List<Step> steps) {
this.steps.clear();
this.steps.addAll(steps);

8
spring-batch-integration/src/test/java/org/springframework/batch/integration/JobSupport.java
View File

@@ -1,7 +1,5 @@
package org.springframework.batch.integration;
import java.util.List;
import org.springframework.batch.core.Job;
import org.springframework.batch.core.JobExecution;
import org.springframework.batch.core.JobExecutionException;
@@ -22,12 +20,6 @@ public class JobSupport implements Job {
return name;
}
@SuppressWarnings("unchecked")
public List getSteps() {
// TODO Auto-generated method stub
return null;
}
public boolean isRestartable() {
// TODO Auto-generated method stub
return false;

7
spring-batch-samples/src/test/java/org/springframework/batch/sample/tasklet/JobSupport.java
View File

@@ -95,13 +95,6 @@ public class JobSupport implements BeanNameAware, Job {
return name;
}
/* (non-Javadoc)
* @see org.springframework.batch.core.domain.IJob#getSteps()
*/
public List<Step> getSteps() {
return steps;
}
public void setSteps(List<Step> steps) {
this.steps.clear();
this.steps.addAll(steps);