Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BATCH-1007: Job and Step now have consistent attribute names for referencing the job repository, they're both 'job-repository' now. The docs have been updated accordingly.

Browse Source
This commit is contained in:
lucasward
2009-01-28 20:12:42 +00:00
parent 921b0eb893
commit 81652cc6a1
4 changed files with 4 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spring-batch-core/src/main/java/org/springframework/batch/core/configuration/xml/JobParser.java
View File

@@ -49,10 +49,7 @@ public class JobParser extends AbstractBeanDefinitionParser {
String jobName = element.getAttribute("id");
builder.addConstructorArgValue(jobName);
String repositoryAttribute = element.getAttribute("repository");
if (!StringUtils.hasText(repositoryAttribute)) {
repositoryAttribute = "jobRepository";
}
String repositoryAttribute = element.getAttribute("job-repository");
builder.addPropertyReference("jobRepository", repositoryAttribute);
String restartableAttribute = element.getAttribute("restartable");

10
spring-batch-core/src/main/resources/org/springframework/batch/core/configuration/xml/spring-batch-2.0.xsd
View File

@@ -30,15 +30,7 @@
<xsd:complexContent>
<xsd:extension base="flowType">
<xsd:attribute name="id" type="xsd:ID" use="required" />
<xsd:attribute name="repository" type="xsd:string"
use="optional">
<xsd:annotation>
<xsd:documentation><![CDATA[
A reference to a JobRepository bean definition. Defaults to "jobRepository".
]]>
</xsd:documentation>
</xsd:annotation>
</xsd:attribute>
<xsd:attributeGroup ref="jobRepository"/>
<xsd:attribute name="incrementer" type="xsd:string"
use="optional">
<xsd:annotation>

2
spring-batch-core/src/test/resources/org/springframework/batch/core/configuration/xml/JobExecutionListenerParserTests-context.xml
View File

@@ -6,7 +6,7 @@
<beans:import resource="common-context.xml" />
<job id="job" incrementer="testIncrementer" repository="jobRepository">
<job id="job" incrementer="testIncrementer" job-repository="jobRepository">
<step name="step1" tasklet="tasklet"/>
<listeners>
<listener after-method="afterJob" ref="testListener"/>

2
spring-batch-core/src/test/resources/org/springframework/batch/core/configuration/xml/RepositoryJobParserTests-context.xml
View File

@@ -20,7 +20,7 @@
</beans:property>
</beans:bean>
<job id="job" repository="thisRepository">
<job id="job" job-repository="thisRepository">
<step name="step1" />
</job>