BATCH-750: An exception thrown from SkipListener#onSkipInRead will now be swalled and logged, rather than causing a rollback.

spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/AbstractBufferedItemReaderItemStreamTests.java

@@ -0,0 +1,125 @@
+/**
+ * 
+ */
+package org.springframework.batch.item.support;
+
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
+
+import junit.framework.TestCase;
+
+/**
+ * @author Lucas Ward
+ *
+ */
+public class AbstractBufferedItemReaderItemStreamTests extends TestCase {
+	
+	StringReader reader;
+	
+	/* (non-Javadoc)
+	 * @see junit.framework.TestCase#setUp()
+	 */
+	protected void setUp() throws Exception {
+		super.setUp();
+		
+		reader = new StringReader(Arrays.asList(new String[]{"a", "b", "c", "d", "e"}));
+	}
+	
+	public void testNormalUsage() throws Exception{
+		
+		assertEquals("a", reader.read());
+		assertEquals("b", reader.read());
+		assertEquals("c", reader.read());
+	}
+	
+	public void testMarkAndReset() throws Exception{
+		
+		reader.mark();
+		assertEquals("a", reader.read());
+		assertEquals("b", reader.read());
+		reader.reset();
+		assertEquals("a", reader.read());
+	}
+	
+	public void testReaderExceptionWithoutRollback() throws Exception{
+		
+		reader.mark();
+		assertEquals("a", reader.read());
+		assertEquals("b", reader.read());
+		reader.setThrowException(true);
+		try{
+			reader.read();
+			fail();
+		}
+		catch(RuntimeException ex){
+			//expected
+		}
+		reader.setThrowException(false);
+		reader.mark();
+		assertEquals("c", reader.read());
+		
+		assertEquals("d", reader.read());
+	}
+	
+	public void testResetWithoutException() throws Exception{
+		
+		reader.mark();
+		assertEquals("a", reader.read());
+		assertEquals("b", reader.read());
+		reader.reset();
+		assertEquals("a", reader.read());
+	}
+	
+	public void testResetWithException() throws Exception{
+		
+		reader.mark();
+		assertEquals("a", reader.read());
+		assertEquals("b", reader.read());
+		reader.setThrowException(true);
+		try{
+			reader.read();
+			fail();
+		}
+		catch(RuntimeException ex){
+			//expected
+		}
+		reader.setThrowException(false);
+		reader.reset();
+		assertEquals("a", reader.read());
+	}
+	
+	
+	private class StringReader extends AbstractBufferedItemReaderItemStream{
+
+		final Iterator iterator;
+		boolean throwException = false;
+		
+		public StringReader(List strings) {
+			iterator = strings.iterator();
+		}
+		
+		protected void doClose() throws Exception {
+			
+		}
+
+		protected void doOpen() throws Exception {
+			// TODO Auto-generated method stub
+			
+		}
+
+		protected Object doRead() throws Exception {
+			if(throwException){
+				throw new RuntimeException();
+			}
+			else{
+				return iterator.next();
+			}
+		}
+		
+		public void setThrowException(boolean throwException) {
+			this.throwException = throwException;
+		}
+		
+	}
+}