Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Tidy up some TODOs

Browse Source
This commit is contained in:
dsyer
2009-12-29 14:58:59 +00:00
parent 7e46c8abae
commit 90d008fdb1
8 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-batch-core/src/main/java/org/springframework/batch/core/job/flow/JobFlowExecutor.java
View File

@@ -93,9 +93,9 @@ public class JobFlowExecutor implements FlowExecutor {
if (getStepExecution() != null && getStepExecution().getStatus() == BatchStatus.ABANDONED) {
/*
* This is assumed to be the last step execution and it was marked
* abandoned, so we are in a restart of a stopped step. TODO: mark
* the step execution in some more definitive way?
* abandoned, so we are in a restart of a stopped step.
*/
// TODO: mark the step execution in some more definitive way?
return true;
}
return execution.getStepExecutions().isEmpty();

2
spring-batch-core/src/test/java/org/springframework/batch/core/configuration/support/OsgiBundleXmlApplicationContextFactoryTests.java
View File

@@ -30,6 +30,7 @@ import org.springframework.util.ClassUtils;
* @author Dave Syer
*
*/
@SuppressWarnings("deprecation")
public class OsgiBundleXmlApplicationContextFactoryTests {
private OsgiBundleXmlApplicationContextFactory factory = new OsgiBundleXmlApplicationContextFactory();
@@ -46,7 +47,6 @@ public class OsgiBundleXmlApplicationContextFactoryTests {
expect(bundleContext.getBundle()).andReturn(bundle).anyTimes();
replay(bundleContext, bundle);
factory.setBundleContext(bundleContext);
// TODO: mock out the OSGi bundle resource...
// factory.createApplicationContext();
verify(bundleContext, bundle);
}

7
spring-batch-core/src/test/java/org/springframework/batch/core/configuration/xml/DummyCompletionPolicy.java
View File

@@ -11,23 +11,18 @@ import org.springframework.batch.repeat.RepeatStatus;
public class DummyCompletionPolicy implements CompletionPolicy {
public boolean isComplete(RepeatContext context, RepeatStatus result) {
// TODO Auto-generated method stub
return false;
}
public boolean isComplete(RepeatContext context) {
// TODO Auto-generated method stub
return false;
}
public RepeatContext start(RepeatContext parent) {
// TODO Auto-generated method stub
return null;
}
public void update(RepeatContext context) {
// TODO Auto-generated method stub
public void update(RepeatContext context)
}
}

2
spring-batch-core/src/test/java/org/springframework/batch/core/job/flow/FlowStepTests.java
View File

@@ -47,8 +47,6 @@ public class FlowStepTests {
private JobRepository jobRepository;
private JobExecution jobExecution;
// TODO: add XML support
@Before
public void setUp() throws Exception {
jobRepository = new MapJobRepositoryFactoryBean().getJobRepository();

2
spring-batch-core/src/test/java/org/springframework/batch/core/step/item/FaultTolerantExceptionClassesTests.java
View File

@@ -256,7 +256,7 @@ public class FaultTolerantExceptionClassesTests implements ApplicationContextAwa
assertEquals(BatchStatus.COMPLETED, stepExecution.getStatus());
// BATCH-1332:
assertEquals("[1, 2, 3, 1, 2, 3, 4]", writer.getWritten().toString());
// TODO BATCH-1334:
// BATCH-1334:
// Skipped but also committed (because it was marked as no-rollback)
assertEquals("[1, 2, 3, 4]", writer.getCommitted().toString());
assertEquals(1, stepExecution.getWriteSkipCount());

2
spring-batch-infrastructure-tests/src/test/java/org/springframework/batch/io/oxm/AbstractStaxEventReaderItemReaderTests.java
View File

@@ -20,7 +20,7 @@ public abstract class AbstractStaxEventReaderItemReaderTests extends TestCase {
protected Resource resource = new ClassPathResource("org/springframework/batch/io/oxm/input.xml");
protected void setUp() throws Exception {
// TODO sensible resource allocation
source.setResource(resource);
source.setFragmentRootElementName("trade");

1
spring-batch-infrastructure/src/main/java/org/springframework/batch/item/xml/StaxEventItemReader.java
View File

@@ -101,7 +101,6 @@ public class StaxEventItemReader<T> extends AbstractItemCountingItemStreamItemRe
/**
* @param fragmentRootElementName name of the root element of the fragment
* TODO String can be ambiguous due to namespaces, use QName?
*/
public void setFragmentRootElementName(String fragmentRootElementName) {
this.fragmentRootElementName = fragmentRootElementName;

1
spring-batch-infrastructure/src/main/java/org/springframework/batch/repeat/support/RepeatTemplate.java
View File

@@ -263,7 +263,6 @@ public class RepeatTemplate implements RepeatOperations {
}
}
finally {
// TODO: extend this to the completion policy?
context.close();
}