OPEN - issue BATCH-787: Add write(List) to ItemWriter

Make samples and cli archetype compile again

spring-batch-integration/src/main/java/org/springframework/batch/integration/chunk/ChunkMessageChannelItemWriter.java

@@ -64,10 +64,12 @@ public class ChunkMessageChannelItemWriter<T> extends StepExecutionListenerSuppo
 		this.target = target;
 	}
 
-	public void write(T item) throws Exception {
+	public void write(List<? extends T> items) throws Exception {
 		bindTransactionResources();
-		getProcessed().add(item);
-		logger.debug("Added item to chunk: " + item);
+		for (T item : items) {
+			getProcessed().add(item);
+			logger.debug("Added item to chunk: " + item);
+		}
 	}
 
 	/**

spring-batch-integration/src/main/java/org/springframework/batch/integration/chunk/ItemWriterChunkHandler.java

@@ -1,5 +1,7 @@
 package org.springframework.batch.integration.chunk;
 
+import java.util.Collections;
+
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.springframework.batch.core.SkipListener;
@@ -55,7 +57,7 @@ public class ItemWriterChunkHandler<T> implements ChunkHandler<T> {
 		try {
 			for (T item : chunk.getItems()) {
 				try {
-					itemWriter.write(item);
+					itemWriter.write(Collections.singletonList(item));
 				}
 				catch (Exception e) {
 					if (itemSkipPolicy.shouldSkip(e, parentSkipCount + skipCount)) {

spring-batch-integration/src/main/java/org/springframework/batch/integration/item/MessageChannelItemWriter.java

@@ -15,6 +15,8 @@
  */
 package org.springframework.batch.integration.item;
 
+import java.util.List;
+
 import org.springframework.batch.item.support.AbstractItemWriter;
 import org.springframework.beans.factory.annotation.Required;
 import org.springframework.integration.channel.MessageChannel;
@@ -39,10 +41,13 @@ public class MessageChannelItemWriter<T> extends AbstractItemWriter<T> {
 
 	/*
 	 * (non-Javadoc)
+	 * 
 	 * @see org.springframework.batch.item.ItemWriter#write(java.lang.Object)
 	 */
-	public void write(T item) throws Exception {
-		channel.send(new GenericMessage<T>(item));
+	public void write(List<? extends T> items) throws Exception {
+		for (T item : items) {
+			channel.send(new GenericMessage<T>(item));
+		}
 	}
 
 }

spring-batch-integration/src/test/java/org/springframework/batch/integration/chunk/ItemWriterChunkHandlerTests.java

@@ -2,13 +2,12 @@ package org.springframework.batch.integration.chunk;
 
 import static org.junit.Assert.assertEquals;
 
+import java.util.List;
+
 import org.junit.Test;
 import org.springframework.batch.core.SkipListener;
 import org.springframework.batch.core.listener.SkipListenerSupport;
 import org.springframework.batch.core.step.skip.AlwaysSkipItemSkipPolicy;
-import org.springframework.batch.integration.chunk.ChunkRequest;
-import org.springframework.batch.integration.chunk.ChunkResponse;
-import org.springframework.batch.integration.chunk.ItemWriterChunkHandler;
 import org.springframework.batch.item.support.AbstractItemWriter;
 import org.springframework.batch.repeat.ExitStatus;
 import org.springframework.util.StringUtils;
@@ -29,9 +28,9 @@ public class ItemWriterChunkHandlerTests {
 	@SuppressWarnings("unchecked")
 	@Test
 	public void testVanillaHandleChunk() {
-		handler.setItemWriter(new AbstractItemWriter() {
-			public void write(Object item) throws Exception {
-				count++;
+		handler.setItemWriter(new AbstractItemWriter<Object>() {
+			public void write(List<? extends Object> items) throws Exception {
+				count+=items.size();
 			}
 		});
 		ChunkResponse response = handler.handleChunk(new ChunkRequest(StringUtils.commaDelimitedListToSet("foo,bar"),
@@ -45,9 +44,9 @@ public class ItemWriterChunkHandlerTests {
 	@SuppressWarnings("unchecked")
 	@Test
 	public void testSetItemSkipPolicy() {
-		handler.setItemWriter(new AbstractItemWriter() {
-			public void write(Object item) throws Exception {
-				count++;
+		handler.setItemWriter(new AbstractItemWriter<Object>() {
+			public void write(List<? extends Object> items) throws Exception {
+				count+=items.size();
 				throw new RuntimeException("Planned failure");
 			}
 		});
@@ -63,9 +62,9 @@ public class ItemWriterChunkHandlerTests {
 	@SuppressWarnings("unchecked")
 	@Test
 	public void testRegisterSkipListener() {
-		handler.setItemWriter(new AbstractItemWriter() {
-			public void write(Object item) throws Exception {
-				count++;
+		handler.setItemWriter(new AbstractItemWriter<Object>() {
+			public void write(List<? extends Object> items) throws Exception {
+				count+=items.size();
 				throw new RuntimeException("Planned failure");
 			}
 		});

spring-batch-integration/src/test/java/org/springframework/batch/integration/chunk/TestItemWriter.java

@@ -1,5 +1,7 @@
 package org.springframework.batch.integration.chunk;
 
+import java.util.List;
+
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.springframework.batch.item.support.AbstractItemWriter;
@@ -25,23 +27,28 @@ public class TestItemWriter<T> extends AbstractItemWriter<T> {
 	 */
 	public static final String WAIT_ON = "wait";
 
-	public void write(T item) throws Exception {
-		
-		count++;
-		
-		logger.debug("Writing: "+item);
+	public void write(List<? extends T> items) throws Exception {
 
-		if (item.equals(WAIT_ON)) {
-			try {
-				Thread.sleep(200);
-			} catch (InterruptedException e) {
-				Thread.currentThread().interrupt();
-				throw new RuntimeException("Unexpected interruption.", e);
+		for (T item : items) {
+
+			count++;
+
+			logger.debug("Writing: " + item);
+
+			if (item.equals(WAIT_ON)) {
+				try {
+					Thread.sleep(200);
+				}
+				catch (InterruptedException e) {
+					Thread.currentThread().interrupt();
+					throw new RuntimeException("Unexpected interruption.", e);
+				}
+			}
+
+			if (item.equals(FAIL_ON)) {
+				throw new IllegalStateException("Planned failure on: " + FAIL_ON);
 			}
-		}
 
-		if (item.equals(FAIL_ON)) {
-			throw new IllegalStateException("Planned failure on: " + FAIL_ON);
 		}
 
 	}

spring-batch-integration/src/test/java/org/springframework/batch/integration/item/MessageChannelItemWriterIntegrationTests.java

@@ -18,6 +18,8 @@ package org.springframework.batch.integration.item;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 
+import java.util.Collections;
+
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.springframework.batch.item.ItemWriter;
@@ -43,7 +45,7 @@ public class MessageChannelItemWriterIntegrationTests {
 	
 	@Test
 	public void testSend() throws Exception {
-		itemWriter.write("foo");
+		itemWriter.write(Collections.singletonList("foo"));
 		Message<?> message = channel.receive(10);
 		assertNotNull(message);
 		assertEquals("foo", message.getPayload());

spring-batch-integration/src/test/java/org/springframework/batch/integration/item/MessageChannelItemWriterTests.java

@@ -21,6 +21,7 @@ import static org.junit.Assert.fail;
 
 import java.lang.annotation.Annotation;
 import java.lang.reflect.Method;
+import java.util.Collections;
 
 import org.junit.Test;
 import org.springframework.beans.factory.annotation.Required;
@@ -63,7 +64,7 @@ public class MessageChannelItemWriterTests {
 		channel.subscribe(receiver);
 		MessageChannelItemWriter<String> writer = new MessageChannelItemWriter<String>();
 		writer.setChannel(channel);
-		writer.write("foo");
+		writer.write(Collections.singletonList("foo"));
 		Message<?> message = receiver.receive(10);
 		assertNotNull(message);
 		assertEquals("foo", message.getPayload());
@@ -84,7 +85,7 @@ public class MessageChannelItemWriterTests {
 		MessageChannelItemWriter<String> writer = new MessageChannelItemWriter<String>();
 		writer.setChannel(channel);
 		try {
-			writer.write("foo");
+			writer.write(Collections.singletonList("foo"));
 			fail("Expected RuntimeException");
 		}
 		catch (RuntimeException e) {
@@ -108,7 +109,7 @@ public class MessageChannelItemWriterTests {
 		MessageChannelItemWriter<String> writer = new MessageChannelItemWriter<String>();
 		writer.setChannel(channel);
 		try {
-			writer.write("foo");
+			writer.write(Collections.singletonList("foo"));
 			fail("Expected RuntimeException");
 		}
 		catch (RuntimeException e) {

spring-batch-samples/src/main/java/org/springframework/batch/sample/common/StagingItemWriter.java

@@ -3,6 +3,7 @@ package org.springframework.batch.sample.common;
 import java.io.Serializable;
 import java.sql.PreparedStatement;
 import java.sql.SQLException;
+import java.util.List;
 
 import org.apache.commons.lang.SerializationUtils;
 import org.springframework.batch.core.StepExecution;
@@ -68,22 +69,28 @@ public class StagingItemWriter<T> extends JdbcDaoSupport implements StepExecutio
 	/**
 	 * Serialize the item to the staging table, and add a NEW processed flag.
 	 * 
-	 * @see ItemWriter#write(java.lang.Object)
+	 * @see ItemWriter#write(java.util.List)
 	 */
-	public void write(T data) {
-		final long id = incrementer.nextLongValue();
-		final long jobId = stepExecution.getJobExecution().getJobId();
-		final byte[] blob = SerializationUtils.serialize((Serializable) data);
-		getJdbcTemplate().update("INSERT into BATCH_STAGING (ID, JOB_ID, VALUE, PROCESSED) values (?,?,?,?)",
-				new PreparedStatementSetter() {
-					public void setValues(PreparedStatement ps) throws SQLException {
-						ps.setLong(1, id);
-						ps.setLong(2, jobId);
-						lobHandler.getLobCreator().setBlobAsBytes(ps, 3, blob);
-						ps.setString(4, NEW);
-					}
+	public void write(List<? extends T> items) {
+
+		for (T data : items) {
+
+			final long id = incrementer.nextLongValue();
+			final long jobId = stepExecution.getJobExecution().getJobId();
+			final byte[] blob = SerializationUtils.serialize((Serializable) data);
+			getJdbcTemplate().update("INSERT into BATCH_STAGING (ID, JOB_ID, VALUE, PROCESSED) values (?,?,?,?)",
+					new PreparedStatementSetter() {
+						public void setValues(PreparedStatement ps) throws SQLException {
+							ps.setLong(1, id);
+							ps.setLong(2, jobId);
+							lobHandler.getLobCreator().setBlobAsBytes(ps, 3, blob);
+							ps.setString(4, NEW);
+						}
+
+					});
+
+		}
 
-				});
 	}
 
 	public void clear() throws ClearFailedException {

spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/internal/JdbcGameDao.java

@@ -1,5 +1,7 @@
 package org.springframework.batch.sample.domain.football.internal;
 
+import java.util.List;
+
 import org.springframework.batch.item.ClearFailedException;
 import org.springframework.batch.item.FlushFailedException;
 import org.springframework.batch.item.ItemWriter;
@@ -13,35 +15,28 @@ public class JdbcGameDao extends SimpleJdbcDaoSupport implements ItemWriter<Game
 
 	private SimpleJdbcInsert insertGame;
 
-
 	protected void initDao() throws Exception {
 		super.initDao();
-		insertGame = new SimpleJdbcInsert(getDataSource())
-				.withTableName("GAMES")
-				.usingColumns("player_id", "year_no", "team", "week", "opponent", " completes", "attempts",
-						"passing_yards", "passing_td", "interceptions", "rushes", "rush_yards", "receptions",
-						"receptions_yards", "total_td");
+		insertGame = new SimpleJdbcInsert(getDataSource()).withTableName("GAMES").usingColumns("player_id", "year_no",
+				"team", "week", "opponent", " completes", "attempts", "passing_yards", "passing_td", "interceptions",
+				"rushes", "rush_yards", "receptions", "receptions_yards", "total_td");
 	}
 
-	public void write(Game game) {
-		
-		SqlParameterSource values = new MapSqlParameterSource()
-				.addValue("player_id", game.getId())
-				.addValue("year_no", game.getYear())
-				.addValue("team", game.getTeam())
-				.addValue("week", game.getWeek())
-				.addValue("opponent", game.getOpponent())
-				.addValue("completes", game.getCompletes())
-				.addValue("attempts", game.getAttempts())
-				.addValue("passing_yards", game.getPassingYards())
-				.addValue("passing_td", game.getPassingTd())
-				.addValue("interceptions", game.getInterceptions())
-				.addValue("rushes", game.getRushes())
-				.addValue("rush_yards", game.getRushYards())
-				.addValue("receptions", game.getReceptions())
-				.addValue("receptions_yards", game.getReceptionYards())
-				.addValue("total_td", game.getTotalTd());
-		this.insertGame.execute(values);
+	public void write(List<? extends Game> games) {
+
+		for (Game game : games) {
+
+			SqlParameterSource values = new MapSqlParameterSource().addValue("player_id", game.getId()).addValue(
+					"year_no", game.getYear()).addValue("team", game.getTeam()).addValue("week", game.getWeek())
+					.addValue("opponent", game.getOpponent()).addValue("completes", game.getCompletes()).addValue(
+							"attempts", game.getAttempts()).addValue("passing_yards", game.getPassingYards()).addValue(
+							"passing_td", game.getPassingTd()).addValue("interceptions", game.getInterceptions())
+					.addValue("rushes", game.getRushes()).addValue("rush_yards", game.getRushYards()).addValue(
+							"receptions", game.getReceptions()).addValue("receptions_yards", game.getReceptionYards())
+					.addValue("total_td", game.getTotalTd());
+			this.insertGame.execute(values);
+
+		}
 
 	}
 

spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/internal/JdbcPlayerSummaryDao.java

@@ -1,5 +1,7 @@
 package org.springframework.batch.sample.domain.football.internal;
 
+import java.util.List;
+
 import org.springframework.batch.item.ClearFailedException;
 import org.springframework.batch.item.FlushFailedException;
 import org.springframework.batch.item.ItemWriter;
@@ -9,30 +11,27 @@ import org.springframework.jdbc.core.namedparam.MapSqlParameterSource;
 
 public class JdbcPlayerSummaryDao extends SimpleJdbcDaoSupport implements ItemWriter<PlayerSummary> {
 
-	private static final String INSERT_SUMMARY =
-			"INSERT into PLAYER_SUMMARY(ID, YEAR_NO, COMPLETES, ATTEMPTS, PASSING_YARDS, PASSING_TD, " +
-					"INTERCEPTIONS, RUSHES, RUSH_YARDS, RECEPTIONS, RECEPTIONS_YARDS, TOTAL_TD) " +
-					"values(:id, :year, :completes, :attempts, :passingYards, :passingTd, " +
-					":interceptions, :rushes, :rushYards, :receptions, :receptionYards, :totalTd)";
-	
-	public void write(PlayerSummary summary) {
-		
-		MapSqlParameterSource args = new MapSqlParameterSource()
-				.addValue("id", summary.getId())
-				.addValue("year", summary.getYear())
-				.addValue("completes", summary.getCompletes())
-				.addValue("attempts", summary.getAttempts())
-				.addValue("passingYards", summary.getPassingYards())
-				.addValue("passingTd", summary.getPassingTd())
-				.addValue("interceptions", summary.getInterceptions())
-				.addValue("rushes", summary.getRushes())
-				.addValue("rushYards", summary.getRushYards())
-				.addValue("receptions", summary.getReceptions())
-				.addValue("receptionYards", summary.getReceptionYards())
-				.addValue("totalTd", summary.getTotalTd());
+	private static final String INSERT_SUMMARY = "INSERT into PLAYER_SUMMARY(ID, YEAR_NO, COMPLETES, ATTEMPTS, PASSING_YARDS, PASSING_TD, "
+			+ "INTERCEPTIONS, RUSHES, RUSH_YARDS, RECEPTIONS, RECEPTIONS_YARDS, TOTAL_TD) "
+			+ "values(:id, :year, :completes, :attempts, :passingYards, :passingTd, "
+			+ ":interceptions, :rushes, :rushYards, :receptions, :receptionYards, :totalTd)";
+
+	public void write(List<? extends PlayerSummary> summaries) {
+
+		for (PlayerSummary summary : summaries) {
+
+			MapSqlParameterSource args = new MapSqlParameterSource().addValue("id", summary.getId()).addValue("year",
+					summary.getYear()).addValue("completes", summary.getCompletes()).addValue("attempts",
+					summary.getAttempts()).addValue("passingYards", summary.getPassingYards()).addValue("passingTd",
+					summary.getPassingTd()).addValue("interceptions", summary.getInterceptions()).addValue("rushes",
+					summary.getRushes()).addValue("rushYards", summary.getRushYards()).addValue("receptions",
+					summary.getReceptions()).addValue("receptionYards", summary.getReceptionYards()).addValue(
+					"totalTd", summary.getTotalTd());
+
+			getSimpleJdbcTemplate().update(INSERT_SUMMARY, args);
+
+		}
 
-		getSimpleJdbcTemplate().update(INSERT_SUMMARY, args);
-		
 	}
 
 	public void close() throws Exception {

spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/football/internal/PlayerItemWriter.java

@@ -1,5 +1,7 @@
 package org.springframework.batch.sample.domain.football.internal;
 
+import java.util.List;
+
 import org.springframework.batch.item.support.AbstractItemWriter;
 import org.springframework.batch.sample.domain.football.Player;
 import org.springframework.batch.sample.domain.football.PlayerDao;
@@ -7,13 +9,15 @@ import org.springframework.batch.sample.domain.football.PlayerDao;
 public class PlayerItemWriter extends AbstractItemWriter<Player> {
 
 	private PlayerDao playerDao;
-	
-	public void write(Player player) throws Exception {		
-		playerDao.savePlayer(player);
+
+	public void write(List<? extends Player> players) throws Exception {
+		for (Player player : players) {
+			playerDao.savePlayer(player);
+		}
 	}
 
 	public void setPlayerDao(PlayerDao playerDao) {
 		this.playerDao = playerDao;
 	}
-	
+
 }

spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/person/internal/PersonWriter.java

@@ -16,6 +16,8 @@
 
 package org.springframework.batch.sample.domain.person.internal;
 
+import java.util.List;
+
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.springframework.batch.item.support.AbstractItemWriter;
@@ -26,10 +28,8 @@ import org.springframework.batch.sample.domain.person.Person;
 public class PersonWriter extends AbstractItemWriter<Person> {
     private static Log log = LogFactory.getLog(PersonWriter.class);
  
-    public void write(Person data) {
-
+    public void write(List<? extends Person> data) {
         log.debug("Processing: " + data);
-
     }
 
 }

spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/trade/internal/CustomerCreditIncreaseWriter.java

@@ -1,6 +1,7 @@
 package org.springframework.batch.sample.domain.trade.internal;
 
 import java.math.BigDecimal;
+import java.util.List;
 
 import org.springframework.batch.item.support.AbstractItemWriter;
 import org.springframework.batch.sample.domain.trade.CustomerCredit;
@@ -14,9 +15,9 @@ import org.springframework.batch.sample.domain.trade.CustomerCreditDao;
 public class CustomerCreditIncreaseWriter extends AbstractItemWriter<CustomerCredit> {
 
 	public static final BigDecimal FIXED_AMOUNT = new BigDecimal("1000");
-	
+
 	private CustomerCreditDao customerCreditDao;
-	
+
 	/**
 	 * Public setter for the {@link CustomerCreditDao}.
 	 * @param customerCreditDao the {@link CustomerCreditDao} to set
@@ -24,13 +25,19 @@ public class CustomerCreditIncreaseWriter extends AbstractItemWriter<CustomerCre
 	public void setCustomerCreditDao(CustomerCreditDao customerCreditDao) {
 		this.customerCreditDao = customerCreditDao;
 	}
-	
-	/* (non-Javadoc)
-	 * @see org.springframework.batch.item.processor.DelegatingItemWriter#doProcess(java.lang.Object)
+
+	/*
+	 * (non-Javadoc)
+	 * 
+	 * @see
+	 * org.springframework.batch.item.processor.DelegatingItemWriter#doProcess
+	 * (java.lang.Object)
 	 */
-	public void write(CustomerCredit customerCredit) throws Exception {
-		CustomerCredit result = customerCredit.increaseCreditBy(FIXED_AMOUNT);
-		customerCreditDao.writeCredit(result);
+	public void write(List<? extends CustomerCredit> customerCredits) throws Exception {
+		for (CustomerCredit customerCredit : customerCredits) {
+			CustomerCredit result = customerCredit.increaseCreditBy(FIXED_AMOUNT);
+			customerCreditDao.writeCredit(result);
+		}
 	}
 
 }

spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/trade/internal/CustomerCreditUpdateWriter.java

@@ -16,29 +16,31 @@
 
 package org.springframework.batch.sample.domain.trade.internal;
 
+import java.util.List;
+
 import org.springframework.batch.item.support.AbstractItemWriter;
 import org.springframework.batch.sample.domain.trade.CustomerCredit;
 import org.springframework.batch.sample.domain.trade.CustomerCreditDao;
 
-
-
 public class CustomerCreditUpdateWriter extends AbstractItemWriter<CustomerCredit> {
-    private double creditFilter = 800;
-    private CustomerCreditDao dao;
+	private double creditFilter = 800;
 
-    public void write(CustomerCredit customerCredit) throws Exception {
+	private CustomerCreditDao dao;
 
-        if (customerCredit.getCredit().doubleValue() > creditFilter) {
-            dao.writeCredit(customerCredit);
-        }
-    }
+	public void write(List<? extends CustomerCredit> customerCredits) throws Exception {
+		for (CustomerCredit customerCredit : customerCredits) {
+			if (customerCredit.getCredit().doubleValue() > creditFilter) {
+				dao.writeCredit(customerCredit);
+			}
+		}
+	}
 
-    public void setCreditFilter(double creditFilter) {
-        this.creditFilter = creditFilter;
-    }
+	public void setCreditFilter(double creditFilter) {
+		this.creditFilter = creditFilter;
+	}
 
-    public void setDao(CustomerCreditDao dao) {
-        this.dao = dao;
-    }
+	public void setDao(CustomerCreditDao dao) {
+		this.dao = dao;
+	}
 
 }

spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/trade/internal/CustomerUpdateWriter.java

@@ -16,14 +16,16 @@
 
 package org.springframework.batch.sample.domain.trade.internal;
 
+import java.util.List;
+
 import org.springframework.batch.item.support.AbstractItemWriter;
 import org.springframework.batch.sample.domain.trade.CustomerDebit;
 import org.springframework.batch.sample.domain.trade.CustomerDebitDao;
 import org.springframework.batch.sample.domain.trade.Trade;
 
-
 /**
- * Transforms Trade to a CustomerDebit and asks DAO delegate to write the result.
+ * Transforms Trade to a CustomerDebit and asks DAO delegate to write the
+ * result.
  * 
  * @author Robert Kasanicky
  */
@@ -31,14 +33,16 @@ public class CustomerUpdateWriter extends AbstractItemWriter<Trade> {
 
 	private CustomerDebitDao dao;
 
-    public void write(Trade trade) {
-        CustomerDebit customerDebit = new CustomerDebit();
-        customerDebit.setName(trade.getCustomer());
-        customerDebit.setDebit(trade.getPrice());
-        dao.write(customerDebit);
-    }
+	public void write(List<? extends Trade> trades) {
+		for (Trade trade : trades) {
+			CustomerDebit customerDebit = new CustomerDebit();
+			customerDebit.setName(trade.getCustomer());
+			customerDebit.setDebit(trade.getPrice());
+			dao.write(customerDebit);
+		}
+	}
 
-    public void setDao(CustomerDebitDao outputSource) {
-        this.dao = outputSource;
-    }
+	public void setDao(CustomerDebitDao outputSource) {
+		this.dao = outputSource;
+	}
 }

spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/trade/internal/FlatFileCustomerCreditDao.java

@@ -16,6 +16,8 @@
 
 package org.springframework.batch.sample.domain.trade.internal;
 
+import java.util.Collections;
+
 import org.springframework.batch.item.ExecutionContext;
 import org.springframework.batch.item.ItemStream;
 import org.springframework.batch.item.ItemWriter;
@@ -47,7 +49,7 @@ public class FlatFileCustomerCreditDao implements CustomerCreditDao,
 		String line = "" + customerCredit.getName() + separator
 				+ customerCredit.getCredit();
 
-		itemWriter.write(line);
+		itemWriter.write(Collections.singletonList(line));
 	}
 
 	public void setSeparator(String separator) {

spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/trade/internal/TradeWriter.java

@@ -16,6 +16,8 @@
 
 package org.springframework.batch.sample.domain.trade.internal;
 
+import java.util.List;
+
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.springframework.batch.item.support.AbstractItemWriter;
@@ -44,14 +46,18 @@ public class TradeWriter extends AbstractItemWriter<Trade> {
 		this.failure = failure;
 	}
 
-	public void write(Trade trade) {
+	public void write(List<? extends Trade> trades) {
 
-		log.debug(trade);
+		for (Trade trade : trades) {
 
-		dao.writeTrade(trade);
+			log.debug(trade);
+
+			dao.writeTrade(trade);
+
+			if (index++ == failure) {
+				throw new RuntimeException("Something unexpected happened!");
+			}
 
-		if (index++ == failure) {
-			throw new RuntimeException("Something unexpected happened!");
 		}
 
 	}

spring-batch-samples/src/main/java/org/springframework/batch/sample/support/DummyItemWriter.java

@@ -15,6 +15,8 @@
  */
 package org.springframework.batch.sample.support;
 
+import java.util.List;
+
 import org.springframework.batch.item.support.AbstractItemWriter;
 
 /**
@@ -23,7 +25,7 @@ import org.springframework.batch.item.support.AbstractItemWriter;
  */
 public class DummyItemWriter extends AbstractItemWriter<Object> {
 
-	public void write(Object item) throws Exception {
+	public void write(List<? extends Object> item) throws Exception {
 		// NO-OP
 	}
 

spring-batch-samples/src/main/java/org/springframework/batch/sample/support/ItemTrackingItemWriter.java

@@ -12,15 +12,16 @@ import org.springframework.batch.item.validator.ValidationException;
 public class ItemTrackingItemWriter<T> extends AbstractItemWriter<T> {
 
 	private List<T> items = new ArrayList<T>();
-	
+
 	private int failure = -1;
-	
+
 	private int counter = 0;
-	
-	public void write(T item) throws Exception {
-		
-		items.add(item);
-		if (++counter == failure) {
+
+	public void write(List<? extends T> item) throws Exception {
+		items.addAll(item);
+		int current = counter;
+		counter += item.size();
+		if (current < failure && counter >= failure) {
 			throw new ValidationException("validation failed");
 		}
 	}

spring-batch-samples/src/main/java/org/springframework/batch/sample/support/RetrySampleItemWriter.java

@@ -1,26 +1,29 @@
 package org.springframework.batch.sample.support;
 
+import java.util.List;
+
 import org.springframework.batch.item.support.AbstractItemWriter;
 
 /**
- * Simulates temporary output trouble - requires to
- * retry 3 times to pass successfully.
+ * Simulates temporary output trouble - requires to retry 3 times to pass
+ * successfully.
  * 
  * @author Robert Kasanicky
  */
 public class RetrySampleItemWriter<T> extends AbstractItemWriter<T> {
 
 	private int counter = 0;
-	
-	public void write(T data) throws Exception {
-		counter++;
-		if (counter == 2 || counter == 3) {
+
+	public void write(List<? extends T> items) throws Exception {
+		int current = counter;
+		counter += items.size();
+		if (current < 3 && (counter >= 2 || counter >= 3)) {
 			throw new RuntimeException("Temporary error");
 		}
 	}
 
 	/**
-	 * @return number of times {@link #write(Object)} method was called.
+	 * @return number of times {@link #write(List)} method was called.
 	 */
 	public int getCounter() {
 		return counter;

spring-batch-samples/src/test/java/org/springframework/batch/sample/common/CustomItemWriterTests.java

@@ -16,6 +16,8 @@
 package org.springframework.batch.sample.common;
 
 import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 
 import junit.framework.TestCase;
@@ -42,39 +44,37 @@ public class CustomItemWriterTests extends TestCase {
 	protected void setUp() throws Exception {
 		super.setUp();
 	}
-	
-	public void testFlush() throws Exception{
-		
+
+	public void testFlush() throws Exception {
+
 		CustomItemWriter<String> itemWriter = new CustomItemWriter<String>();
-		itemWriter.write("1");
+		itemWriter.write(Collections.singletonList("1"));
 		assertEquals(0, itemWriter.getOutput().size());
 		itemWriter.flush();
 		assertEquals(1, itemWriter.getOutput().size());
-		itemWriter.write("2");
-		itemWriter.write("3");
+		itemWriter.write(Arrays.asList(new String[] {"2","3"}));
 		itemWriter.clear();
 		assertEquals(1, itemWriter.getOutput().size());
 	}
 
-	public class CustomItemWriter<T> implements ItemWriter<T>{
-		
+	public class CustomItemWriter<T> implements ItemWriter<T> {
+
 		List<T> output = new ArrayList<T>();
+
 		List<T> buffer = new ArrayList<T>();
 
-		public void write(T item) throws Exception {
-			buffer.add(item);
+		public void write(List<? extends T> items) throws Exception {
+			buffer.addAll(items);
 		}
-		
+
 		public void clear() throws ClearFailedException {
 			buffer.clear();
 		}
 
 		public void flush() throws FlushFailedException {
-			for(T t:buffer){
-				output.add(t);
-			}
+			output.addAll(buffer);
 		}
-		
+
 		public List<T> getOutput() {
 			return output;
 		}

spring-batch-samples/src/test/java/org/springframework/batch/sample/common/StagingItemReaderTests.java

@@ -2,6 +2,8 @@ package org.springframework.batch.sample.common;
 
 import static org.junit.Assert.assertEquals;
 
+import java.util.Arrays;
+
 import javax.sql.DataSource;
 
 import org.junit.After;
@@ -53,10 +55,7 @@ public class StagingItemReaderTests {
 				new JobParameters(), "testJob")));
 		reader.beforeStep(stepExecution);
 		writer.beforeStep(stepExecution);
-		writer.write("FOO");
-		writer.write("BAR");
-		writer.write("SPAM");
-		writer.write("BUCKET");
+		writer.write(Arrays.asList(new String[] {"FOO","BAR","SPAM","BUCKET"}));
 		reader.open(new ExecutionContext());
 	}
 

spring-batch-samples/src/test/java/org/springframework/batch/sample/common/StagingItemWriterTests.java

@@ -17,6 +17,8 @@ package org.springframework.batch.sample.common;
 
 import static org.junit.Assert.assertEquals;
 
+import java.util.Collections;
+
 import javax.sql.DataSource;
 
 import org.junit.Before;
@@ -57,7 +59,7 @@ public class StagingItemWriterTests {
 	@Test
 	public void testProcessInsertsNewItem() throws Exception {
 		int before = simpleJdbcTemplate.queryForInt("SELECT COUNT(*) from BATCH_STAGING");
-		writer.write("FOO");
+		writer.write(Collections.singletonList("FOO"));
 		int after = simpleJdbcTemplate.queryForInt("SELECT COUNT(*) from BATCH_STAGING");
 		assertEquals(before + 1, after);
 	}

spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/football/internal/JdbcGameDaoIntegrationTests.java

@@ -19,6 +19,7 @@ import static org.junit.Assert.assertEquals;
 
 import java.sql.ResultSet;
 import java.sql.SQLException;
+import java.util.Collections;
 
 import javax.sql.DataSource;
 
@@ -79,7 +80,7 @@ public class JdbcGameDaoIntegrationTests {
 	@Transactional @Test
 	public void testWrite() {
 
-		gameDao.write(game);
+		gameDao.write(Collections.singletonList(game));
 
 		Game tempGame = simpleJdbcTemplate.queryForObject("SELECT * FROM GAMES where PLAYER_ID=? AND YEAR_NO=?",
 				new GameRowMapper(), "XXXXX00 ", game.getYear());

spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/football/internal/JdbcPlayerSummaryDaoIntegrationTests.java

@@ -17,6 +17,8 @@ package org.springframework.batch.sample.domain.football.internal;
 
 import static org.junit.Assert.assertEquals;
 
+import java.util.Collections;
+
 import javax.sql.DataSource;
 
 import org.junit.Before;
@@ -29,13 +31,12 @@ import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
 import org.springframework.transaction.annotation.Transactional;
 
-
 /**
  * @author Lucas Ward
  * 
  */
 @RunWith(SpringJUnit4ClassRunner.class)
-@ContextConfiguration(locations = {"/data-source-context.xml"})
+@ContextConfiguration(locations = { "/data-source-context.xml" })
 public class JdbcPlayerSummaryDaoIntegrationTests {
 
 	private JdbcPlayerSummaryDao playerSummaryDao;
@@ -73,17 +74,18 @@ public class JdbcPlayerSummaryDaoIntegrationTests {
 		simpleJdbcTemplate.getJdbcOperations().execute("delete from PLAYER_SUMMARY");
 
 	}
-	
-	@Transactional @Test
+
+	@Transactional
+	@Test
 	public void testWrite() {
 
-		playerSummaryDao.write(summary);
+		playerSummaryDao.write(Collections.singletonList(summary));
 
 		PlayerSummary testSummary = simpleJdbcTemplate.queryForObject("SELECT * FROM PLAYER_SUMMARY",
-						new PlayerSummaryMapper());
+				new PlayerSummaryMapper());
 
 		assertEquals(summary, testSummary);
-		
+
 	}
 
 }

spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/trade/internal/CustomerCreditIncreaseProcessorTests.java

@@ -3,6 +3,7 @@ package org.springframework.batch.sample.domain.trade.internal;
 import static org.junit.Assert.assertTrue;
 
 import java.math.BigDecimal;
+import java.util.Collections;
 
 import org.junit.Test;
 import org.springframework.batch.sample.domain.trade.CustomerCredit;
@@ -40,7 +41,7 @@ public class CustomerCreditIncreaseProcessorTests {
 
 		customerCredit.setCredit(oldCredit);
 
-		writer.write(customerCredit);
+		writer.write(Collections.singletonList(customerCredit));
 
 	}
 }

spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/trade/internal/CustomerCreditUpdateProcessorTests.java

@@ -3,6 +3,7 @@ package org.springframework.batch.sample.domain.trade.internal;
 import static org.easymock.EasyMock.*;
 
 import java.math.BigDecimal;
+import java.util.Collections;
 
 import org.junit.Before;
 import org.junit.Test;
@@ -35,7 +36,7 @@ public class CustomerCreditUpdateProcessorTests {
 		CustomerCredit credit = new CustomerCredit();
 		credit.setCredit(new BigDecimal(CREDIT_FILTER));
 		//call tested method
-		writer.write(credit);
+		writer.write(Collections.singletonList(credit));
 		//verify method calls - no method should be called 
 		//because credit is not greater then credit filter
 		verify(dao);
@@ -48,7 +49,7 @@ public class CustomerCreditUpdateProcessorTests {
 		replay(dao);
 		
 		//call tested method
-		writer.write(credit);
+		writer.write(Collections.singletonList(credit));
 		
 		//verify method calls
 		verify(dao);

spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/trade/internal/CustomerUpdateProcessorTests.java

@@ -3,6 +3,7 @@ package org.springframework.batch.sample.domain.trade.internal;
 import static org.junit.Assert.assertEquals;
 
 import java.math.BigDecimal;
+import java.util.Collections;
 
 import org.junit.Test;
 import org.springframework.batch.sample.domain.trade.CustomerDebit;
@@ -32,6 +33,6 @@ public class CustomerUpdateProcessorTests {
 		processor.setDao(dao);
 		
 		//call tested method - see asserts in dao.write() method
-		processor.write(trade);
+		processor.write(Collections.singletonList(trade));
 	}
 }

spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/trade/internal/FlatFileCustomerCreditDaoTests.java

@@ -20,6 +20,7 @@ import static org.easymock.EasyMock.replay;
 import static org.easymock.EasyMock.verify;
 
 import java.math.BigDecimal;
+import java.util.Collections;
 
 import org.junit.Before;
 import org.junit.Test;
@@ -84,7 +85,7 @@ public class FlatFileCustomerCreditDaoTests {
 		writer.setSeparator(";");
 		
 		//set-up OutputSource mock
-		output.write("testName;1");
+		output.write(Collections.singletonList("testName;1"));
 		output.open(new ExecutionContext());
 		replay(output);
 

spring-batch-samples/src/test/java/org/springframework/batch/sample/domain/trade/internal/TradeProcessorTests.java

@@ -1,6 +1,10 @@
 package org.springframework.batch.sample.domain.trade.internal;
 
-import static org.easymock.EasyMock.*;
+import static org.easymock.EasyMock.createMock;
+import static org.easymock.EasyMock.replay;
+import static org.easymock.EasyMock.verify;
+
+import java.util.Collections;
 
 import org.junit.Before;
 import org.junit.Test;
@@ -32,7 +36,7 @@ public class TradeProcessorTests {
 		replay(writer);
 		
 		//call tested method
-		processor.write(trade);
+		processor.write(Collections.singletonList(trade));
 		
 		//verify method calls
 		verify(writer);

spring-batch-samples/src/test/java/org/springframework/batch/sample/support/RetrySampleItemWriterTests.java

@@ -3,6 +3,9 @@ package org.springframework.batch.sample.support;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.fail;
 
+import java.util.Arrays;
+import java.util.Collections;
+
 import org.junit.Test;
 
 /**
@@ -20,20 +23,18 @@ public class RetrySampleItemWriterTests {
 	@Test
 	public void testProcess() throws Exception {
 		Object item = null;
-		processor.write(item);
+		processor.write(Collections.singletonList(item));
 
-		for (int i = 0; i < 2; i++) {
-			try {
-				processor.write(item);
-				fail();
-			}
-			catch (RuntimeException e) {
-				// expected
-			}
+		try {
+			processor.write(Arrays.asList(new Object[] { item, item, item }));
+			fail();
 		}
-		
-		processor.write(item);
-		
+		catch (RuntimeException e) {
+			// expected
+		}
+
+		processor.write(Collections.singletonList(item));
+
 		assertEquals(4, processor.getCounter());
 	}
 }