Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

generified the integration module and cleaned up the warnings

Browse Source
This commit is contained in:
robokaso
2008-07-24 13:14:22 +00:00
parent dc0365a965
commit afa9732b95
16 changed files with 113 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/support/DelegatingItemWriterTests.java
View File

@@ -69,7 +69,7 @@ public class DelegatingItemWriterTests extends TestCase {
public void testWrite() throws Exception{
ProcessingWriter writer = new ProcessingWriter();
ProcessingWriter<Object, Object> writer = new ProcessingWriter<Object, Object>();
writer.setDelegate(itemWriter);
Object item = new Object();
itemWriter.write(item);

60
spring-batch-integration/.settings/org.eclipse.jdt.core.prefs
View File

@@ -1,4 +1,4 @@
#Mon Jun 02 08:35:20 BST 2008
#Thu Jul 24 14:51:08 CEST 2008
eclipse.preferences.version=1
org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5
@@ -7,6 +7,64 @@ org.eclipse.jdt.core.compiler.compliance=1.5
org.eclipse.jdt.core.compiler.debug.lineNumber=generate
org.eclipse.jdt.core.compiler.debug.localVariable=generate
org.eclipse.jdt.core.compiler.debug.sourceFile=generate
org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
org.eclipse.jdt.core.compiler.problem.deprecation=warning
org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled
org.eclipse.jdt.core.compiler.problem.discouragedReference=warning
org.eclipse.jdt.core.compiler.problem.emptyStatement=ignore
org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
org.eclipse.jdt.core.compiler.problem.fallthroughCase=ignore
org.eclipse.jdt.core.compiler.problem.fatalOptionalError=enabled
org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore
org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning
org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=warning
org.eclipse.jdt.core.compiler.problem.forbiddenReference=error
org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=warning
org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=ignore
org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore
org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=ignore
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore
org.eclipse.jdt.core.compiler.problem.missingSerialVersion=ignore
org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning
org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning
org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore
org.eclipse.jdt.core.compiler.problem.nullReference=warning
org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning
org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore
org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=ignore
org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore
org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning
org.eclipse.jdt.core.compiler.problem.redundantNullCheck=ignore
org.eclipse.jdt.core.compiler.problem.redundantSuperinterface=ignore
org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning
org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore
org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=ignore
org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=ignore
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverriding=disabled
org.eclipse.jdt.core.compiler.problem.unusedImport=warning
org.eclipse.jdt.core.compiler.problem.unusedLabel=warning
org.eclipse.jdt.core.compiler.problem.unusedLocal=warning
org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore
org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=enabled
org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled
org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled
org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning
org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning
org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning
org.eclipse.jdt.core.compiler.source=1.5

4
spring-batch-integration/src/main/java/org/springframework/batch/integration/chunk/ChunkHandler.java
View File

@@ -1,8 +1,8 @@
package org.springframework.batch.integration.chunk;
public interface ChunkHandler {
public interface ChunkHandler<T> {
ChunkResponse handleChunk(ChunkRequest chunk);
ChunkResponse handleChunk(ChunkRequest<? extends T> chunk);
}

16
spring-batch-integration/src/main/java/org/springframework/batch/integration/chunk/ChunkMessageChannelItemWriter.java
View File

@@ -22,7 +22,7 @@ import org.springframework.integration.message.Message;
import org.springframework.transaction.support.TransactionSynchronizationManager;
import org.springframework.util.Assert;
public class ChunkMessageChannelItemWriter extends StepExecutionListenerSupport implements ItemWriter, ItemStream {
public class ChunkMessageChannelItemWriter<T> extends StepExecutionListenerSupport implements ItemWriter<T>, ItemStream {
private static final Log logger = LogFactory.getLog(ChunkMessageChannelItemWriter.class);
@@ -63,7 +63,7 @@ public class ChunkMessageChannelItemWriter extends StepExecutionListenerSupport
this.requestChannel = requestChannel;
}
public void write(Object item) throws Exception {
public void write(T item) throws Exception {
bindTransactionResources();
getProcessed().add(item);
logger.debug("Added item to chunk: " + item);
@@ -88,13 +88,13 @@ public class ChunkMessageChannelItemWriter extends StepExecutionListenerSupport
getNextResult(100);
}
List<Object> processed = getProcessed();
List<T> processed = getProcessed();
if (!processed.isEmpty()) {
logger.debug("Dispatching chunk: " + processed);
ChunkRequest request = new ChunkRequest(processed, localState.getJobId(), localState.getSkipCount());
GenericMessage<ChunkRequest> message = new GenericMessage<ChunkRequest>(request);
ChunkRequest<T> request = new ChunkRequest<T>(processed, localState.getJobId(), localState.getSkipCount());
GenericMessage<ChunkRequest<T>> message = new GenericMessage<ChunkRequest<T>>(request);
requestChannel.send(message);
localState.expected++;
@@ -197,11 +197,11 @@ public class ChunkMessageChannelItemWriter extends StepExecutionListenerSupport
*
* @return the processed
*/
@SuppressWarnings("unchecked")
private List<Object> getProcessed() {
private List<T> getProcessed() {
Assert.state(TransactionSynchronizationManager.hasResource(ITEMS_PROCESSED),
"Processed items not bound to transaction.");
List<Object> processed = (List<Object>) TransactionSynchronizationManager.getResource(ITEMS_PROCESSED);
@SuppressWarnings("unchecked")
List<T> processed = (List<T>) TransactionSynchronizationManager.getResource(ITEMS_PROCESSED);
return processed;
}

8
spring-batch-integration/src/main/java/org/springframework/batch/integration/chunk/ChunkRequest.java
View File

@@ -3,13 +3,13 @@ package org.springframework.batch.integration.chunk;
import java.io.Serializable;
import java.util.Collection;
public class ChunkRequest implements Serializable {
public class ChunkRequest<T> implements Serializable {
private final int skipCount;
private final Long jobId;
private final Collection<Object> items;
private final Collection<? extends T> items;
public ChunkRequest(Collection<Object> items, Long jobId, int skipCount) {
public ChunkRequest(Collection<? extends T> items, Long jobId, int skipCount) {
this.items = items;
this.jobId = jobId;
this.skipCount = skipCount;
@@ -23,7 +23,7 @@ public class ChunkRequest implements Serializable {
return jobId;
}
public Collection<Object> getItems() {
public Collection<? extends T> getItems() {
return items;
}

10
spring-batch-integration/src/main/java/org/springframework/batch/integration/chunk/ItemWriterChunkHandler.java
View File

@@ -11,11 +11,11 @@ import org.springframework.batch.repeat.ExitStatus;
import org.springframework.integration.annotation.Handler;
import org.springframework.transaction.annotation.Transactional;
public class ItemWriterChunkHandler implements ChunkHandler {
public class ItemWriterChunkHandler<T> implements ChunkHandler<T> {
private static final Log logger = LogFactory.getLog(ItemWriterChunkHandler.class);
private ItemWriter itemWriter;
private ItemWriter<? super T> itemWriter;
private ItemSkipPolicy itemSkipPolicy = new NeverSkipItemSkipPolicy();
@@ -25,7 +25,7 @@ public class ItemWriterChunkHandler implements ChunkHandler {
this.itemSkipPolicy = itemSkipPolicy;
}
public void setItemWriter(ItemWriter itemWriter) {
public void setItemWriter(ItemWriter<? super T> itemWriter) {
this.itemWriter = itemWriter;
}
@@ -45,7 +45,7 @@ public class ItemWriterChunkHandler implements ChunkHandler {
*/
@Handler
@Transactional
public ChunkResponse handleChunk(ChunkRequest chunk) {
public ChunkResponse handleChunk(ChunkRequest<? extends T> chunk) {
logger.debug("Handling chunk: " + chunk);
@@ -53,7 +53,7 @@ public class ItemWriterChunkHandler implements ChunkHandler {
int skipCount = 0;
try {
for (Object item : chunk.getItems()) {
for (T item : chunk.getItems()) {
try {
itemWriter.write(item);
}

16
spring-batch-integration/src/main/java/org/springframework/batch/integration/file/FileToMessagesJobFactoryBean.java
View File

@@ -51,11 +51,11 @@ import org.springframework.util.Assert;
* @author Dave Syer
*
*/
public class FileToMessagesJobFactoryBean implements FactoryBean, BeanNameAware {
public class FileToMessagesJobFactoryBean<T> implements FactoryBean, BeanNameAware {
private String name = "fileToMessageJob";
private ItemReader itemReader;
private ItemReader<? extends T> itemReader;
private MessageChannel channel;
@@ -80,7 +80,7 @@ public class FileToMessagesJobFactoryBean implements FactoryBean, BeanNameAware
* @param itemReader the itemReader to set
*/
@Required
public void setItemReader(ItemReader itemReader) {
public void setItemReader(ItemReader<? extends T> itemReader) {
this.itemReader = itemReader;
}
@@ -125,7 +125,7 @@ public class FileToMessagesJobFactoryBean implements FactoryBean, BeanNameAware
job.setName(name);
job.setJobRepository(jobRepository);
SimpleStepFactoryBean stepFactory = new SimpleStepFactoryBean();
SimpleStepFactoryBean<T> stepFactory = new SimpleStepFactoryBean<T>();
stepFactory.setBeanName("step");
Assert.state((itemReader instanceof FlatFileItemReader) || (itemReader instanceof StaxEventItemReader),
@@ -139,7 +139,7 @@ public class FileToMessagesJobFactoryBean implements FactoryBean, BeanNameAware
Assert.notNull(channel, "A channel must be provided");
Assert.state(channel instanceof DirectChannel,
"The channel must be a DirectChannel (otherwise failures can not be recovered from)");
MessageChannelItemWriter itemWriter = new MessageChannelItemWriter();
MessageChannelItemWriter<? super T> itemWriter = new MessageChannelItemWriter<T>();
itemWriter.setChannel(channel);
stepFactory.setItemWriter(itemWriter);
@@ -157,12 +157,12 @@ public class FileToMessagesJobFactoryBean implements FactoryBean, BeanNameAware
* @param itemReader
* @param resource
*/
private void setResource(ItemReader itemReader, Resource resource) {
private void setResource(ItemReader<? extends T> itemReader, Resource resource) {
if (itemReader instanceof FlatFileItemReader) {
((FlatFileItemReader) itemReader).setResource(resource);
((FlatFileItemReader<? extends T>) itemReader).setResource(resource);
}
else {
((StaxEventItemReader) itemReader).setResource(resource);
((StaxEventItemReader<? extends T>) itemReader).setResource(resource);
}
}

6
spring-batch-integration/src/main/java/org/springframework/batch/integration/item/MessageChannelItemWriter.java
View File

@@ -24,7 +24,7 @@ import org.springframework.integration.message.GenericMessage;
* @author Dave Syer
*
*/
public class MessageChannelItemWriter extends AbstractItemWriter {
public class MessageChannelItemWriter<T> extends AbstractItemWriter<T> {
private MessageChannel channel;
@@ -41,8 +41,8 @@ public class MessageChannelItemWriter extends AbstractItemWriter {
* (non-Javadoc)
* @see org.springframework.batch.item.ItemWriter#write(java.lang.Object)
*/
public void write(Object item) throws Exception {
channel.send(new GenericMessage<Object>(item));
public void write(T item) throws Exception {
channel.send(new GenericMessage<T>(item));
}
}

18
spring-batch-integration/src/test/java/org/springframework/batch/integration/chunk/ChunkMessageItemWriterIntegrationTests.java
View File

@@ -42,7 +42,7 @@ import org.springframework.util.StringUtils;
@RunWith(SpringJUnit4ClassRunner.class)
public class ChunkMessageItemWriterIntegrationTests {
private ChunkMessageChannelItemWriter writer = new ChunkMessageChannelItemWriter();
private ChunkMessageChannelItemWriter<Object> writer = new ChunkMessageChannelItemWriter<Object>();
@Autowired
@Qualifier("requests")
@@ -52,7 +52,7 @@ public class ChunkMessageItemWriterIntegrationTests {
@Qualifier("replies")
private MessageChannel replies;
private SimpleStepFactoryBean factory;
private SimpleStepFactoryBean<Object> factory;
private SimpleJobRepository jobRepository;
@@ -61,7 +61,7 @@ public class ChunkMessageItemWriterIntegrationTests {
@Before
public void setUp() {
factory = new SimpleStepFactoryBean();
factory = new SimpleStepFactoryBean<Object>();
jobRepository = new SimpleJobRepository(new MapJobInstanceDao(),
new MapJobExecutionDao(), new MapStepExecutionDao());
factory.setJobRepository(jobRepository);
@@ -114,7 +114,7 @@ public class ChunkMessageItemWriterIntegrationTests {
@Test
public void testVanillaIteration() throws Exception {
factory.setItemReader(new ListItemReader(Arrays.asList(StringUtils
factory.setItemReader(new ListItemReader<String>(Arrays.asList(StringUtils
.commaDelimitedListToStringArray("1,2,3,4,5,6"))));
Step step = (Step) factory.getObject();
@@ -132,7 +132,7 @@ public class ChunkMessageItemWriterIntegrationTests {
@Test
public void testSimulatedRestart() throws Exception {
factory.setItemReader(new ListItemReader(Arrays.asList(StringUtils
factory.setItemReader(new ListItemReader<String>(Arrays.asList(StringUtils
.commaDelimitedListToStringArray("1,2,3,4,5,6"))));
Step step = (Step) factory.getObject();
@@ -159,7 +159,7 @@ public class ChunkMessageItemWriterIntegrationTests {
@Test
public void testSimulatedRestartWithBadMessagesFromAnotherJob() throws Exception {
factory.setItemReader(new ListItemReader(Arrays.asList(StringUtils
factory.setItemReader(new ListItemReader<String>(Arrays.asList(StringUtils
.commaDelimitedListToStringArray("1,2,3,4,5,6"))));
Step step = (Step) factory.getObject();
@@ -204,7 +204,7 @@ public class ChunkMessageItemWriterIntegrationTests {
@Test
public void testEarlyCompletionSignalledInHandler() throws Exception {
factory.setItemReader(new ListItemReader(Arrays.asList(StringUtils
factory.setItemReader(new ListItemReader<String>(Arrays.asList(StringUtils
.commaDelimitedListToStringArray("1,bad,3,4,5,6"))));
factory.setCommitInterval(2);
@@ -232,7 +232,7 @@ public class ChunkMessageItemWriterIntegrationTests {
@Test
public void testSimulatedRestartWithNoBacklog() throws Exception {
factory.setItemReader(new ListItemReader(Arrays.asList(StringUtils
factory.setItemReader(new ListItemReader<String>(Arrays.asList(StringUtils
.commaDelimitedListToStringArray("1,2,3,4,5,6"))));
Step step = (Step) factory.getObject();
@@ -272,7 +272,7 @@ public class ChunkMessageItemWriterIntegrationTests {
@Test
public void testFailureInStepListener() throws Exception {
factory.setItemReader(new ListItemReader(Arrays.asList(StringUtils
factory.setItemReader(new ListItemReader<String>(Arrays.asList(StringUtils
.commaDelimitedListToStringArray("wait,bad,3,4,5,6"))));
Step step = (Step) factory.getObject();

2
spring-batch-integration/src/test/java/org/springframework/batch/integration/chunk/ItemWriterChunkHandlerTests.java
View File

@@ -15,7 +15,7 @@ import org.springframework.util.StringUtils;
public class ItemWriterChunkHandlerTests {
private ItemWriterChunkHandler handler = new ItemWriterChunkHandler();
private ItemWriterChunkHandler<Object> handler = new ItemWriterChunkHandler<Object>();
protected int count = 0;

4
spring-batch-integration/src/test/java/org/springframework/batch/integration/chunk/TestItemWriter.java
View File

@@ -6,7 +6,7 @@ import org.springframework.batch.item.support.AbstractItemWriter;
import org.springframework.stereotype.Component;
@Component
public class TestItemWriter extends AbstractItemWriter {
public class TestItemWriter<T> extends AbstractItemWriter<T> {
private static final Log logger = LogFactory.getLog(TestItemWriter.class);
@@ -25,7 +25,7 @@ public class TestItemWriter extends AbstractItemWriter {
*/
public static final String WAIT_ON = "wait";
public void write(Object item) throws Exception {
public void write(T item) throws Exception {
count++;

8
spring-batch-integration/src/test/java/org/springframework/batch/integration/file/FileToMessagesJobFactoryBeanTests.java
View File

@@ -54,7 +54,7 @@ import org.springframework.util.ReflectionUtils;
public class FileToMessagesJobFactoryBeanTests {
private static final String FILE_INPUT_PATH = ResourcePayloadAsJobParameterStrategy.FILE_INPUT_PATH;
private FileToMessagesJobFactoryBean factory = new FileToMessagesJobFactoryBean();
private FileToMessagesJobFactoryBean<FieldSet> factory = new FileToMessagesJobFactoryBean<FieldSet>();
private ThreadLocalChannel receiver = new ThreadLocalChannel();
private JobRepositorySupport jobRepository;
@@ -63,7 +63,7 @@ public class FileToMessagesJobFactoryBeanTests {
jobRepository = new JobRepositorySupport();
factory.setJobRepository(jobRepository);
factory.setTransactionManager(new ResourcelessTransactionManager());
FlatFileItemReader itemReader = new FlatFileItemReader();
FlatFileItemReader<FieldSet> itemReader = new FlatFileItemReader<FieldSet>();
itemReader.setFieldSetMapper(new PassThroughFieldSetMapper());
factory.setItemReader(itemReader);
DirectChannel channel = new DirectChannel();
@@ -158,7 +158,7 @@ public class FileToMessagesJobFactoryBeanTests {
*/
@Test
public void testGetObjectType() {
FileToMessagesJobFactoryBean factory = new FileToMessagesJobFactoryBean();
FileToMessagesJobFactoryBean<?> factory = new FileToMessagesJobFactoryBean<Object>();
assertEquals(Job.class, factory.getObjectType());
}
@@ -168,7 +168,7 @@ public class FileToMessagesJobFactoryBeanTests {
*/
@Test
public void testIsSingleton() {
FileToMessagesJobFactoryBean factory = new FileToMessagesJobFactoryBean();
FileToMessagesJobFactoryBean<?> factory = new FileToMessagesJobFactoryBean<Object>();
assertEquals(true, factory.isSingleton());
}

2
spring-batch-integration/src/test/java/org/springframework/batch/integration/item/MessageChannelItemWriterIntegrationTests.java
View File

@@ -39,7 +39,7 @@ public class MessageChannelItemWriterIntegrationTests {
private MessageChannel channel;
@Autowired
private ItemWriter itemWriter;
private ItemWriter<String> itemWriter;
@Test
public void testSend() throws Exception {

6
spring-batch-integration/src/test/java/org/springframework/batch/integration/item/MessageChannelItemWriterTests.java
View File

@@ -61,7 +61,7 @@ public class MessageChannelItemWriterTests {
DirectChannel channel = new DirectChannel();
ThreadLocalChannel receiver = new ThreadLocalChannel();
channel.subscribe(receiver);
MessageChannelItemWriter writer = new MessageChannelItemWriter();
MessageChannelItemWriter<String> writer = new MessageChannelItemWriter<String>();
writer.setChannel(channel);
writer.write("foo");
Message<?> message = receiver.receive(10);
@@ -81,7 +81,7 @@ public class MessageChannelItemWriterTests {
throw new RuntimeException("Planned failure");
}
});
MessageChannelItemWriter writer = new MessageChannelItemWriter();
MessageChannelItemWriter<String> writer = new MessageChannelItemWriter<String>();
writer.setChannel(channel);
try {
writer.write("foo");
@@ -105,7 +105,7 @@ public class MessageChannelItemWriterTests {
}
});
channel.subscribe(endpoint);
MessageChannelItemWriter writer = new MessageChannelItemWriter();
MessageChannelItemWriter<String> writer = new MessageChannelItemWriter<String>();
writer.setChannel(channel);
try {
writer.write("foo");

7
spring-batch-integration/src/test/java/org/springframework/batch/integration/job/StepExecutionMessageHandlerTests.java
View File

@@ -76,7 +76,6 @@ public class StepExecutionMessageHandlerTests {
assertEquals(Required.class, annotations[0].annotationType());
}
@SuppressWarnings("unchecked")
@Test
public void testVanillaHandle() throws Exception {
JobRepositorySupport jobRepository = new JobRepositorySupport();
@@ -87,7 +86,6 @@ public class StepExecutionMessageHandlerTests {
assertEquals(BatchStatus.COMPLETED, message.getStatus());
}
@SuppressWarnings("unchecked")
@Test
public void testHandleWithInputs() throws Exception {
JobRepositorySupport jobRepository = new JobRepositorySupport();
@@ -101,7 +99,6 @@ public class StepExecutionMessageHandlerTests {
assertTrue(jobExecution.getExecutionContext().containsKey("foo"));
}
@SuppressWarnings("unchecked")
@Test
public void testHandleWithInputsAndOutputs() throws Exception {
JobRepositorySupport jobRepository = new JobRepositorySupport();
@@ -122,7 +119,6 @@ public class StepExecutionMessageHandlerTests {
assertTrue(jobExecution.getExecutionContext().containsKey("bar"));
}
@SuppressWarnings("unchecked")
@Test
public void testHandleFailedJob() throws Exception {
JobRepositorySupport jobRepository = new JobRepositorySupport();
@@ -133,7 +129,6 @@ public class StepExecutionMessageHandlerTests {
assertEquals(0, message.getJobExecution().getStepExecutions().size());
}
@SuppressWarnings("unchecked")
@Test
public void testHandleRestart() throws Exception {
JobRepositorySupport jobRepository = new JobRepositorySupport() {
@@ -171,7 +166,6 @@ public class StepExecutionMessageHandlerTests {
assertTrue(stepExecution.getExecutionContext().containsKey("foo"));
}
@SuppressWarnings("unchecked")
@Test
public void testHandleRestartAlreadyComplete() throws Exception {
JobRepositorySupport jobRepository = new JobRepositorySupport() {
@@ -199,7 +193,6 @@ public class StepExecutionMessageHandlerTests {
assertTrue(stepExecution.getExecutionContext().containsKey("foo"));
}
@SuppressWarnings("unchecked")
@Test
public void testHandleRestartStartLimitExceeded() throws Exception {
JobRepositorySupport jobRepository = new JobRepositorySupport() {

13
spring-batch-integration/src/test/java/org/springframework/batch/integration/retry/PollableSourceRetryTests.java
View File

@@ -71,7 +71,6 @@ public class PollableSourceRetryTests {
private PlatformTransactionManager transactionManager = new ResourcelessTransactionManager();;
@SuppressWarnings("unchecked")
@Test
public void testSimpleTransactionalPolling() throws Exception {
@@ -104,7 +103,6 @@ public class PollableSourceRetryTests {
}
@SuppressWarnings("unchecked")
@Test
public void testNonTransactionalPollingWithRollback() throws Exception {
@@ -139,7 +137,6 @@ public class PollableSourceRetryTests {
}
@SuppressWarnings("unchecked")
@Test
public void testTransactionalHandlingWithUnconditionalRollback() throws Exception {
@@ -177,7 +174,6 @@ public class PollableSourceRetryTests {
}
@SuppressWarnings("unchecked")
@Test
public void testTransactionalHandlingWithRollback() throws Exception {
@@ -222,7 +218,6 @@ public class PollableSourceRetryTests {
}
@SuppressWarnings("unchecked")
@Test
public void testTransactionalHandlingWithRepeat() throws Exception {
@@ -269,7 +264,6 @@ public class PollableSourceRetryTests {
}
@SuppressWarnings("unchecked")
@Test
public void testTransactionalHandlingWithRetry() throws Exception {
@@ -322,7 +316,6 @@ public class PollableSourceRetryTests {
}
@SuppressWarnings("unchecked")
@Test
public void testTransactionalHandlingWithRepeatAndRetry() throws Exception {
@@ -408,9 +401,9 @@ public class PollableSourceRetryTests {
}
private MessageSource<Object> getPollableSource(List<String> list) {
final ItemReader reader = new ListItemReader(list) {
public Object read() {
Object item = super.read();
final ItemReader<String> reader = new ListItemReader<String>(list) {
public String read() {
String item = super.read();
logger.debug("Reading: " + item);
return item;
}