Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BATCH-848: improved the paging support

Browse Source
This commit is contained in:
trisberg
2008-10-21 04:28:15 +00:00
parent f840809ef2
commit c3df035607
4 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/IbatisPagingItemReader.java
View File

@@ -94,7 +94,10 @@ public class IbatisPagingItemReader<T> extends AbstractPagingItemReader<T> {
if (parameterValues != null) {
parameters.putAll(parameterValues);
}
results = sqlMapClientTemplate.queryForList(queryId, parameters, (page * pageSize), pageSize);
parameters.put("_page", page);
parameters.put("_pagesize", pageSize);
parameters.put("_skiprows", page * pageSize);
results = sqlMapClientTemplate.queryForList(queryId, parameters);
}
@Override

2
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/IbatisPagingItemReaderCommonTests.java
View File

@@ -21,7 +21,7 @@ public class IbatisPagingItemReaderCommonTests extends CommonDatabaseItemStreamI
SqlMapClient sqlMapClient = createSqlMapClient();
IbatisPagingItemReader reader = new IbatisPagingItemReader();
reader.setQueryId("getAllFoos");
reader.setQueryId("getPagedFoos");
reader.setSqlMapClient(sqlMapClient);
reader.setSaveState(true);

2
spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/IbatisPagingItemReaderParameterTests.java
View File

@@ -24,7 +24,7 @@ public class IbatisPagingItemReaderParameterTests extends AbstractPagingItemRead
SqlMapClient sqlMapClient = createSqlMapClient();
IbatisPagingItemReader reader = new IbatisPagingItemReader();
reader.setQueryId("getFoos3AndUp");
reader.setQueryId("getPagedFoos3AndUp");
reader.setParameterValues(Collections.<String, Object>singletonMap("limit", 3));
reader.setSqlMapClient(sqlMapClient);
reader.setSaveState(true);

8
spring-batch-infrastructure/src/test/resources/org/springframework/batch/item/database/ibatis-foo.xml
View File

@@ -22,6 +22,14 @@
select ID, NAME, VALUE from T_FOOS
</select>
<select id="getPagedFoos" resultMap="fooResult">
select LIMIT #_skiprows# #_pagesize# ID, NAME, VALUE from T_FOOS order by ID
</select>
<select id="getPagedFoos3AndUp" resultMap="fooResult">
select LIMIT #_skiprows# #_pagesize# ID, NAME, VALUE from T_FOOS where VALUE >= #limit# order by ID
</select>
<select id="getFoos3AndUp" resultMap="fooResult">
select ID, NAME, VALUE from T_FOOS where VALUE >= #limit#
</select>