Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use batch inserts for job parameters

Browse Source 
Use batch inserts for job parameters to reduce
the number of database round trips.

Issue #3867
This commit is contained in:
Philippe Marschall
2021-03-13 18:48:19 +01:00
committed by Mahmoud Ben Hassine
parent 89e76164af
commit c707284f80
1 changed files with 20 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
spring-batch-core/src/main/java/org/springframework/batch/core/repository/dao/JdbcJobExecutionDao.java
View File

@@ -16,6 +16,7 @@
package org.springframework.batch.core.repository.dao;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Timestamp;
@@ -23,8 +24,8 @@ import java.sql.Types;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Date;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Set;
import org.apache.commons.logging.Log;
@@ -70,6 +71,7 @@ import org.springframework.util.Assert;
* @author Michael Minella
* @author Mahmoud Ben Hassine
* @author Dimitrios Liapis
* @author Philippe Marschall
*/
public class JdbcJobExecutionDao extends AbstractJdbcBatchMetadataDao implements JobExecutionDao, InitializingBean {
@@ -376,27 +378,34 @@ public class JdbcJobExecutionDao extends AbstractJdbcBatchMetadataDao implements
*/
private void insertJobParameters(Long executionId, JobParameters jobParameters) {
for (Entry<String, JobParameter<?>> entry : jobParameters.getParameters().entrySet()) {
JobParameter jobParameter = entry.getValue();
insertParameter(executionId, jobParameter.getType(), entry.getKey(), jobParameter.getValue(),
jobParameter.isIdentifying());
if (jobParameters.isEmpty()) {
return;
}
getJdbcTemplate().batchUpdate(getQuery(CREATE_JOB_PARAMETERS), jobParameters.getParameters().entrySet(), 100,
(ps, entry) -> {
JobParameter jobParameter = entry.getValue();
insertParameter(ps, executionId, jobParameter.getType(), entry.getKey(), jobParameter.getValue(),
jobParameter.isIdentifying());
});
}
/**
* Convenience method that inserts an individual records into the JobParameters table.
* @throws SQLException if the driver throws an exception
*/
private <T> void insertParameter(Long executionId, Class<T> type, String key, T value, boolean identifying) {
Object[] args = new Object[0];
int[] argTypes = new int[] { Types.BIGINT, Types.VARCHAR, Types.VARCHAR, Types.VARCHAR, Types.CHAR };
private <T> void insertParameter(PreparedStatement preparedStatement, Long executionId, Class<T> type, String key,
T value, boolean identifying) throws SQLException {
String identifyingFlag = identifying ? "Y" : "N";
String stringValue = this.conversionService.convert(value, String.class);
args = new Object[] { executionId, key, type.getName(), stringValue, identifyingFlag };
getJdbcTemplate().update(getQuery(CREATE_JOB_PARAMETERS), args, argTypes);
preparedStatement.setLong(1, executionId);
preparedStatement.setString(2, key);
preparedStatement.setString(3, type.getName());
preparedStatement.setString(4, stringValue);
preparedStatement.setString(5, identifyingFlag);
}
/**