Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OPEN - issue BATCH-1409: More efficient use of pool threads in repeat template (hence multi-threaded steps)

Browse Source 
http://jira.springframework.org/browse/BATCH-1409
This commit is contained in:
dsyer
2009-09-18 16:30:45 +00:00
parent cd12d1050e
commit d38ecfd955
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/support/TaskExecutorRepeatTemplateAsynchronousTests.java
View File

@@ -210,7 +210,6 @@ public class TaskExecutorRepeatTemplateAsynchronousTests extends AbstractTradeBa
int frequency = Collections.frequency(items, "null");
// System.err.println("Frequency: "+frequency);
assertTrue(frequency <= throttleLimit);
assertTrue(frequency > 1);
}
/**

10
spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/support/TaskExecutorRepeatTemplateSimpleAsynchronousTests.java → spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/support/TaskExecutorRepeatTemplateBulkAsynchronousTests.java
View File

@@ -43,9 +43,9 @@ import org.springframework.core.task.SimpleAsyncTaskExecutor;
* @author Dave Syer
*
*/
public class TaskExecutorRepeatTemplateSimpleAsynchronousTests {
public class TaskExecutorRepeatTemplateBulkAsynchronousTests {
static Log logger = LogFactory.getLog(TaskExecutorRepeatTemplateSimpleAsynchronousTests.class);
static Log logger = LogFactory.getLog(TaskExecutorRepeatTemplateBulkAsynchronousTests.class);
private static int TOTAL = 100;
@@ -89,7 +89,9 @@ public class TaskExecutorRepeatTemplateSimpleAsynchronousTests {
* retry the work.)
*/
RepeatStatus result = RepeatStatus.continueIf(position != early && item != null);
logger.debug("Returning " + result + " for count=" + position);
if (!result.isContinuable()) {
logger.debug("Returning " + result + " for count=" + position);
}
return result;
}
};
@@ -137,7 +139,7 @@ public class TaskExecutorRepeatTemplateSimpleAsynchronousTests {
int frequency = Collections.frequency(items, "null");
// System.err.println("Frequency: " + frequency);
// System.err.println("Items: " + items);
// One extra task will be submitted before the termination is detected
// Extra tasks will be submitted before the termination is detected
assertEquals(TOTAL, items.size() - frequency);
assertTrue(frequency <= throttleLimit + 1);