Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BATCH-2715: Change the method name "getStartable" to "isStartable".

Browse Source 
The method is named as "getStartable". "getStartable" is prone to obtain something. "isStartable" is a query asking whether the stepExecution is startable, which describes what the method is doning. So, "isStartable" should be more intuitive.
This commit is contained in:
Kui Liu
2018-08-15 21:55:26 +02:00
committed by Mahmoud Ben Hassine
parent 8af965cac5
commit e29f77e01e
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-batch-core/src/main/java/org/springframework/batch/core/jsr/partition/JsrStepExecutionSplitter.java
View File

@@ -84,7 +84,7 @@ public class JsrStepExecutionSplitter extends SimpleStepExecutionSplitter {
JobExecution curJobExecution = new JobExecution(jobExecution);
StepExecution curStepExecution = new StepExecution(stepName, curJobExecution);
if(!restoreState || getStartable(curStepExecution, new ExecutionContext())) {
if(!restoreState || isStartable(curStepExecution, new ExecutionContext())) {
executions.add(curStepExecution);
}
}

7
spring-batch-core/src/main/java/org/springframework/batch/core/partition/support/SimpleStepExecutionSplitter.java
View File

@@ -184,7 +184,7 @@ public class SimpleStepExecutionSplitter implements StepExecutionSplitter, Initi
StepExecution currentStepExecution = jobExecution.createStepExecution(stepName);
boolean startable = getStartable(currentStepExecution, context.getValue());
boolean startable = isStartable(currentStepExecution, context.getValue());
if (startable) {
set.add(currentStepExecution);
@@ -238,6 +238,11 @@ public class SimpleStepExecutionSplitter implements StepExecutionSplitter, Initi
return result;
}
protected boolean isStartable(StepExecution stepExecution, ExecutionContext context) throws JobExecutionException {
return getStartable(stepExecution, context);
}
@Deprecated
protected boolean getStartable(StepExecution stepExecution, ExecutionContext context) throws JobExecutionException {
JobInstance jobInstance = stepExecution.getJobExecution().getJobInstance();