Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - BATCH-434 and BATCH-438 ExitStatus cleaned up (postponed commit from friday)

Browse Source
This commit is contained in:
robokaso
2008-03-08 20:40:19 +00:00
parent 43d17d9ef5
commit ed6f991a76
3 changed files with 2 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-batch-core/src/test/java/org/springframework/batch/execution/job/SimpleJobTests.java
View File

@@ -234,7 +234,7 @@ public class SimpleJobTests extends TestCase {
assertEquals(exception, e.getCause());
}
assertEquals(0, list.size());
checkRepository(BatchStatus.STOPPED, ExitStatus.INTERRUPTED);
checkRepository(BatchStatus.STOPPED, ExitStatus.FAILED);
}
public void testFailed() throws Exception {
@@ -355,7 +355,7 @@ public class SimpleJobTests extends TestCase {
throw (RuntimeException) exception;
}
if (exception instanceof JobInterruptedException) {
stepExecution.setExitStatus(ExitStatus.INTERRUPTED);
stepExecution.setExitStatus(ExitStatus.FAILED);
throw (JobInterruptedException) exception;
}
if (runnable != null) {

11
spring-batch-infrastructure/src/main/java/org/springframework/batch/repeat/ExitStatus.java
View File

@@ -28,12 +28,6 @@ import org.springframework.util.StringUtils;
*/
public class ExitStatus implements Serializable {
/**
* Convenient constant value for when we detect that processing is underway.
* Used mainly by asynchronous launchers.
*/
public static final ExitStatus RUNNING = new ExitStatus(true, "RUNNING");
/**
* Convenient constant value representing unknown state - assumed
* continuable.
@@ -50,11 +44,6 @@ public class ExitStatus implements Serializable {
*/
public static final ExitStatus FINISHED = new ExitStatus(false, "COMPLETED");
/**
* Convenient constant value representing interrupted processing.
*/
public static final ExitStatus INTERRUPTED = new ExitStatus(false, "INTERRUPTED");
/**
* Convenient constant value representing job that did no processing (e.g.
* because it was already complete).

5
spring-batch-infrastructure/src/test/java/org/springframework/batch/repeat/ExitStatusTests.java
View File

@@ -189,11 +189,6 @@ public class ExitStatusTests extends TestCase {
assertEquals("Bar", status.getExitDescription());
}
public void testRunningIsRunning() throws Exception {
assertTrue(ExitStatus.RUNNING.isRunning());
assertTrue(new ExitStatus(true, "RUNNING").isRunning());
}
public void testUnkownIsRunning() throws Exception {
assertTrue(ExitStatus.UNKNOWN.isRunning());
}