Before this commit, the file name and content of the PDF version of
the reference documentation were incorrect. The file was empty and
named "toggle.pdf" instead of "spring-batch-reference.pdf".
This commit fixes the PDF file name and content.
Resolves BATCH-2673
Before this commit, the AutomaticJobRegistrar was started on
ContextRefreshedEvent event. This is sometimes too late to register jobs
especially when other life cycle components that use the jobs are started
before this registrar.
This commit changes the AutomaticJobRegistrar to implement SmartLifeCycle
and makes its autoStartup and phase properties configurable.
It should be noted that the "onApplicationEvent" method has been removed
even if it is a public API. This method is not intended to be used by
client code and even if it was, its usage is considered wrong anyway.
Resolves BATCH-2564
Before this commit, options passed on the command line were collected
in a HashSet. This does not keep options order as they are passed in
the command line.
This commit changes the "opts" variable type to LinkedHashSet.
Note there is no test for this change as "opts" is a local variable to
the main method.
Resolves BATCH-2491
Before this commit, annotation based chunk listeners were not registered
when using a non-fault tolerant step builder.
This commit moves the code of chunk listener annotations handling to the
AbstractTaskletStepBuilder so that other tasklet builders can use it.
Resolves BATCH-2445
Before this commit, the JsrPartitionHandler was polling partitions
completion continuously. This causes a high CPU usage.
This commit makes the polling thread sleep for a configurable amount
of time in order to decrease CPU usage during the polling period.
Resolves BATCH-2401
Currently, the Jackson2ExecutionContextStringSerializer fails to
deserialize json representations of:
* empty JobParameters instances due to the presence of "empty":true
in the serialized json String. In this case, Jackson is not able to find a
property named "empty" in the target type (JobParameters)
* JobParameter instances due to the presence of several constructors.
In this case, Jackson does not know which constructor to use.
This commit fixes these two issues by adding a custom Jackson module with:
* a mixin to ignore the "isEmpty" getter in JobParameters type
* a custom deserializer for JobParameter type
Resolves BATCH-2680
Currently, when multiple data sources are defined in the context, an
IllegalStateException is thrown even if one of the data sources is
annotated with @Primary (which should be the one to use).
This commit makes it possible to use the data source annotated with
@Primary when multiple data sources are defined. Note that the context
initialization will still fail (with a UnsatisfiedDependencyException
from Spring's bean factory) if multiple data sources are defined and
none of them is annotated with @Primary. If multiple data sources are
defined and none of them is annotated with @Primary but one of them is
named "dataSource", this data source will be used by the batch
configuration due to autowiring by name (this detail has been documented
in the javadoc of @EnableBatchProcessing).
Resolves BATCH-2537
When a tasklet is declared with xml using the shortcut version, the
MethodInvokingTaskletAdapter that is created automatically does not
address passing parameters expected by Tasklet#execute (which is
incorrect since the documentation of the schema attribute "method"
says the bean should define a method with the same signature).
This commit fixes parameters passing when using the shortcut version.
Resolves BATCH-2397
I made a new implementation of the XML/Java toggle (and added a third choice for having both available).
Changes to make a dynamic ToC work with content selection toggles
Various asciidoc and JavaScript changes to make the dynamic ToC (tocbot) work with the content toggle (XML or Java in this case but also more options in other projects).
Before this commit, the filter count of the contribution was applied
for each item of a scanned chunk. For example, with a chunk of 30,
if the filter count is 10 and an item is skipped during write, then the
filter count is equal to 210 (10 + 20 * 10).
If this commit is applied, the filter count will be re-initialized when
scanning the chunk.
Resolves BATCH-2663
Before this commit, when a job execution is stopped from a different
JVM than the one running the job, a warning says that the job cannot
be found. This was confusing to some users since the job can be found
in the database (but is actually not defined in the job registry of
the application context of the second JVM).
After this commit is applied, the warning will be more explicit to
inform the user that the job cannot be found in the job registry
(to not be confused with the database)
Resolves BATCH-2667
In order to convert a String value to a Date, The `DefaultConversionService`
uses the constructor `java.util.Date(java.lang.String)` behind the scene
(from `org.springframework.core.convert.support.ObjectToObjectConverter.convert`).
This constructor throws a `java.lang.IllegalArgumentException` for values in
CET timezone, for example: "Thu Jan 04 09:05:50 CET 2018".
This commit updates the failing test to use a fixed timezone (UTC).
Resolves BATCH-2668
Spring 4 requires JDK 6 which includes JAXP 1.4. In Spring 4
`org.springframework.util.xml.StaxUtils` is public and directly
delegates to `javax.xml.transform.stax.StAXSource`. This means that
`org.springframework.batch.item.xml.StaxUtils#hasSpring30StaxSupport`
will always be true. Therefore a lot of code an be simplified by
calling the constructors directly instead of through reflection.
- remove reflection no longer needed in Spring 4
- move methods only used in tests to custom test class
Issue: BATCH-2417
DelimitedLineTokenizer was refactored to improve its performance but its behavior was also slightly changed.
When the input is an empty csv string with double quotes, e.g. the java
String line = "\"\""; the tokenizer returns the same String, whereas
before it was returning an empty string.
This is due to the condition checking for quotes to remove not stripping
the double quotes from the empty csv string (because its length is 2 and
the code check for strictly greater than 2).
The previous code is there 973fe44d6c/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/transform/DelimitedLineTokenizer.java (L202) and checking for
double quotes at the start and end of the string without special
handling for the empty string.
At test is also added to ensure this won't break again.
Resolves BATCH-2657
Add support for DB2AS400 to DefaultDataFieldMaxValueIncrementerFactory.
Apparently, DB2AS400 is using the same syntax for sequence value
retrieval as standard DB2.
resolves BATCH-2525
In order to make the Map based JobRepository threadsafe, the
JobExecutino was modified to use a `CopyOnWriteArraySet` for the
collection backing the child `StepExecution` collection. However, this
collection option has bad performance characteristics when used with
large collections. When using partitioning, it can be common to have a
large number of `StepExecution` instances to add which drastically hurts
start up time.
This commit remove the use of the `CopyOnWriteArraySet` for the
`JobExecution#stepExecutions` and replaces it with a `LinkedHashSet`
wrapped via `Collection.synchronizedSet`.
Resolves BATCH-2384
