Commit Graph

5449 Commits

Author SHA1 Message Date
Mahmoud Ben Hassine
78fedb7d41 Fix typo in Javadoc of KafkaItemReader 2020-04-16 12:26:14 +02:00
Santiago Molano
fb21b30d7d Fixed FlatFileItemReaderBuilder LineTokenizer validation
Fixed validation for the FlatFileItemReaderBuilder where no
LineTokenizer had been provided.

Resolves: #3688
2020-03-31 16:14:02 -05:00
Jay Bryant
a7450d5108 Updated spring-doc-resources version
Gives us the new look and feel and more readable code listings.
2020-03-31 18:41:26 +02:00
Mahmoud Ben Hassine
6cca32fde0 Fix metrics collection in FaultTolerantChunkProcessor
Before this commit, metrics were not collected in a fault-tolerant step.
This commit updates the FaultTolerantChunkProcessor to collect metrics.

For the record, chunk scanning is not covered for two reasons:

1. When scanning a chunk, there is a single item in each write operation,
so it would be incorrect to report a metric called "chunk.write" for a
single item. We could argue that it is a singleton chunk, but still..
If we want to time scanned (aka individual) items, we need a more fine
grained timer called "scanned.item.write" for example.

2. The end result can be confusing and might distort the overall metrics
view in case of errors (because of the noisy metrics of additional transactions
for individual items).

As a reminder, the goal of the "chunk.write" metric is to give an overview
of the write operation time of the whole chunk and not to time each item
individually (this could be done using an `ItemWriteListener` if needed).

Resolves #3664
2020-03-31 16:37:12 +02:00
Mahmoud Ben Hassine
d933e4d7df Upgrade Gradle to v6.3 to support Java 14
This commit also upgrades Groovy version to v2.5.10
which is required to build correctly against Java 14

Resolves #3685
2020-03-25 11:51:01 +01:00
Sanghyuk Jung
b9fa9c3786 Fix constructor of JsonItemReader to call setExecutionContextName()
Resolves #3681
2020-03-24 18:36:56 +01:00
jinwook han
0ecc052190 fix documentation of JobExecutionNotRunningException
execution -> checked exception
2020-03-24 16:15:20 +01:00
Mahmoud Ben Hassine
4e07b33a9d Add templates for issues and pull requests 2020-03-20 21:48:58 +01:00
Mahmoud Ben Hassine
999ef54328 Add extra check on connection state in AbstractCursorItemReader#doClose
Issue #868
2020-03-18 21:38:42 +01:00
Mahmoud Ben Hassine
f94446878b Fix line tokenizer validation in FlatFileItemReaderBuilder
Resolves #766
2020-03-17 23:27:47 +01:00
Mahmoud Ben Hassine
6ab141bb44 Fix incorrect description of AggregateItemReader in "Appendix A"
This commit fixes incorrect references to `AggregateItemReader#__$$BEGIN_RECORD$$__`
and `AggregateItemReader#__$$END_RECORD$$__` by updating the description of the
reader with the one in its Javadoc.

It also adds a note that the AggregateItemReader is not part of the standard library
of readers provided by Spring Batch but only given as a sample.

Issue #1793
2020-03-13 11:22:45 +01:00
Chris Schaefer
d6f90a1d21 BATCH-2270: Allow ScriptEvaluator to be injectable in the ScriptItemProcessor 2020-03-13 09:25:00 +01:00
Mahmoud Ben Hassine
ad3dcbc96a Remove Gitter link from README.md 2020-03-10 19:13:34 +01:00
Michael Minella
d41cd45f90 Updated step.adoc to correctly configure a split 2020-03-09 15:06:42 -05:00
Michael Minella
b83c81e680 Updated email addresses from Pivotal to VMware 2020-03-04 16:26:00 -06:00
BenjaminHetzJelli
7f01bf78cf Trim Keywords Followed By Whitespace Other Than The Character ' '
Modify `removeKeyWord(...)` such that the keyword is removed regardless
of what kind of whitespace follows. This is especially useful for those
who read in SQL from a file which has been formatted such that keywords
live on their own lines.

Added unit tests for trimming whitespace.

Resolves #765
2020-03-04 10:43:24 +01:00
Yanming Zhou
6103fe7306 Update schema-appendix.adoc to fix wrong names
BATCH_EXECUTION_CONTEXT is obsoleted
2020-03-03 12:08:28 +01:00
Michael Minella
8e8f9c8101 Added comparitor for state transitions when using java config
Spring Batch orders the transitions as it goes from state to state based
on specificity.  The XML configuration has always had this
functionality.  However, when creating the JSR-352 implementation, the
mechanism for which this occured was refactored.  That occured at about
the same time as the java builders were introduced.  Because of this
crossing of paths, the java configuration option for defining jobs has
never correctly sorted the transitions.  This PR applys the sorting
algorithm to the java configuration, making XML and java configuration
behave the same.

Resolves #3638
2020-02-07 16:27:12 +01:00
Mahmoud Ben Hassine
ff5578851f Upgrade Spring Data MongoDB to version 3.0.0.BUILD-SNAPSHOT 2020-02-07 16:16:04 +01:00
Mahmoud Ben Hassine
433a890e9b Update dependencies 2020-02-07 15:18:34 +01:00
Benoit Dupont
7ba73d8dfe Fix dead link to Github in contribution guide 2020-01-20 10:45:06 +01:00
Wannes
bcc4665faa Update step.adoc
typo in a variable
2020-01-17 12:29:45 +01:00
Pascal Schumacher
2916da30dd Improve formatting of IllegalArgumentException message thrown by DefaultExecutionContextSerializer 2020-01-17 11:51:02 +01:00
Mahmoud Ben Hassine
e0f78d1504 Remove deprecated usage of com.mongodb.util.JSON in MongoItemReader 2020-01-10 12:04:42 +01:00
Mahmoud Ben Hassine
20061007c0 Add sample app to show MongoDB support 2020-01-10 12:03:14 +01:00
Mahmoud Ben Hassine
fef02a6e30 Upgrade gradle to v6.0.1 2020-01-07 10:52:33 +01:00
Mahmoud Ben Hassine
f19f32fd79 Remove unused generateSql gradle task and its corresponding resources 2020-01-07 10:51:24 +01:00
Mahmoud Ben Hassine
9b5118cb3d Update version in documentation index 2020-01-06 09:32:38 +01:00
Mahmoud Ben Hassine
32b2b5683c Update links to issue tracker from JIRA to Github issues 2019-12-18 13:13:30 +01:00
Mahmoud Ben Hassine
38b43e8aaf Fix default value of comment prefix in FlatFileItemReaderBuilder
Before this commit, the default value of comment prefix in
FlatFileItemReaderBuilder was not consistent with the one in
FlatFileItemReader.

This commit changes the default value of comment prefix to # in
the builder to be consistent with the reader.

Resolves BATCH-2862
2019-12-02 14:31:00 +01:00
Drummond Dawson
e5855c7e6b Support empty comments in FlatFileItemReaderBuilder
Previously, if supplying empty comments or no comments to comments() of the FlatFileItemReaderBuilder, the comments would be ignored and instead use the default comments "#" provided by the FlatFileItemReader.

Resolves BATCH-2837
2019-12-02 11:07:56 +01:00
Mahmoud Ben Hassine
5ee6699ce3 Update JaCoCo to 0.8.5 to fix the build on Java 13
According to https://github.com/jacoco/jacoco/releases/tag/v0.8.5,
this version officially supports Java 13.
2019-11-29 14:30:02 +01:00
Mahmoud Ben Hassine
fba1c3adab Polish 62a2e65e20
Add null check for delimiter
2019-11-29 09:24:55 +01:00
Drummond Dawson
62a2e65e20 Support empty delimiter in DelimitedBuilder of FlatFileItemWriterBuilder
Previously, if supplying an empty delimiter, to the delimited().delimiter() of DelimitedBuilder from the parent FlatFileItemWriterBuilder, it would be ignored and instead use the default delimiter ",".

Resolves BATCH-2844
2019-11-29 09:08:19 +01:00
Yanming Zhou
44c0b8d557 Fix wrong indent 2019-11-27 10:41:36 +01:00
Mahmoud Ben Hassine
85a63425b2 Fix typo 2019-11-26 16:33:05 +01:00
Drummond Dawson
53ec8f6084 Polish DocumentToggle.js
* Declare duplicate jQuery selectors as variables
* Remove extra semicolons after function declarations
* Remove leftover jquery.js from Java/XML toggle implementation

When the Java/XML toggle implementation was introduced,
jquery-3.2.1.min.js replaced the old jquery script in toggle.adoc
and the old jquery script was accidentally leftover as a result.
2019-11-26 14:15:36 +01:00
Michal Fotyga
0f9b2e800e Fix typos, code style, trim pictures in docs
And remove unused file
2019-11-26 13:57:56 +01:00
larryjung
193f82005a Update outdated comment 2019-11-26 13:50:28 +01:00
Yanming Zhou
a7bb1ef886 Polishing docs 2019-11-26 13:33:57 +01:00
Mahmoud Ben Hassine
f55d3bc81e Update docs with expected behaviour in regards to skippable exceptions
Before this commit, the expected behaviour when a skippbale exception
occurs in a fault tolerant chunk-oriented step was not documented in
details.

This commit update the docs and adds a sample for each case (when a
skippable exception occurs during read, process and write).

Resolves BATCH-2541
2019-11-25 11:24:21 +01:00
Mahmoud Ben Hassine
707b1bf986 Remove the requirement for a Resource to be set
This commit removes the requirement for a Resource to be configured at
build time. This requirement prevented the use of this builder along
with the MultiResourceItemWriter.

Resolves BATCH-2720
2019-11-15 17:46:58 +01:00
Mahmoud Ben Hassine
33f04a9435 Polish 4ad06b5081 2019-11-15 14:58:55 +01:00
Chase Diem
4ad06b5081 BATCH-2845 fix for XSD documentation 2019-11-15 14:56:16 +01:00
Yanming Zhou
af4549bc6a Add https schemas 2019-11-15 11:04:24 +01:00
klauswolfgang
cc6f60871e BATCH-2480 Fix regression due to the fix of BATCH-2442 2019-11-14 11:41:04 +01:00
Mahmoud Ben Hassine
3466f32fba Update docs 2019-10-25 17:12:23 +02:00
Mahmoud Ben Hassine
1622a742b1 Add js to redirect old anchors to new ones 2019-10-24 15:45:28 +02:00
Mahmoud Ben Hassine
e7647b94c3 Polish 43b31ae89c 2019-10-21 11:54:30 +02:00
Mahmoud Ben Hassine
43b31ae89c Make the list of streams final in CompositeItemStream
Resolves BATCH-1969
2019-10-21 11:43:58 +02:00