Commit Graph

5145 Commits

Author SHA1 Message Date
Takaaki Iida
cae2cabdce BATCH-2567: Allow to access MongoItemWriter.template from a subclass
JIRA: https://jira.spring.io/browse/BATCH-2567
2017-11-30 10:14:23 -06:00
Michael Minella
b2f91ae395 Added builder method for new Query option on the MongoItemReader 2017-11-29 11:16:10 -06:00
Michael Minella
6e0df991b6 Polish 2017-11-27 18:01:26 -06:00
Takaaki Iida
6d88d1f3d2 BATCH-2568: MongoItemReader should support Query object by default
JIRA: https://jira.spring.io/browse/BATCH-2568
2017-11-27 17:12:15 -06:00
Olivier Bourgain
62a580f52d Revert the behavior of DelimitedLineTokenizer to pre-4
DelimitedLineTokenizer was refactored to improve its performance but its behavior was also slightly changed.
When the input is an empty csv string with double quotes, e.g. the java
String line = "\"\""; the tokenizer returns the same String, whereas
before it was returning an empty string.

This is due to the condition checking for quotes to remove not stripping
the double quotes from the empty csv string (because its length is 2 and
the code check for strictly greater than 2).
The previous code is there 973fe44d6c/spring-batch-infrastructure/src/main/java/org/springframework/batch/item/file/transform/DelimitedLineTokenizer.java (L202)  and checking for
double quotes at the start and end of the string without special
handling for the empty string.

At test is also added to ensure this won't break again.

Resolves BATCH-2657
2017-11-27 16:43:01 -06:00
Glenn Renfro
31c7e8f83f Converted adoc to use both XML and Java config 2017-11-27 13:32:23 -06:00
Michael Minella
f61679b55f Added updates for properties files as well 2017-11-27 12:06:29 -06:00
Glenn Renfro
ab0533399c Removed log4j 1.x dependencies and fixed a test.
Resolves BATCH-2656
2017-11-27 11:11:22 -06:00
Michael Minella
8fa5929a44 Updated documentation to outline skip behaviour of RepositoryItemReader
This commit addresses via documentation the issues with using a paging
algorithm for the RepositoryItemReader.

Resolves BATCH-2589
2017-11-27 10:55:57 -06:00
Michael Minella
8a223e35c6 Fixed javadoc for JobOperator#abandon
The javadoc in the `JobOperator#abandon` indicated that a JobExecution
marked as `ABANDONED` can be restarted (it cannot).

Resolves BATCH-2654
2017-11-22 09:19:03 -06:00
Michael Minella
e47bcbdc9f Updated versions before release 2017-11-02 14:12:29 -05:00
René Keller
8402f10242 Add support for DB2AS400 database
Add support for DB2AS400 to DefaultDataFieldMaxValueIncrementerFactory.
Apparently, DB2AS400 is using the same syntax for sequence value
retrieval as standard DB2.

resolves BATCH-2525
2017-11-02 13:21:42 -05:00
Eduardo Jolo
509be945fc Set the StepExecution ExitStatus in the JobStep doExecute 2017-11-02 12:56:09 -05:00
Michael Minella
fa286dc1e9 Refactored JobExecution for performance
In order to make the Map based JobRepository threadsafe, the
JobExecutino was modified to use a `CopyOnWriteArraySet` for the
collection backing the child `StepExecution` collection.  However, this
collection option has bad performance characteristics when used with
large collections.  When using partitioning, it can be common to have a
large number of `StepExecution` instances to add which drastically hurts
start up time.

This commit remove the use of the `CopyOnWriteArraySet` for the
`JobExecution#stepExecutions` and replaces it with a `LinkedHashSet`
wrapped via `Collection.synchronizedSet`.

Resolves BATCH-2384
2017-11-02 12:38:35 -05:00
Daniel Heinrich
9322fe6fae BATCH-2455 unifie listener ordering
Why:
Listeners should be called in normal order before some event
(i.e. read, write) and after that event in reverse order.

Side effects:
The ordering of Chunk and ItemReader Listeners is changed and will
change some behaviors of users. This change is still neccesary because
it is not only the correct and obviouse way, but also prevents new
users to hack around this problem.
2017-11-02 10:29:09 -05:00
Michael Minella
e5fe6a5de6 Updated DefaultBatchConfigurer to not overwrite when autowiring
This commit prevents autowiring from overwriting a value set for the
`DataSource` if it has already been set.

Resolves BATCH-2636
2017-11-02 09:58:11 -05:00
Michael Minella
70a5ec24c5 Added a builder for the StoredProcedureItemReader
This commit adds a builder for the StoredProcedureItemReader

Resolves BATCH-2646
2017-11-01 12:35:20 -05:00
Michael Minella
00a16b41b8 Remove checked exception from FlatFileItemReaderBuilder#build
A checked exception from this method is rather invasive so this commit
refactors it to throw a RuntimeException instead.

Resolves BATCH-2649
2017-10-31 16:12:37 -05:00
Michael Minella
3869885993 Added java configuration examples to common-patterns.adoc
This commit added java based configuration examples to the common
patterns documentation page.
2017-10-31 15:46:13 -05:00
Michael Minella
6f5d80065b Added java config examples for testing.adoc
This commit adds two small tweaks to the testing.adoc that demonstrates
how to import java based configuration into a unit test (instead of
importing XML based configurations).
2017-10-31 11:07:18 -05:00
Michael Minella
22ecd3b629 Added java configuration for the retry.adoc 2017-10-30 16:59:21 -05:00
Michael Minella
a256a83e7b Added java config examples for repeat.adoc 2017-10-30 15:48:12 -05:00
Jay Bryant
ead18f76ba Editing pass for spring-batch-integration.adoc
I improved readability and consistency and fixed sentence errors. No questions in this one.

Applied code review changes to PR
2017-10-30 16:29:46 -04:00
Michael Minella
48e300d2d8 Polish 2017-10-30 13:47:21 -05:00
Chris Kirk
c3814cc27d Updated to have java config examples
This commit updates the scalability.adoc to have java configuration examples for all but the last snip in the doc.
2017-10-30 13:47:13 -05:00
Jay Bryant
38d6e7d496 90-character pass for step.adoc
I removed extraneous white space from non-code lines and arranged the non-code lines to be as close to 90 characters as possible. I also edited the new content.

Applied code review changes
2017-10-30 13:48:53 -04:00
Michael Minella
c25af4d89a Updated Hibernate Validator Coordinates
With the more recent versions of Hibernate Validator, the groupId was
changed from org.hibernate to org.hibernate.validator.  This commit
updates Spring Batch to use the correct coordinates.

Resolves BATCH-2648
2017-10-30 09:17:15 -05:00
Jay Bryant
651275dc03 90-character pass for schema-appendix.adoc
I removed extraneous white space from non-code lines and made all the non-code lines be as close to 90 characters as possible. I also changed a sentence to be more consistent with other similar locations in the document.

Code review fixes applied on merge
2017-10-30 09:41:14 -04:00
Jay Bryant
736b926137 90-character pass for transaction-appendix.adoc
I removed extraneous white spice from non-code lines and made the non-code lines break as close to 90 characters as possible. I also fixed a typo.

Applying cod review changes on merge
2017-10-27 17:35:06 -04:00
Jay Bryant
c68e8eb6cb 90-character pass for readersAndWriters.adoc
I removed extraneous white space from non-code lines and arranged the non-code lines to each be as close 90 characters as possible.

Updated PR on merge with bug fixes
2017-10-27 16:36:49 -04:00
Michael Minella
8afb276b3e Fixed javadoc titles 2017-10-23 16:53:53 -05:00
Michael Minella
52d2c257c5 Version updates 2017-10-23 15:52:55 -05:00
Michael Minella
b2f8f7f9cd Refactored to add a way to copy JobParameters into another via builder
In a previous commit, the JobParametersBuilder was updated to include
some code from Spring Boot that handled the incrementing of
JobParameters for a previous job.  That commit brought over a private
`merge` method that is actually useful for general consumption.

This commit adds a `addJobParameters` method to the builder providing
the same functionality the `merge` method did in a public method.
2017-10-20 12:43:06 -05:00
Michael Minella
63dfe4b912 Polish 2017-10-20 11:57:56 -05:00
Glenn Renfro
a35784dbd6 Support getNextJobParameters from JobParametersBuilder.
resolves BATCH-2640

Cleanup and added tests to JobParametersBuilder.
2017-10-20 11:06:04 -05:00
Jay Bryant
96a317c52f Editing pass for readersAndWriters.adoc
I improved readability and consistency, fixed up errors, and asked a couple questions
2017-10-20 10:52:23 -05:00
Jay Bryant
0efa698572 90-character pass for glossary.adoc
I removed extraneous white space and made the lines break as close to 90 characters as possible.
2017-10-20 10:41:48 -04:00
Michael Minella
f21d4ab808 Added java config examples to readersAndWriter.adoc
This commit adds java config examples to the readers and writers
documentation.
2017-10-19 23:36:39 -05:00
Jay Bryant
8392523056 90-character pass for common-patterns.adoc
I removed all the extraneous white space from non-code lines and broke the non-code lines as close to 90 characters as possible. I caught one keyword that wasn't formatted and fixed that.
2017-10-19 21:17:13 -04:00
Michael Minella
5ecf6990f9 Updated to have java config examples
This commit updates the step.adoc to have java configuratione examples
for all snips in the doc.
2017-10-19 14:58:14 -05:00
Michael Minella
24fbb882e6 Updated job.adoc to have java config examples
This commit addresses the job.adoc and how to configure the various
pieces of the framework it covers via java configuration.
2017-10-18 12:00:27 -05:00
Michael Minella
dd8809232e Fixed image urls 2017-10-18 10:17:53 -05:00
Jay Bryant
733cdb35d1 Fitting lines to 90 characters
Adjusted line breaks to get all the lines to be 90 characters or less.
2017-10-18 10:02:34 -05:00
Jay Bryant
0f989d9c9f 90-character pass for scalability.adoc
I removed extraneous characters from non-code lines and arranged the non-code lines to fit into 90 characters.
2017-10-18 10:01:06 -05:00
Jay Bryant
3a3abdc28a 90-character pass for repeat.adoc
I removed all the extraneous characters and line breaks from non-code lines and fitted all the non-code lines to 90 characters.

polish
2017-10-18 10:52:34 -04:00
Michael Minella
11fed07d16 Fix image URL 2017-10-17 23:32:08 -05:00
Jay Bryant
c83d9b4557 90-character pass for domain.adoc
I removed extraneous characters from non-code lines and made each code line be as close to 90 characters as possible. I caught a few items I missed in the editing pass (such as missing hyphen and code ticks around some code words.
2017-10-17 23:24:05 -05:00
Jay Bryant
d0238c9699 90-character formatting
Other than a couple of image references, I fixed all the lines so that they would be no longer than 90 characters and removed unneeded blank lines.

I did find a few other things (mostly periods missing from list items), and I fixed them.
2017-10-17 23:15:13 -05:00
Jay Bryant
55469e3362 Editing pass for schema-appendix.adoc
I increased readability and consistency and corrected sentence errors. I also added a couple internal cross-reference links.
2017-10-17 22:14:17 -05:00
Michael Minella
0c4937ac5a Polish 2017-10-17 21:45:43 -05:00