Spring/spring-boot-data-geode
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rename PdxInstanceWrapperAspect to PdxInstanceWrapperRegionAspect.

Browse Source 
Edit Javadoc.

Resolves gh-67.
This commit is contained in:
John Blum
2020-05-12 21:33:51 -07:00
parent a6f07e88b0
commit 854a233b04
3 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-geode-autoconfigure/src/main/java/org/springframework/geode/boot/autoconfigure/DataImportExportAutoConfiguration.java
View File

@@ -32,7 +32,7 @@ import org.springframework.context.annotation.Configuration;
import org.springframework.core.env.Environment;
import org.springframework.core.type.AnnotatedTypeMetadata;
import org.springframework.data.gemfire.CacheFactoryBean;
import org.springframework.geode.boot.autoconfigure.support.PdxInstanceWrapperAspect;
import org.springframework.geode.boot.autoconfigure.support.PdxInstanceWrapperRegionAspect;
import org.springframework.geode.cache.SimpleCacheResolver;
import org.springframework.geode.data.json.JsonCacheDataImporterExporter;
import org.springframework.lang.NonNull;
@@ -54,7 +54,7 @@ import org.springframework.lang.NonNull;
* @see org.springframework.core.env.Environment
* @see org.springframework.core.type.AnnotatedTypeMetadata
* @see org.springframework.data.gemfire.CacheFactoryBean
* @see org.springframework.geode.boot.autoconfigure.support.PdxInstanceWrapperAspect
* @see PdxInstanceWrapperRegionAspect
* @see org.springframework.geode.cache.SimpleCacheResolver
* @see org.springframework.geode.data.json.JsonCacheDataImporterExporter
* @since 1.3.0
@@ -76,8 +76,8 @@ public class DataImportExportAutoConfiguration {
@Bean
@Conditional(RegionAdviceConditions.class)
PdxInstanceWrapperAspect pdxInstanceWrapperAspect() {
return new PdxInstanceWrapperAspect();
PdxInstanceWrapperRegionAspect pdxInstanceWrapperAspect() {
return new PdxInstanceWrapperRegionAspect();
}
static class RegionAdviceConditions extends AnyNestedCondition {

8
spring-geode-autoconfigure/src/main/java/org/springframework/geode/boot/autoconfigure/support/PdxInstanceWrapperAspect.java → spring-geode-autoconfigure/src/main/java/org/springframework/geode/boot/autoconfigure/support/PdxInstanceWrapperRegionAspect.java
View File

@@ -22,6 +22,7 @@ import java.util.stream.Collectors;
import org.apache.geode.cache.CacheStatistics;
import org.apache.geode.cache.Region;
import org.apache.geode.pdx.PdxInstance;
import org.springframework.geode.pdx.PdxInstanceWrapper;
import org.springframework.lang.NonNull;
@@ -35,8 +36,13 @@ import org.aspectj.lang.annotation.Pointcut;
/**
* A Spring, AspectJ {@link Aspect} advising GemFire/Geode cache {@link Region} data access operations.
*
* Specifically, this {@link Aspect} wraps all {@link PdxInstance} objects returned from cache {@link Region}
* read data access operations inside a new instance of {@link PdxInstanceWrapper}.
*
* @author John Blum
* @see java.util.Map
* @see org.apache.geode.cache.Region
* @see org.apache.geode.pdx.PdxInstance
* @see org.aspectj.lang.annotation.Around
* @see org.aspectj.lang.annotation.Aspect
* @see org.aspectj.lang.annotation.Pointcut
@@ -45,7 +51,7 @@ import org.aspectj.lang.annotation.Pointcut;
*/
@Aspect
@SuppressWarnings("unused")
public class PdxInstanceWrapperAspect {
public class PdxInstanceWrapperRegionAspect {
private static Collection<?> asCollection(Object value) {
return value instanceof Collection ? (Collection<?>) value : Collections.emptyList();

14
spring-geode-autoconfigure/src/test/java/org/springframework/geode/boot/autoconfigure/pdx/PdxInstanceWrapperAspectUnitTests.java → spring-geode-autoconfigure/src/test/java/org/springframework/geode/boot/autoconfigure/pdx/PdxInstanceWrapperRegionAspectUnitTests.java
View File

@@ -37,14 +37,14 @@ import org.apache.geode.cache.CacheStatistics;
import org.apache.geode.cache.Region;
import org.apache.geode.pdx.PdxInstance;
import org.springframework.geode.boot.autoconfigure.support.PdxInstanceWrapperAspect;
import org.springframework.geode.boot.autoconfigure.support.PdxInstanceWrapperAspect.RegionEntryWrapper;
import org.springframework.geode.boot.autoconfigure.support.PdxInstanceWrapperRegionAspect;
import org.springframework.geode.boot.autoconfigure.support.PdxInstanceWrapperRegionAspect.RegionEntryWrapper;
import org.springframework.geode.pdx.PdxInstanceWrapper;
import org.aspectj.lang.ProceedingJoinPoint;
/**
* Unit Tests for {@link PdxInstanceWrapperAspect}
* Unit Tests for {@link PdxInstanceWrapperRegionAspect}
*
* @author John Blum
* @see java.util.Map
@@ -52,14 +52,14 @@ import org.aspectj.lang.ProceedingJoinPoint;
* @see org.mockito.Mockito
* @see org.apache.geode.cache.Region
* @see org.apache.geode.pdx.PdxInstance
* @see org.springframework.geode.boot.autoconfigure.support.PdxInstanceWrapperAspect
* @see org.springframework.geode.boot.autoconfigure.support.PdxInstanceWrapperAspect.RegionEntryWrapper
* @see PdxInstanceWrapperRegionAspect
* @see PdxInstanceWrapperRegionAspect.RegionEntryWrapper
* @see org.springframework.geode.pdx.PdxInstanceWrapper
* @since 1.3.0
*/
public class PdxInstanceWrapperAspectUnitTests {
public class PdxInstanceWrapperRegionAspectUnitTests {
private PdxInstanceWrapperAspect aspect = new PdxInstanceWrapperAspect();
private PdxInstanceWrapperRegionAspect aspect = new PdxInstanceWrapperRegionAspect();
@Test
public void regionGetAdviceWrapsPdx() throws Throwable {