Spring/spring-boot-data-geode
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add default name for DelegatingAppender.

Browse Source 
Resolves gh-73.
This commit is contained in:
John Blum
2020-02-11 19:24:28 -08:00
parent 21cc8e6c4b
commit 99cff21c17
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spring-geode-starter-logging/src/main/java/org/springframework/geode/logging/slf4j/logback/DelegatingAppender.java
View File

@@ -39,15 +39,19 @@ import ch.qos.logback.core.helpers.NOPAppender;
public class DelegatingAppender<T> extends AppenderBase<T> {
@SuppressWarnings("rawtypes")
protected static final Appender defaultAppender = new NOPAppender<>();
protected static final Appender DEFAULT_APPENDER = new NOPAppender<>();
protected static final String DEFAULT_NAME = "delegate";
public DelegatingAppender() {
Optional.ofNullable(LoggerFactory.getILoggerFactory())
.filter(it -> Objects.isNull(defaultAppender.getContext()))
.filter(it -> Objects.isNull(DEFAULT_APPENDER.getContext()))
.filter(Context.class::isInstance)
.map(Context.class::cast)
.ifPresent(defaultAppender::setContext);
.ifPresent(DEFAULT_APPENDER::setContext);
this.name = DEFAULT_NAME;
}
private volatile Appender<T> appender;
@@ -58,7 +62,7 @@ public class DelegatingAppender<T> extends AppenderBase<T> {
@SuppressWarnings("unchecked")
protected Appender<T> getAppender() {
return Optional.ofNullable(this.appender).orElse(defaultAppender);
return Optional.ofNullable(this.appender).orElse(DEFAULT_APPENDER);
}
@Override

5
spring-geode-starter-logging/src/test/java/org/springframework/geode/logging/slf4j/logback/DelegatingAppenderUnitTests.java
View File

@@ -38,6 +38,11 @@ import ch.qos.logback.core.helpers.NOPAppender;
*/
public class DelegatingAppenderUnitTests {
@Test
public void delegatingAppenderDefaultsNameToDelegate() {
assertThat(new DelegatingAppender<>().getName()).isEqualTo(DelegatingAppender.DEFAULT_NAME);
}
@Test
public void delegatingAppenderDefaultsToNoOpAppender() {
assertThat(new DelegatingAppender<>().getAppender()).isInstanceOf(NOPAppender.class);