Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Replace multiple ifs with switch

Browse Source 
See gh-39259
This commit is contained in:
Tobias Lippert
2024-01-21 20:03:16 +01:00
committed by Phillip Webb
parent 316b415e95
commit 0613034e19
3 changed files with 15 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-websocket-jetty/src/main/java/smoketest/websocket/jetty/snake/SnakeWebSocketHandler.java
View File

@@ -80,17 +80,11 @@ public class SnakeWebSocketHandler extends TextWebSocketHandler {
@Override
protected void handleTextMessage(WebSocketSession session, TextMessage message) throws Exception {
String payload = message.getPayload();
if ("west".equals(payload)) {
this.snake.setDirection(Direction.WEST);
}
else if ("north".equals(payload)) {
this.snake.setDirection(Direction.NORTH);
}
else if ("east".equals(payload)) {
this.snake.setDirection(Direction.EAST);
}
else if ("south".equals(payload)) {
this.snake.setDirection(Direction.SOUTH);
switch (payload) {
case "west" -> this.snake.setDirection(Direction.WEST);
case "north" -> this.snake.setDirection(Direction.NORTH);
case "east" -> this.snake.setDirection(Direction.EAST);
case "south" -> this.snake.setDirection(Direction.SOUTH);
}
}

16
spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-websocket-tomcat/src/main/java/smoketest/websocket/tomcat/snake/SnakeWebSocketHandler.java
View File

@@ -80,17 +80,11 @@ public class SnakeWebSocketHandler extends TextWebSocketHandler {
@Override
protected void handleTextMessage(WebSocketSession session, TextMessage message) throws Exception {
String payload = message.getPayload();
if ("west".equals(payload)) {
this.snake.setDirection(Direction.WEST);
}
else if ("north".equals(payload)) {
this.snake.setDirection(Direction.NORTH);
}
else if ("east".equals(payload)) {
this.snake.setDirection(Direction.EAST);
}
else if ("south".equals(payload)) {
this.snake.setDirection(Direction.SOUTH);
switch (payload) {
case "west" -> this.snake.setDirection(Direction.WEST);
case "north" -> this.snake.setDirection(Direction.NORTH);
case "east" -> this.snake.setDirection(Direction.EAST);
case "south" -> this.snake.setDirection(Direction.SOUTH);
}
}

16
spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-websocket-undertow/src/main/java/smoketest/websocket/undertow/snake/SnakeWebSocketHandler.java
View File

@@ -80,17 +80,11 @@ public class SnakeWebSocketHandler extends TextWebSocketHandler {
@Override
protected void handleTextMessage(WebSocketSession session, TextMessage message) throws Exception {
String payload = message.getPayload();
if ("west".equals(payload)) {
this.snake.setDirection(Direction.WEST);
}
else if ("north".equals(payload)) {
this.snake.setDirection(Direction.NORTH);
}
else if ("east".equals(payload)) {
this.snake.setDirection(Direction.EAST);
}
else if ("south".equals(payload)) {
this.snake.setDirection(Direction.SOUTH);
switch (payload) {
case "west" -> this.snake.setDirection(Direction.WEST);
case "north" -> this.snake.setDirection(Direction.NORTH);
case "east" -> this.snake.setDirection(Direction.EAST);
case "south" -> this.snake.setDirection(Direction.SOUTH);
}
}