Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix IndexOutOfBoundsException exception from parseUrl with empty spec

Browse Source 
Update jar `Handler` code so that the `parseUrl` method can accept an
empty `spec`. Prior to this commit, a `classLoader.getResource("")`
call would result in a `null` result. This breaks a number of things
including `ClassPathResource` and `PathMatchingResourcePatternResolver`.

Fixes gh-38524
This commit is contained in:
Phillip Webb
2023-11-23 14:35:04 -08:00
parent 7387c1c64c
commit 0856e10443
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-boot-project/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/net/protocol/jar/Handler.java
View File

@@ -89,7 +89,7 @@ public class Handler extends URLStreamHandler {
private String extractContextPath(URL url, String spec, int start) {
String contextPath = url.getPath();
if (spec.charAt(start) == '/') {
if (spec.regionMatches(false, start, "/", 0, 1)) {
int indexOfContextPathSeparator = indexOfSeparator(contextPath);
if (indexOfContextPathSeparator == -1) {
throw new IllegalStateException("malformed context url:%s: no !/".formatted(url));

9
spring-boot-project/spring-boot-tools/spring-boot-loader/src/test/java/org/springframework/boot/loader/net/protocol/jar/HandlerTests.java
View File

@@ -142,6 +142,15 @@ class HandlerTests {
assertThat(url.toExternalForm()).isEqualTo("jar:file:example.jar!/entry.txt#runtime");
}
@Test // gh-38524
void parseUrlWhenSpecIsEmpty() throws MalformedURLException {
URL url = createJarUrl("nested:gh-38524.jar/!BOOT-INF/classes/!/");
String spec = "";
this.handler.parseURL(url, spec, 0, 0);
assertThat(url.toExternalForm()).isEqualTo("jar:nested:gh-38524.jar/!BOOT-INF/classes/!/");
}
@Test
void hashCodeGeneratesHashCode() throws MalformedURLException {
URL url = createJarUrl("file:example.jar!/entry.txt");