Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Increase timeouts in ZipkinWebClientSenderTests

Browse Source 
This is an attempt to stabilize the tests. They are currently flaky
due to a timeout that appears to occur because the mock web server isn't
responding quickly enough. A larger timeout will either confirm this if
the tests stabilize or indicate that the problem has a different cause
if they do not stabilize.

Closes gh-42375
This commit is contained in:
Andy Wilkinson
2024-09-19 14:11:09 +01:00
parent 319e33f786
commit 0aeea6f069
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/zipkin/ZipkinHttpSenderTests.java
View File

@@ -91,7 +91,7 @@ abstract class ZipkinHttpSenderTests {
callbackResult.set(new CallbackResult(false, t));
}
});
return Awaitility.await().atMost(Duration.ofSeconds(5)).until(callbackResult::get, Objects::nonNull);
return Awaitility.await().atMost(Duration.ofMinutes(1)).until(callbackResult::get, Objects::nonNull);
}
protected void makeSyncRequest(List<byte[]> encodedSpans) throws IOException {

2
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/zipkin/ZipkinWebClientSenderTests.java
View File

@@ -80,7 +80,7 @@ class ZipkinWebClientSenderTests extends ZipkinHttpSenderTests {
@Override
Sender createSender() {
return createSender(Duration.ofSeconds(10));
return createSender(Duration.ofMinutes(1));
}
Sender createSender(Duration timeout) {