Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove FIXME from JPA sample

Browse Source
This commit is contained in:
Dave Syer
2013-12-05 09:38:10 +00:00
parent 4ab77ca893
commit 25d9ac6535
4 changed files with 4 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/org/springframework/boot/sample/data/jpa/domain/ReviewDetails.java
View File

@@ -19,8 +19,6 @@ package org.springframework.boot.sample.data.jpa.domain;
import java.io.Serializable;
import java.util.Date;
//FIXME Hibernate bug HHH-5792 prevents this being embedded
public class ReviewDetails implements Serializable {
private static final long serialVersionUID = 1L;
@@ -38,12 +36,6 @@ public class ReviewDetails implements Serializable {
public ReviewDetails() {
}
@Deprecated
public ReviewDetails(String title, Rating rating) {
this.title = title;
this.rating = rating;
}
public Rating getRating() {
return this.rating;
}

2
spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/org/springframework/boot/sample/data/jpa/service/CityServiceImpl.java
View File

@@ -30,8 +30,6 @@ import org.springframework.util.StringUtils;
@Transactional
class CityServiceImpl implements CityService {
// FIXME deal with null repository return values
private final CityRepository cityRepository;
private final HotelRepository hotelRepository;

7
spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/org/springframework/boot/sample/data/jpa/service/HotelServiceImpl.java
View File

@@ -37,8 +37,6 @@ import org.springframework.util.Assert;
@Transactional
class HotelServiceImpl implements HotelService {
// FIXME deal with null repository return values
private final HotelRepository hotelRepository;
private final ReviewRepository reviewRepository;
@@ -71,9 +69,8 @@ class HotelServiceImpl implements HotelService {
@Override
public Review addReview(Hotel hotel, ReviewDetails details) {
// FIXME
System.out.println(details.getTitle());
return new Review(hotel, 1, details);
Review review = new Review(hotel, 1, details);
return reviewRepository.save(review);
}
@Override

2
spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/org/springframework/boot/sample/data/jpa/service/ReviewRepository.java
View File

@@ -27,5 +27,7 @@ interface ReviewRepository extends Repository<Review, Long> {
Page<Review> findByHotel(Hotel hotel, Pageable pageable);
Review findByHotelAndIndex(Hotel hotel, int index);
Review save(Review review);
}