Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polish "Expose Stackdriver's useSemanticMetricTypes property"

Browse Source 
See gh-28403
This commit is contained in:
Andy Wilkinson
2021-10-21 17:57:23 +01:00
parent 9397121a98
commit 284725f5be
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/stackdriver/StackdriverProperties.java
View File

@@ -48,10 +48,9 @@ public class StackdriverProperties extends StepRegistryProperties {
private Map<String, String> resourceLabels;
/**
* Whether to use semantically correct metric types. When this is false, counter
* metrics are published as the GAUGE MetricKind. When this is true, counter metrics
* are published as the CUMULATIVE MetricKind. This is false by default for the sake
* of backwards compatibility.
* Whether to use semantically correct metric types. When false, counter metrics are
* published as the GAUGE MetricKind. When true, counter metrics are published as the
* CUMULATIVE MetricKind.
*/
private boolean useSemanticMetricTypes = false;

2
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/stackdriver/StackdriverPropertiesConfigAdapterTests.java
View File

@@ -60,8 +60,6 @@ class StackdriverPropertiesConfigAdapterTests {
StackdriverProperties properties = new StackdriverProperties();
properties.setUseSemanticMetricTypes(true);
assertThat(new StackdriverPropertiesConfigAdapter(properties).useSemanticMetricTypes()).isTrue();
properties.setUseSemanticMetricTypes(false);
assertThat(new StackdriverPropertiesConfigAdapter(properties).useSemanticMetricTypes()).isFalse();
}
}