Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polish "Less object instantiation in WebMvcTags"

Browse Source 
Closes gh-12894
This commit is contained in:
Stephane Nicoll
2018-04-18 09:38:38 +02:00
parent d676147680
commit 2b98b11c12
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/metrics/web/servlet/WebMvcTags.java
View File

@@ -58,7 +58,7 @@ public final class WebMvcTags {
* @return the method tag whose value is a capitalized method (e.g. GET).
*/
public static Tag method(HttpServletRequest request) {
return request == null ? METHOD_UNKNOWN : Tag.of("method", request.getMethod());
return (request == null ? METHOD_UNKNOWN : Tag.of("method", request.getMethod()));
}
/**
@@ -67,8 +67,8 @@ public final class WebMvcTags {
* @return the status tag derived from the status of the response
*/
public static Tag status(HttpServletResponse response) {
return response == null ? STATUS_UNKNOWN :
Tag.of("status", Integer.toString(response.getStatus()));
return (response == null ? STATUS_UNKNOWN :
Tag.of("status", Integer.toString(response.getStatus())));
}
/**
@@ -128,8 +128,9 @@ public final class WebMvcTags {
* @return the exception tag derived from the exception
*/
public static Tag exception(Throwable exception) {
return exception == null ? EXCEPTION_NONE :
Tag.of("exception", exception.getClass().getSimpleName());
return (exception != null
? Tag.of("exception", exception.getClass().getSimpleName())
: EXCEPTION_NONE);
}
}