Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve performance of ConcurrentReferenceCachingMetadataReaderFactory

Browse Source 
Update `ConcurrentReferenceCachingMetadataReaderFactory` with cache
by class name.

Closes gh-42949
This commit is contained in:
Phillip Webb
2024-10-30 16:54:34 -07:00
parent 7eb98b4487
commit 9890872a9a
1 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/type/classreading/ConcurrentReferenceCachingMetadataReaderFactory.java
View File

@@ -38,7 +38,9 @@ import org.springframework.util.ConcurrentReferenceHashMap;
*/
public class ConcurrentReferenceCachingMetadataReaderFactory extends SimpleMetadataReaderFactory {
private final Map<Resource, MetadataReader> cache = new ConcurrentReferenceHashMap<>();
private final Map<String, MetadataReader> classNameCache = new ConcurrentReferenceHashMap<>();
private final Map<Resource, MetadataReader> resourceCache = new ConcurrentReferenceHashMap<>();
/**
* Create a new {@link ConcurrentReferenceCachingMetadataReaderFactory} instance for
@@ -66,12 +68,22 @@ public class ConcurrentReferenceCachingMetadataReaderFactory extends SimpleMetad
super(classLoader);
}
@Override
public MetadataReader getMetadataReader(String className) throws IOException {
MetadataReader metadataReader = this.classNameCache.get(className);
if (metadataReader == null) {
metadataReader = super.getMetadataReader(className);
this.classNameCache.put(className, metadataReader);
}
return metadataReader;
}
@Override
public MetadataReader getMetadataReader(Resource resource) throws IOException {
MetadataReader metadataReader = this.cache.get(resource);
MetadataReader metadataReader = this.resourceCache.get(resource);
if (metadataReader == null) {
metadataReader = createMetadataReader(resource);
this.cache.put(resource, metadataReader);
this.resourceCache.put(resource, metadataReader);
}
return metadataReader;
}
@@ -90,7 +102,8 @@ public class ConcurrentReferenceCachingMetadataReaderFactory extends SimpleMetad
* Clear the entire MetadataReader cache, removing all cached class metadata.
*/
public void clearCache() {
this.cache.clear();
this.classNameCache.clear();
this.resourceCache.clear();
}
}