Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use String.replace() with single char if possible

Browse Source 
See gh-8089
This commit is contained in:
dreis
2017-01-24 19:39:17 +01:00
committed by Stephane Nicoll
parent 551bfb2c60
commit d58f38f6f6
19 changed files with 23 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/mvc/HealthMvcEndpoint.java
View File

@@ -139,7 +139,7 @@ public class HealthMvcEndpoint extends AbstractEndpointMvcAdapter<HealthEndpoint
private HttpStatus getStatus(Health health) {
String code = health.getStatus().getCode();
if (code != null) {
code = code.toLowerCase().replace("_", "-");
code = code.toLowerCase().replace('_', '-');
for (String candidate : RelaxedNames.forCamelCase(code)) {
HttpStatus status = this.statusMapping.get(candidate);
if (status != null) {

2
spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/cache/CacheCondition.java vendored
View File

@@ -50,7 +50,7 @@ class CacheCondition extends SpringBootCondition {
}
CacheType cacheType = CacheConfigurations
.getType(((AnnotationMetadata) metadata).getClassName());
String value = resolver.getProperty("type").replace("-", "_").toUpperCase();
String value = resolver.getProperty("type").replace('-', '_').toUpperCase();
if (value.equals(cacheType.name())) {
return ConditionOutcome.match(message.because(value + " cache type"));
}

2
spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/session/SessionCondition.java
View File

@@ -45,7 +45,7 @@ class SessionCondition extends SpringBootCondition {
return ConditionOutcome.noMatch(
message.didNotFind("spring.session.store-type property").atAll());
}
String value = resolver.getProperty("store-type").replace("-", "_").toUpperCase();
String value = resolver.getProperty("store-type").replace('-', '_').toUpperCase();
if (value.equals(sessionStoreType.name())) {
return ConditionOutcome.match(message
.found("spring.session.store-type property").items(sessionStoreType));

2
spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/DefaultErrorViewResolverTests.java
View File

@@ -212,7 +212,7 @@ public class DefaultErrorViewResolverTests {
private void setResourceLocation(String path) {
String packageName = getClass().getPackage().getName();
this.resourceProperties.setStaticLocations(new String[] {
"classpath:" + packageName.replace(".", "/") + path + "/" });
"classpath:" + packageName.replace('.', '/') + path + "/" });
}
private MockHttpServletResponse render(ModelAndView modelAndView) throws Exception {

2
spring-boot-cli/src/main/java/org/springframework/boot/cli/command/archive/ArchiveCommand.java
View File

@@ -264,7 +264,7 @@ abstract class ArchiveCommand extends OptionParsingCommand {
if (classLoader == null) {
classLoader = Thread.currentThread().getContextClassLoader();
}
String name = sourceClass.replace(".", "/") + ".class";
String name = sourceClass.replace('.', '/') + ".class";
InputStream stream = classLoader.getResourceAsStream(name);
writer.writeEntry(this.layout.getClassesLocation() + name, stream);
}

2
spring-boot-cli/src/main/java/org/springframework/boot/cli/compiler/ExtendedGroovyClassLoader.java
View File

@@ -161,7 +161,7 @@ public class ExtendedGroovyClassLoader extends GroovyClassLoader {
protected Class<?> createClass(byte[] code, ClassNode classNode) {
Class<?> createdClass = super.createClass(code, classNode);
ExtendedGroovyClassLoader.this.classResources
.put(classNode.getName().replace(".", "/") + ".class", code);
.put(classNode.getName().replace('.', '/') + ".class", code);
return createdClass;
}

2
spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/classloader/RestartClassLoaderTests.java
View File

@@ -52,7 +52,7 @@ public class RestartClassLoaderTests {
private static final String PACKAGE = RestartClassLoaderTests.class.getPackage()
.getName();
private static final String PACKAGE_PATH = PACKAGE.replace(".", "/");
private static final String PACKAGE_PATH = PACKAGE.replace('.', '/');
private static final Charset UTF_8 = Charset.forName("UTF-8");

2
spring-boot-devtools/src/test/java/org/springframework/boot/devtools/settings/DevToolsSettingsTests.java
View File

@@ -37,7 +37,7 @@ public class DevToolsSettingsTests {
public TemporaryFolder temporaryFolder = new TemporaryFolder();
private static final String ROOT = DevToolsSettingsTests.class.getPackage().getName()
.replace(".", "/") + "/";
.replace('.', '/') + "/";
@Test
public void includePatterns() throws Exception {

2
spring-boot-test-support/src/main/java/org/springframework/boot/junit/compiler/TestCompiler.java
View File

@@ -99,7 +99,7 @@ public class TestCompiler {
}
public static String sourcePathFor(Class<?> type) {
return type.getName().replace(".", "/") + ".java";
return type.getName().replace('.', '/') + ".java";
}
protected File getSourceFolder() {

2
spring-boot-test/src/test/java/org/springframework/boot/test/testutil/AbstractConfigurationClassTests.java
View File

@@ -65,7 +65,7 @@ public abstract class AbstractConfigurationClassTests {
private Set<AnnotationMetadata> findConfigurationClasses() throws IOException {
Set<AnnotationMetadata> configurationClasses = new HashSet<AnnotationMetadata>();
Resource[] resources = this.resolver.getResources("classpath*:"
+ getClass().getPackage().getName().replace(".", "/") + "/**/*.class");
+ getClass().getPackage().getName().replace('.', '/') + "/**/*.class");
for (Resource resource : resources) {
if (!isTestClass(resource)) {
MetadataReader metadataReader = new SimpleMetadataReaderFactory()

2
spring-boot-tools/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/MainClassFinder.java
View File

@@ -262,7 +262,7 @@ public abstract class MainClassFinder {
}
private static String convertToClassName(String name, String prefix) {
name = name.replace("/", ".");
name = name.replace('/', '.');
name = name.replace('\\', '.');
name = name.substring(0, name.length() - DOT_CLASS.length());
if (prefix != null) {

2
spring-boot-tools/spring-boot-loader-tools/src/test/java/org/springframework/boot/loader/tools/TestJarFile.java
View File

@@ -55,7 +55,7 @@ public class TestJarFile {
File file = getFilePath(filename);
file.getParentFile().mkdirs();
InputStream inputStream = getClass().getResourceAsStream(
"/" + classToCopy.getName().replace(".", "/") + ".class");
"/" + classToCopy.getName().replace('.', '/') + ".class");
copyToFile(inputStream, file);
if (time != null) {
file.setLastModified(time);

4
spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/LaunchedURLClassLoader.java
View File

@@ -132,8 +132,8 @@ public class LaunchedURLClassLoader extends URLClassLoader {
AccessController.doPrivileged(new PrivilegedExceptionAction<Object>() {
@Override
public Object run() throws ClassNotFoundException {
String packageEntryName = packageName.replace(".", "/") + "/";
String classEntryName = className.replace(".", "/") + ".class";
String packageEntryName = packageName.replace('.', '/') + "/";
String classEntryName = className.replace('.', '/') + ".class";
for (URL url : getURLs()) {
try {
URLConnection connection = url.openConnection();

2
spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/PropertiesLauncher.java
View File

@@ -359,7 +359,7 @@ public class PropertiesLauncher extends Launcher {
private String getProperty(String propertyKey, String manifestKey) throws Exception {
if (manifestKey == null) {
manifestKey = propertyKey.replace(".", "-");
manifestKey = propertyKey.replace('.', '-');
manifestKey = toCamelCase(manifestKey);
}
String property = SystemPropertyUtils.getProperty(propertyKey);

4
spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/util/SystemPropertyUtils.java
View File

@@ -184,11 +184,11 @@ public abstract class SystemPropertyUtils {
}
if (propVal == null) {
// Try with underscores.
propVal = System.getenv(key.replace(".", "_"));
propVal = System.getenv(key.replace('.', '_'));
}
if (propVal == null) {
// Try uppercase with underscores as well.
propVal = System.getenv(key.toUpperCase().replace(".", "_"));
propVal = System.getenv(key.toUpperCase().replace('.', '_'));
}
if (propVal != null) {
return propVal;

2
spring-boot/src/main/java/org/springframework/boot/bind/RelaxedConversionService.java
View File

@@ -127,7 +127,7 @@ class RelaxedConversionService implements ConversionService {
source = source.trim();
for (T candidate : (Set<T>) EnumSet.allOf(this.enumType)) {
RelaxedNames names = new RelaxedNames(
candidate.name().replace("_", "-").toLowerCase());
candidate.name().replace('_', '-').toLowerCase());
for (String name : names) {
if (name.equals(source)) {
return candidate;

6
spring-boot/src/main/java/org/springframework/boot/bind/RelaxedNames.java
View File

@@ -127,7 +127,7 @@ public final class RelaxedNames implements Iterable<String> {
@Override
public String apply(String value) {
return value.indexOf('-') != -1 ? value.replace("-", "_") : value;
return value.indexOf('-') != -1 ? value.replace('-', '_') : value;
}
},
@@ -136,7 +136,7 @@ public final class RelaxedNames implements Iterable<String> {
@Override
public String apply(String value) {
return value.indexOf('_') != -1 ? value.replace("_", ".") : value;
return value.indexOf('_') != -1 ? value.replace('_', '.') : value;
}
},
@@ -145,7 +145,7 @@ public final class RelaxedNames implements Iterable<String> {
@Override
public String apply(String value) {
return value.indexOf('.') != -1 ? value.replace(".", "_") : value;
return value.indexOf('.') != -1 ? value.replace('.', '_') : value;
}
},

2
spring-boot/src/main/java/org/springframework/boot/logging/AbstractLoggingSystem.java
View File

@@ -172,7 +172,7 @@ public abstract class AbstractLoggingSystem extends LoggingSystem {
protected final String getPackagedConfigFile(String fileName) {
String defaultPath = ClassUtils.getPackageName(getClass());
defaultPath = defaultPath.replace(".", "/");
defaultPath = defaultPath.replace('.', '/');
defaultPath = defaultPath + "/" + fileName;
defaultPath = "classpath:" + defaultPath;
return defaultPath;

2
spring-boot/src/test/java/org/springframework/boot/context/embedded/XmlEmbeddedWebApplicationContextTests.java
View File

@@ -32,7 +32,7 @@ import static org.mockito.Mockito.verify;
public class XmlEmbeddedWebApplicationContextTests {
private static final String PATH = XmlEmbeddedWebApplicationContextTests.class
.getPackage().getName().replace(".", "/") + "/";
.getPackage().getName().replace('.', '/') + "/";
private static final String FILE = "exampleEmbeddedWebApplicationConfiguration.xml";