Spring/spring-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Stop failing the build when tests pass after retry

Browse Source 
Closes gh-37392
This commit is contained in:
Andy Wilkinson
2023-09-15 08:34:08 +01:00
parent b74106db5f
commit e8e5146beb
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
buildSrc/src/main/java/org/springframework/boot/build/JavaConventions.java
View File

@@ -178,7 +178,7 @@ class JavaConventions {
private void configureTestRetries(Test test) {
TestRetryExtension testRetry = test.getExtensions().getByType(TestRetryExtension.class);
testRetry.getFailOnPassedAfterRetry().set(true);
testRetry.getFailOnPassedAfterRetry().set(false);
testRetry.getMaxRetries().set(isCi() ? 3 : 0);
}

4
buildSrc/src/test/java/org/springframework/boot/build/ConventionsPluginTests.java
View File

@@ -187,7 +187,7 @@ class ConventionsPluginTests {
}
assertThat(runGradle(Collections.singletonMap("CI", "true"), "retryConfig", "--stacktrace").getOutput())
.contains("maxRetries: 3")
.contains("failOnPassedAfterRetry: true");
.contains("failOnPassedAfterRetry: false");
}
@Test
@@ -209,7 +209,7 @@ class ConventionsPluginTests {
}
assertThat(runGradle(Collections.singletonMap("CI", "local"), "retryConfig", "--stacktrace").getOutput())
.contains("maxRetries: 0")
.contains("failOnPassedAfterRetry: true");
.contains("failOnPassedAfterRetry: false");
}
private BuildResult runGradle(String... args) {