Commit Graph

22263 Commits

Author SHA1 Message Date
Andy Wilkinson
f7850ef898 Merge pull request #17431 from dreis2211
* gh-17431:
  Remove references to archived spring-boot-issues repo

Closes gh-17431
2019-07-08 12:50:57 +01:00
dreis2211
cec4ec97dd Remove references to archived spring-boot-issues repo
See gh-17431
2019-07-08 12:50:49 +01:00
Andy Wilkinson
024543a9d5 Merge pull request #17443 from agebhar1
* gh-17443:
  Fix JavaDoc within spring-boot-test-support

Closes gh-17443
2019-07-08 12:48:49 +01:00
Andreas Gebhardt
ed7cfedb51 Fix JavaDoc within spring-boot-test-support
See gh-17443
2019-07-08 12:48:02 +01:00
Andy Wilkinson
3ba25b9ee9 Simplify class loading check in pooled DataSource condition
Closes gh-17284
2019-07-08 12:19:55 +01:00
Andy Wilkinson
638b4b8186 Rename methods to make copying behaviour more clear
Closes gh-17441
2019-07-05 19:09:19 +01:00
Andy Wilkinson
dde79e5308 Merge pull request #17389 from sparty02
* gh-17389:
  Polish "Add config property for Kafka consumer isolation level"
  Add config property for Kafka consumer isolation level

Closes gh-17389
2019-07-05 19:00:19 +01:00
Andy Wilkinson
b39479bc07 Polish "Add config property for Kafka consumer isolation level"
See gh-17389
2019-07-05 17:23:45 +01:00
Ryan Dunckel
1b8f955fec Add config property for Kafka consumer isolation level
See gh-17389
2019-07-05 17:16:58 +01:00
Andy Wilkinson
0d124e9857 Remove use of field injection from spring-boot-devtools
Closes gh-17442
2019-07-05 14:59:01 +01:00
Andy Wilkinson
bd22ca0268 Polish 2019-07-04 19:36:32 +01:00
Andy Wilkinson
2816635418 Polish 2019-07-04 17:51:20 +01:00
Andy Wilkinson
4b2a116fa7 Use String indexOf(char) and lastIndexOf(char) where possible
Closes gh-11416
2019-07-04 17:44:40 +01:00
Andy Wilkinson
6a777a7f9b Disable HiddenHttpMethodFilter by default
HiddenHttpMethodFilter can be problematic as it causes early
consumption of a request body if the body may contain parameters. This
happens as the filter needs to read the parameters to see if an
_method parameter is present. The filter is only beneficial for web
applications that are the hidden HTTP method functionality but is
potentially detriimental to all applications that are not. As such
we no longer believe that it should be enabled by default and users
should be required to opt in.

Closes gh-16953
2019-07-04 14:50:01 +01:00
Andy Wilkinson
2af815f2cf Merge branch '2.1.x'
Closes gh-17432
2019-07-04 12:56:22 +01:00
Andy Wilkinson
7f85aba546 Auto-configure Data Mongo if user provides MongoDbFactory but no client
Previously, if a user defined a MongoDbFactory bean but did not define
a client bean, MongoDataAutoConfiguration would back off leaving the
context without a MongoTemplate, etc.

This commit reworks the auto-configuration so that only the
auto-configuration of a MongoDbFactory is dependent on the existence
of a Mongo client bean. Auto-configuration of the other components
that depend on a MongoDbFactory will now continue in the absence of a
Mongo client bean.

Closes gh-17416
2019-07-04 12:36:03 +01:00
Andy Wilkinson
2dfbf41bfa Merge pull request #17412 from dreis2211
* gh-17412:
  Polish "Use Spring 5 module of Jersey"
  Use Spring 5 module of Jersey

Closes gh-17412
2019-07-04 10:27:00 +01:00
Andy Wilkinson
345c36828f Polish "Use Spring 5 module of Jersey"
See gh-17412
2019-07-04 10:26:39 +01:00
dreis2211
7c6fd31d06 Use Spring 5 module of Jersey
See gh-17412
2019-07-04 10:26:28 +01:00
Andy Wilkinson
7d05551b9b Merge pull request #17411 from dreis2211
* gh-17411:
  Polish "Polish GradleCompatibilityExtension's javadoc"
  Polish GradleCompatibilityExtension's javadoc

Closes gh-17411
2019-07-04 10:18:44 +01:00
Andy Wilkinson
aa01bd3890 Polish "Polish GradleCompatibilityExtension's javadoc"
See gh-17411
2019-07-04 10:18:18 +01:00
dreis2211
dc4cc214fe Polish GradleCompatibilityExtension's javadoc
See gh-17411
2019-07-04 10:13:17 +01:00
Andy Wilkinson
9d5fa98334 Merge branch '2.1.x'
Closes gh-17429
2019-07-04 10:07:40 +01:00
Andy Wilkinson
7553b60e68 Test the Gradle Plugin against Gradle 5.5
Closes gh-17428
2019-07-04 10:05:57 +01:00
Phillip Webb
4483f41791 Don't validate using BeanPropertyBindingResult
Update `ValidationBindHandler` so that a custom `AbstractBindingResult`
is used rather than `BeanPropertyBindingResult`. This allows us to
validate results, regardless of whether the actual bound instance has
public getters or setter.

Closes gh-17424
2019-07-03 21:59:08 -07:00
Madhura Bhave
c19bed15d2 Merge pull request #17356 from htztomic
* pr/17356:
  Polish "Allow Undertow's options to be configured via the environment
  Allow Undertow's options to be configured via the environment

Closes gh-17356
2019-07-03 18:31:38 -07:00
Madhura Bhave
3bd7760f9c Polish "Allow Undertow's options to be configured via the environment
See gh-17356
2019-07-03 17:48:56 -07:00
HaiTao Zhang
417f4dd7fa Allow Undertow's options to be configured via the environment
See gh-17356
2019-07-03 17:20:31 -07:00
Madhura Bhave
f0e934e5ac Merge pull request #17418 from htztomic
* pr/17418:
  Polish "Provide links / when using a separate management port"
  Provide links for actuators at / when using a separate management port

Closes gh-17418
2019-07-03 16:19:52 -07:00
Madhura Bhave
39b15af5d6 Polish "Provide links / when using a separate management port"
See gh-17418
2019-07-03 16:19:40 -07:00
HaiTao Zhang
c108629311 Provide links for actuators at / when using a separate management port
See gh-17418
2019-07-03 16:19:40 -07:00
Phillip Webb
edea223841 Merge branch '2.1.x'
Closes gh-17422
2019-07-03 16:06:19 -07:00
Phillip Webb
2f88dd735e Polish 2019-07-03 15:52:51 -07:00
Phillip Webb
cd5f40aec2 Validate onFailure returned binding results
Update `ValidationBindHandler` so that any non-null result returned by
the parent `onFailure` method triggers re-validation.

Fixes gh-17421
2019-07-03 15:52:51 -07:00
Phillip Webb
d641a1e23a Polish BindHandler javaodc 2019-07-03 15:52:51 -07:00
Andy Wilkinson
e0048f234b Polish 2019-07-03 21:59:51 +01:00
Andy Wilkinson
c5cae28261 Add support for plain text thread dumps to the threaddump endpoint
When a request that accepts text/plain is received, the threaddump
endpoint will now return a thread dump in plain text. The format of
this text is modelled after the output produced by JVisualVM when
connecting to a remote process over JMX. Note that this output does
not include all of the information in, for example, JStack's output
as it is not available via Java 8's ThreadInfo API.

Rather than the custom formatting logic, using ThreadInfo's toString()
method was considered but its output is documented as being undefined
and implementation specific. The implementation used while developing
this feature produced output that did not match that of JStack or
JVisualVM and truncated stack traces quite considerably.

At the time of writing the format produced by the endpoint could be
consumed by both Thread Dump Analyzer [1] and https://fastthread.io.

Closes gh-2339

[1] https://github.com/irockel/tda
2019-07-03 21:51:56 +01:00
Phillip Webb
a66c4d3096 Unify method visibility of private classes
Apply checkstyle rule to ensure that private and package private
classes do not have unnecessary public methods. Test classes have
also been unified as much as possible to use default scoped
inner-classes.

Closes gh-7316
2019-07-03 11:39:47 -07:00
Madhura Bhave
0a02a3a19c Move Hibernate52 tests under smoke tests
Closes gh-17393
2019-07-02 16:06:06 -07:00
Madhura Bhave
d9466f5659 Move smoke tests under spring-boot-test
See gh-17393
2019-07-02 15:55:58 -07:00
Andy Wilkinson
40f66c80f8 Merge branch '2.1.x'
Closes gh-17409
2019-07-02 17:34:25 +01:00
Andy Wilkinson
82fd4ce9b9 Fix empty context path warning when using Jetty with WebFlux
Previously, the context path was set to an empty string. The led to
Jetty logging a warning about an empty context path and then using
/ instead.

This commit avoids the warning while leaving the context path's end
result unchanged by setting the context path to /.

Closes gh-17399
2019-07-02 17:24:34 +01:00
Andy Wilkinson
e5549f7a21 Stop Jersey from pulling in duplicate classes with JDK 11+
Closes gh-17404
2019-07-02 16:17:13 +01:00
Andy Wilkinson
73cf11535d Ensure that logging system tests do not leave log files open
See gh-17107
2019-07-02 16:03:30 +01:00
Andy Wilkinson
0b8247bd62 Merge branch '2.1.x'
Closes gh-17408
2019-07-02 14:11:23 +01:00
Andy Wilkinson
e57579461a Prevent endpoint's shutdown() method from being a destroy method
Closes gh-17407
2019-07-02 14:05:49 +01:00
Andy Wilkinson
0f6d0d1fb8 Upgrade to Sqlite Jdbc 3.28.0
Closes gh-17406
2019-07-02 13:50:15 +01:00
Andy Wilkinson
9d4ea49dbb Upgrade to Junit Jupiter 5.5.0
Closes gh-17405
2019-07-02 13:50:13 +01:00
Andy Wilkinson
c1313e481f Upgrade to Jersey 2.29
Closes gh-17404
2019-07-02 13:50:12 +01:00
Andy Wilkinson
bb499194c2 Upgrade to Log4j2 2.12.0
Closes gh-17403
2019-07-02 13:50:10 +01:00