Spring/spring-data-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polishing.

Browse Source 
A public bean method that returns a private type is unusual and prevents the processing of such bean in reflection-free use cases. There was also an unnecessary qualifier in the implementation.

Closes #2399
This commit is contained in:
Stephane Nicoll
2021-07-05 08:03:46 +02:00
committed by Mark Paluch
parent f0a7612112
commit 28a5bab49a
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/main/java/org/springframework/data/web/config/ProjectingArgumentResolverRegistrar.java
View File

@@ -54,7 +54,7 @@ public class ProjectingArgumentResolverRegistrar {
* @return * @return
*/ */
@Bean @Bean
public static ProjectingArgumentResolverBeanPostProcessor projectingArgumentResolverBeanPostProcessor( static ProjectingArgumentResolverBeanPostProcessor projectingArgumentResolverBeanPostProcessor(
@Qualifier("mvcConversionService") ObjectFactory<ConversionService> conversionService) { @Qualifier("mvcConversionService") ObjectFactory<ConversionService> conversionService) {
return new ProjectingArgumentResolverBeanPostProcessor(conversionService); return new ProjectingArgumentResolverBeanPostProcessor(conversionService);
} }
@@ -66,7 +66,7 @@ public class ProjectingArgumentResolverRegistrar {
* @author Oliver Gierke * @author Oliver Gierke
* @soundtrack Apparat With Soap & Skin - Goodbye (Dark Theme Song - https://www.youtube.com/watch?v=66VnOdk6oto) * @soundtrack Apparat With Soap & Skin - Goodbye (Dark Theme Song - https://www.youtube.com/watch?v=66VnOdk6oto)
*/ */
private static class ProjectingArgumentResolverBeanPostProcessor static class ProjectingArgumentResolverBeanPostProcessor
implements BeanPostProcessor, BeanFactoryAware, BeanClassLoaderAware { implements BeanPostProcessor, BeanFactoryAware, BeanClassLoaderAware {
private ProxyingHandlerMethodArgumentResolver resolver; private ProxyingHandlerMethodArgumentResolver resolver;
@@ -78,8 +78,7 @@ public class ProjectingArgumentResolverRegistrar {
* @param conversionService the Spring MVC {@link ConversionService} in a lazy fashion, so that its initialization * @param conversionService the Spring MVC {@link ConversionService} in a lazy fashion, so that its initialization
* is not triggered yet. * is not triggered yet.
*/ */
public ProjectingArgumentResolverBeanPostProcessor( ProjectingArgumentResolverBeanPostProcessor(ObjectFactory<ConversionService> conversionService) {
@Qualifier("mvcConversionService") ObjectFactory<ConversionService> conversionService) {
this.resolver = new ProxyingHandlerMethodArgumentResolver(conversionService, false); this.resolver = new ProxyingHandlerMethodArgumentResolver(conversionService, false);
} }