Spring/spring-data-commons
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve equals check by caching resolved generics.

Browse Source 
Closes: #2974
This commit is contained in:
Mark Paluch
2023-11-08 11:39:42 +01:00
committed by Christoph Strobl
parent 633d125f1d
commit 65c537cdaa
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/main/java/org/springframework/data/util/TypeDiscoverer.java
View File

@@ -60,6 +60,8 @@ class TypeDiscoverer<S> implements TypeInformation<S> {
private final Map<Constructor<?>, List<TypeInformation<?>>> constructorParameters = new ConcurrentHashMap<>();
private final Lazy<List<TypeInformation<?>>> typeArguments;
private final Lazy<List<Class>> resolvedGenerics;
protected TypeDiscoverer(ResolvableType type) {
Assert.notNull(type, "Type must not be null");
@@ -68,6 +70,8 @@ class TypeDiscoverer<S> implements TypeInformation<S> {
this.componentType = Lazy.of(this::doGetComponentType);
this.valueType = Lazy.of(this::doGetMapValueType);
this.typeArguments = Lazy.of(this::doGetTypeArguments);
this.resolvedGenerics = Lazy.of(() -> Arrays.stream(resolvableType.getGenerics()) //
.map(ResolvableType::toClass).collect(Collectors.toList()));
}
static TypeDiscoverer<?> td(ResolvableType type) {
@@ -325,15 +329,7 @@ class TypeDiscoverer<S> implements TypeInformation<S> {
return false;
}
var collect1 = Arrays.stream(resolvableType.getGenerics()) //
.map(ResolvableType::toClass) //
.collect(Collectors.toList());
var collect2 = Arrays.stream(that.resolvableType.getGenerics()) //
.map(ResolvableType::toClass) //
.collect(Collectors.toList());
return ObjectUtils.nullSafeEquals(collect1, collect2);
return ObjectUtils.nullSafeEquals(resolvedGenerics.get(), that.resolvedGenerics.get());
}
@Override