Commit Graph

419 Commits

Author SHA1 Message Date
Oliver Gierke
d7df08f6b7 DATACMNS-201 - Fixed critical FindBugs warnings. 2012-07-18 20:53:24 +02:00
Oliver Gierke
96795f2980 DATACMNS-47 - Add support for JavaConfig based repository configuration.
Completely rewrote namespace bean definition parsing to be extendable more easily. Separated XML concerns from annotation based configuration. The central point to extend the namespace parsing for a certain module is now hidden behind the RepositoryConfigurationExtension interface (have a look at the RepositoryConfigurationExtensionSupport base class as well).
2012-07-16 19:49:56 +02:00
Oliver Gierke
464c3f048b DATACMNS-187 - Added getRevisionDate() to Revision.
Revision now exposes the revision date of the underlying metadata.
2012-07-16 10:53:18 +02:00
Oliver Gierke
4d326faa25 DATACMNS-193 - Introduced isQueryMethod(…) on RepositoryInformation. 2012-07-16 10:02:44 +02:00
Oliver Gierke
4a51ce2b84 DATACMNS-189 - Fixed typo in reference documentation. 2012-07-11 12:46:53 +02:00
Oliver Gierke
d9f293be54 DATACMNS-188 - Removed obsolete method from AbstractMappingContext. 2012-07-09 09:18:24 +02:00
Oliver Gierke
ebf8fdcbc4 DATACMNS-186 - Improved the way id properties are detected.
The id properties are now discovered by the BasicPersistentEntity during the call to addPersistentProperty(…). Beyond that the method rejects the id property if one was already set.
2012-06-22 14:24:00 +02:00
Oliver Gierke
f540306774 DATACMNS-185 - Expose AbstractMappingContext initialization.
Added initialize() method to AbstractMpapingContext to ease manual initialization.
2012-06-22 14:04:22 +02:00
Oliver Gierke
d441d95197 DATACMNS-58 - Added support for repository populators.
Added RepositoryPopulator abstraction and implementations based on Spring OXM Unmarshallers as well as Jackson. This allows arbitrary repositories being populated with data pulled from XML / JSON, no matter what store they are actually backed. The populator will eventually populate the repositories held in a Repositories instance. It can be used like this:

Repositories repositories = new Repositories(applicationContext);
ResourceReader reader = new JacksonResourceReader();

ResourceReaderRepositoryPopulator populator = new ResourceReaderRepositoryPopulator(reader);
populator.setResourceLocation("classpath*:data.json");
populator.populate(repositories);

The ResourceReader defines what technology shall be used to read the data from the file into objects. The ResourceReaderRepositoryPopulator uses the reader and can either get a set of Resource instances configured or is able to lookup resources using a location string. The actual Repositories instance captures all CrudRepository instances contained inside an ApplicationContext.

The populators can also be used from within XML configuration though the repository namespace elements shown below:

<repository:jackson-populator location="classpath:org/springframework/data/repository/init/data.json" />
		
<repository:unmarshaller-populator location="classpath:org/springframework/data/repository/init/data.xml" unmarshaller-ref="unmarshaller" />

Updated reference documentation accordingly.
2012-06-21 20:03:55 +02:00
Oliver Gierke
149cfa068c DATACMNS-182 - Added test case showing query method parsing works as expected. 2012-06-08 12:11:30 +02:00
Oliver Gierke
031129e461 DATACMNS-180 - Don't consider Java transient fields transient for persistence.
So far we have considered Java transient fields as transient through the isTransient() method on PersistentProperty. This resulted in the properties not being persisted eventually. We now consider all fields as non-transient by default as we actually have to persist them as the object cannot be re-created completely without doing so as the usage of the transient keyword might rely on the readObject(…) method inside the object which would actually reconstitute the transient field's state but we of course cannot call this method actually.
2012-06-06 12:33:17 +02:00
Oliver Gierke
e5c6af6b24 DATACMNS-179 - Defer adding initial entity set to AbstractMappingContext.
So far the domain classes to be added to the mapping context initially were added in afterPropertiesSet() of InitializingBean. This had the drawback that although the MappingContext is already set up properly the actual listeners of the events fired (e.g. index creating ones) might not have been set up properly. We list to the ContextRefreshedEvent indicating the entire ApplicationContext being set up completely. Thus all infrastructure components are set up properly and the timing issues doesn't exist anymore.
2012-06-04 12:24:10 +02:00
Oliver Gierke
31926a6299 DATACMNS-178 - Fixed dependency scope for JUnit.
Reduced scope of junit-dep dependency from compile to test.
2012-05-29 12:27:47 +02:00
Oliver Gierke
f2989f5836 DATACMNS-177 - Changed OSGi bundle identifier to org.sfw.data.core. 2012-05-23 18:13:14 +02:00
Oliver Gierke
4863609416 DATACMNS-175 - Execute Javadoc plugin before assembly. 2012-05-21 14:16:37 +02:00
Oliver Gierke
1a24145ef9 DATACMNS-174 - Part.Type now exposes keywords. 2012-05-21 14:15:00 +02:00
Oliver Gierke
169bdfefaa DATACMNS-173 - Upgraded Maven Compiler and Surefire plugins.
Upgraded Surefire plugin to 2.12. Upgraded JUnit dependency to 4.10. Upgraded compiler plugin to 2.4.
2012-05-21 14:06:50 +02:00
Oliver Gierke
a7688b684c DATACMNS-172 - Improved handling of invalid PropertyPaths.
Introduced PropertyReferenceException to capture the invalid property and the base PropertyPath a property expression could be resolved into. Introduced getLeafProperty() to be able to access the leaf property of a property path being created.
2012-05-21 13:58:29 +02:00
Spring Buildmaster
b1d7e8927c DATACMNS-149 - Next development version. 2012-05-16 19:28:23 +02:00
Spring Buildmaster
9f48059bb5 DATACMNS-149 - Release version 1.3.0.RELEASE. 2012-05-16 10:15:47 -07:00
Oliver Gierke
ec87165c30 DATACMNS-149 - Updated changelog and pom.xml.
Fixed pom.xml to match requirements of Maven central.
2012-05-16 19:05:05 +02:00
Oliver Gierke
cee108d6e9 DATACMNS-149 - Polished repositories reference documentation. 2012-05-16 16:24:31 +02:00
Oliver Gierke
7673567a8c DATACMNS-171 - Added isQueryForEntity() method to QueryMethod.
isQueryForEntity() returns true if the QueryMethod returns either a single entity, a collection or Page of those.
2012-05-16 14:27:53 +02:00
Oliver Gierke
f4c3c786b7 Expose Bundlor's failOnWarnings to allow disabling for Sonar build. 2012-05-11 22:00:46 +02:00
Oliver Gierke
0f7231ec01 DATACMNS-170 - Fixed potential NullPointerException in ReflectionEntityInstantiator.
Moved null-check before the attempt to make the discovered id field accessible.
2012-05-07 12:53:54 +02:00
Oliver Gierke
b8c2e625b3 Polished pom.xml.
Removed obsolete stuff as we're now deploying to Artifactory.
2012-05-07 09:46:26 +02:00
Oliver Gierke
e20938a3ae DATAMONGO-439 - Performance improvements in mapping subsystem.
Fixed minor performance problems discovered by the fix for DATAMONGO-439. We're now caching the information whether a constructor parameter is an enclosing class parameter. PersistentEntityParameterValueProvider is throwing an exception now if the parameter is not referring to a property of the entity (via the parameter name).
2012-05-03 17:25:51 +02:00
Spring Buildmaster
f67f9eb4c9 Prepare 1.3.0.BUILD-SNAPSHOT development. 2012-05-02 12:01:50 -07:00
Spring Buildmaster
a1a60f39f4 [artifactory-release] Release version 1.3.0.BUILD 2012-05-02 12:01:48 -07:00
Oliver Gierke
100d5b3953 DATACMNS-165 - Updated changelog for 1.3.0.RC2 release. 2012-05-02 20:57:14 +02:00
Oliver Gierke
aec655a499 DATACMNS-167 - Improved Iterable handling in TypeDiscoverer.
If a type implemented Iterable<…> it was currently treated as a collection which might cause inappropriate conversion in the mapping sub-system. We now consider types collection like if they're either Iterable directly or assignable to Collection.
2012-05-02 20:55:30 +02:00
Oliver Gierke
5b0cb1a572 DATACMNS-166 - Improved API in Repositories / RepositoryFactoryInformation.
Renamed methods in RepositoryMetadata to be consistent with EntityMetadata. Changed return type of RepositoryMetadata.getIdType() to Class<? extends Serializable>. Changed RepositoryFactoryInformation interface to expose RepositoryInformation rather than just the repository interface. Added exposing the QueryMethod instances as well. Adapter Repositories wrapper and it's clients accordingly.
2012-05-02 19:49:11 +02:00
Oliver Gierke
7f6c03d36a DATACMNS-143 - Removed deprecations in MappingContextEvent. 2012-04-27 19:10:24 +02:00
Karl Bennett
a0bec0fce0 DATACMNS-159 - Improve reference documentation on repository extensions.
Updated section covering adding custom behavior to all repositories to better match what is in the actual code base.
2012-04-27 15:55:23 +02:00
Oliver Gierke
6a461c0a51 DATACMNS-161 - Upgrade to Querydsl 2.5.0.
Polished pom.xml a little.
2012-04-27 09:39:16 +02:00
Oliver Gierke
8448573c3e DATACMNS-158 - Test case failing to reproduce the ticket.
Added test case to show that invalid properties containing numeric digits do not cause a stack overflow.
2012-04-23 18:04:38 +02:00
Oliver Gierke
ddea8eda8f DATACMNS-157 - Query method lookup now only returns most specific method for overridden methods.
Supposed you have a base repository interface declaring a method:

interface BaseRepository<T, ID extends Serializable> extends Repository<T, ID> {

  T myGenericMethod();
}

as well as a concrete repository redeclaring this method to annotate a query on it:

interface ConcreteRepository extends BaseRepository<User, Long> {

  @Query("…")
  User myGenericMethod()
}

Until now we both returned the intermediate method as well as the concrete one which might cause failures as in this case a query derivation would be attempted for the intermediate method which will fail for obvious reasons. The fix now starts with looking up the most specific method when iterating over the repository's methods which causes the intermediate method to be skipped in case it was overridden.
2012-04-20 13:55:49 +02:00
Oliver Gierke
06dc1e5dba DATACMNS-156 - Removed deprecated persistence package. 2012-04-20 13:20:14 +02:00
Oliver Gierke
ecf3592d1f DATACMNS-153 - Fixed class loading issue in SimpleEntityPathResolver.
The path class is loaded using the domain class' class loader instead of the one of SimpleEntityPathResolver.
2012-04-20 13:01:10 +02:00
Oliver Gierke
f1516a96aa DATACMNS-154 - Fixed query method detection when re-declararing CrudRepositoryMethods.
With the fix for DATACMNS-151 we apparently broke the generic parameter type matching for methods that carry the domain class type parameter as argument. We now inspect the bound and make sure we compare the name of it if it's a TypeVariable or use the plain parameter type if its not.
2012-04-19 12:45:33 +02:00
Spring Buildmaster
91eef0e8a5 DATACMNS-148 - Next development version. 2012-04-16 11:55:00 +02:00
Spring Buildmaster
703b285962 Release version 1.3.0.RC1. 2012-04-16 11:54:50 +02:00
Oliver Gierke
5fe65bb28d DATACMNS-148 - Prepare 1.3.0.RC1 release.
Adapted changelog.
2012-04-16 09:23:40 +02:00
Oliver Gierke
3196f3b0f5 DATAJPA-153 - Fixed typo in reference documentation. 2012-04-15 19:43:47 +02:00
Oliver Gierke
81718ae373 DATACMNS-152 - Improved API in mapping subsystem.
PersistentProperty now exposes isEntity(). Mapping context now allows accessing a PersistentEntity referred to from a PersistentProperty. JavaDoc cleanups in MappingContext interface.
2012-04-14 13:27:50 +02:00
Oliver Gierke
67c8c53f5e DATACMNS-151 - Improve CrudRepository method signature generics.
Method signatures of save(…) methods in CrudRepository now return the concrete type passed in. This way subtypes can be persisted without casting the result back.

class Contact { … }
class Person extends Contact { … }

interface ContactRepository extends CrudRepository<Contact, Long> { … }

Before:

Person person = new Person();
person = (Person) repo.save(person);
         ^^^^^^^^

Now:

Person person = new Person();
person = repo.save(person);
2012-04-13 22:32:16 +02:00
Oliver Gierke
c158442dc7 DATACMNS-150 - Fixed potential ClassCastException in DomainClassConverter and -PropertyEditorRegistrar.
Introduced Repositories value object to easily access repository instances and EntityInformation objects registered in an ApplicationContext.
2012-04-13 21:18:07 +02:00
Oliver Gierke
aa12db22c0 DATACMNS-121 - Implement equals(…) and hashCode() of AbstractPersistentProperty.
Implemented equals(…) and hashCode() methods based on the field backing the property.
2012-04-11 21:00:03 +02:00
Oliver Gierke
f3d037ba7d DATACMNS-139 - Fixed potential StackOverflowException in PropertyPath.
When trying to access an inexistent property starting with an underscore (e.g. _id) PropertyPath.create(…) ran into a StackOverflowException. Changed the traversing regular expression to expect at least one capital letter for further traversals.
2012-04-11 18:18:58 +02:00
Oliver Gierke
109e7f903e DATACMNS-132 - Guard against untyped Maps and Collections in AbstractPersistentProperty.isEntity().
Just mentioned method threw a NullPointerException when the property was backed by an untyped Map or Collection as TypeInformation.getActualType() returns null in this case. Changed that to correctly return false.
2012-04-11 18:18:57 +02:00