Spring/spring-data-envers
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#146 - Avoid executing IN-query with empty parameter list.

Browse Source 
These queries are illegal in Postgres and possible other databases.

Original pull request: #147.
This commit is contained in:
Julien Millau
2018-11-13 01:35:13 +01:00
committed by Jens Schauder
parent eadb5e3cf0
commit 0a43667eb3
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/java/org/springframework/data/envers/repository/support/EnversRevisionRepositoryImpl.java
View File

@@ -52,6 +52,7 @@ import org.springframework.util.Assert;
* @author Philipp Huegelmeyer
* @author Michael Igler
* @author Jens Schauder
* @author Julien Millau
*/
public class EnversRevisionRepositoryImpl<T, ID, N extends Number & Comparable<N>> extends SimpleJpaRepository<T, ID>
implements RevisionRepository<T, ID, N> {
@@ -151,8 +152,8 @@ public class EnversRevisionRepositoryImpl<T, ID, N extends Number & Comparable<N
Collections.reverse(revisionNumbers);
}
if (pageable.getOffset() > revisionNumbers.size()) {
return new PageImpl<Revision<N, T>>(Collections.<Revision<N, T>> emptyList(), pageable, 0);
if (revisionNumbers.isEmpty() || pageable.getOffset() > revisionNumbers.size()) {
return Page.empty(pageable);
}
long upperBound = pageable.getOffset() + pageable.getPageSize();