Spring/spring-data-jpa
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAJPA-1171 - CrudRepository.exists(…) does no longer contain a 1 = 1 clause in query.

Browse Source 
Changed the query generating code to use streams and joiner which made it simpler and the use of 1 = 1 superfluous.

Original pull request: #212.
This commit is contained in:
Jens Schauder
2017-09-04 09:48:25 +02:00
committed by Oliver Gierke
parent f8f6daeffb
commit 18c4f32f9d
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/main/java/org/springframework/data/jpa/repository/query/QueryUtils.java
View File

@@ -32,6 +32,7 @@ import java.util.Map;
import java.util.Set;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.stream.Collectors;
import javax.persistence.EntityManager;
import javax.persistence.ManyToOne;
@@ -57,6 +58,7 @@ import org.springframework.data.domain.Sort;
import org.springframework.data.domain.Sort.Order;
import org.springframework.data.jpa.domain.JpaSort.JpaOrder;
import org.springframework.data.mapping.PropertyPath;
import org.springframework.data.util.StreamUtils;
import org.springframework.lang.Nullable;
import org.springframework.util.Assert;
import org.springframework.util.StringUtils;
@@ -183,16 +185,13 @@ public abstract class QueryUtils {
public static String getExistsQueryString(String entityName, String countQueryPlaceHolder,
Iterable<String> idAttributes) {
StringBuilder sb = new StringBuilder(String.format(COUNT_QUERY_STRING, countQueryPlaceHolder, entityName));
sb.append(" WHERE ");
String baseQuery = String.format(COUNT_QUERY_STRING, countQueryPlaceHolder, entityName);
for (String idAttribute : idAttributes) {
sb.append(String.format(EQUALS_CONDITION_STRING, "x", idAttribute, idAttribute));
sb.append(" AND ");
}
String whereClause = StreamUtils.createStreamFromIterator(idAttributes.iterator())
.map(idAttribute -> String.format(EQUALS_CONDITION_STRING, "x", idAttribute, idAttribute))
.collect(Collectors.joining(" AND ", " WHERE ", ""));
sb.append("1 = 1");
return sb.toString();
return baseQuery + whereClause;
}
/**