Spring/spring-data-jpa
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary parameter.

Browse Source 
Remove unnecessary boolean nativeQuery from checkHasNamedParameter of StringQueryUnitTests class.

Signed-off-by: hgh1472 <hgh1472@naver.com>

Closes #3827
Original pull request: #3828
This commit is contained in:
hgh1472
2025-04-05 00:10:44 +09:00
committed by Mark Paluch
parent a62996f2bb
commit 329c5f9eed
1 changed files with 27 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/StringQueryUnitTests.java
View File

@@ -42,6 +42,7 @@ import org.springframework.data.repository.query.parser.Part.Type;
* @author Diego Krupitza
* @author Mark Paluch
* @author Aleksei Elin
* @author Gunha Hwang
*/
class StringQueryUnitTests {
@@ -735,32 +736,32 @@ class StringQueryUnitTests {
@Test // DATAJPA-1200
void testHasNamedParameter() {
checkHasNamedParameter("select something from x where id = :id", true, "named parameter", true);
checkHasNamedParameter("in the :id middle", true, "middle", false);
checkHasNamedParameter(":id start", true, "beginning", false);
checkHasNamedParameter(":id", true, "alone", false);
checkHasNamedParameter("select something from x where id = :id", true, "named parameter", true);
checkHasNamedParameter(":UPPERCASE", true, "uppercase", false);
checkHasNamedParameter(":lowercase", true, "lowercase", false);
checkHasNamedParameter(":2something", true, "beginning digit", false);
checkHasNamedParameter(":2", true, "only digit", false);
checkHasNamedParameter(":.something", true, "dot", false);
checkHasNamedParameter(":_something", true, "underscore", false);
checkHasNamedParameter(":$something", true, "dollar", false);
checkHasNamedParameter(":\uFE0F", true, "non basic latin emoji", false); //
checkHasNamedParameter(":\u4E01", true, "chinese japanese korean", false);
checkHasNamedParameter("select something from x where id = :id", true, "named parameter");
checkHasNamedParameter("in the :id middle", true, "middle");
checkHasNamedParameter(":id start", true, "beginning");
checkHasNamedParameter(":id", true, "alone");
checkHasNamedParameter("select something from x where id = :id", true, "named parameter");
checkHasNamedParameter(":UPPERCASE", true, "uppercase");
checkHasNamedParameter(":lowercase", true, "lowercase");
checkHasNamedParameter(":2something", true, "beginning digit");
checkHasNamedParameter(":2", true, "only digit");
checkHasNamedParameter(":.something", true, "dot");
checkHasNamedParameter(":_something", true, "underscore");
checkHasNamedParameter(":$something", true, "dollar");
checkHasNamedParameter(":\uFE0F", true, "non basic latin emoji"); //
checkHasNamedParameter(":\u4E01", true, "chinese japanese korean");
checkHasNamedParameter("no bind variable", false, "no bind variable", false);
checkHasNamedParameter(":\u2004whitespace", false, "non basic latin whitespace", false);
checkHasNamedParameter("select something from x where id = ?1", false, "indexed parameter", true);
checkHasNamedParameter("::", false, "double colon", false);
checkHasNamedParameter(":", false, "end of query", false);
checkHasNamedParameter(":\u0003", false, "non-printable", false);
checkHasNamedParameter(":*", false, "basic latin emoji", false);
checkHasNamedParameter("\\:", false, "escaped colon", false);
checkHasNamedParameter("::id", false, "double colon with identifier", false);
checkHasNamedParameter("\\:id", false, "escaped colon with identifier", false);
checkHasNamedParameter("select something from x where id = #something", false, "hash", true);
checkHasNamedParameter("no bind variable", false, "no bind variable");
checkHasNamedParameter(":\u2004whitespace", false, "non basic latin whitespace");
checkHasNamedParameter("select something from x where id = ?1", false, "indexed parameter");
checkHasNamedParameter("::", false, "double colon");
checkHasNamedParameter(":", false, "end of query");
checkHasNamedParameter(":\u0003", false, "non-printable");
checkHasNamedParameter(":*", false, "basic latin emoji");
checkHasNamedParameter("\\:", false, "escaped colon");
checkHasNamedParameter("::id", false, "double colon with identifier");
checkHasNamedParameter("\\:id", false, "escaped colon with identifier");
checkHasNamedParameter("select something from x where id = #something", false, "hash");
}
@Test // DATAJPA-1235
@@ -921,7 +922,7 @@ class StringQueryUnitTests {
.hasSize(expectedSize);
}
private void checkHasNamedParameter(String query, boolean expected, String label, boolean nativeQuery) {
private void checkHasNamedParameter(String query, boolean expected, String label) {
List<ParameterBinding> bindings = new ArrayList<>();
StringQuery.ParameterBindingParser.INSTANCE.parseParameterBindingsOfQueryIntoBindingsAndReturnCleanedQuery(query,