Spring/spring-data-jpa
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polishing.

Browse Source 
Move warning suppression to the class-level.

See #3901
This commit is contained in:
Mark Paluch
2025-06-04 14:43:54 +02:00
parent 1dcf910622
commit 52a5e317a7
5 changed files with 6 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spring-data-jpa/src/test/java/org/springframework/data/jpa/convert/threeten/Jsr310JpaConvertersUnitTests.java
View File

@@ -17,10 +17,10 @@ package org.springframework.data.jpa.convert.threeten;
import static org.assertj.core.api.Assertions.*;
import java.util.Arrays;
import jakarta.persistence.AttributeConverter;
import java.util.Arrays;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
@@ -40,7 +40,6 @@ class Jsr310JpaConvertersUnitTests {
new Jsr310JpaConverters.ZoneIdConverter());
}
@ParameterizedTest
@MethodSource("data")
void convertersHandleNullValuesCorrectly(AttributeConverter<?, ?> converter) {

4
spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/DeleteSpecificationUnitTests.java
View File

@@ -39,7 +39,7 @@ import org.mockito.quality.Strictness;
*
* @author Mark Paluch
*/
@SuppressWarnings("serial")
@SuppressWarnings({ "unchecked", "deprecation" })
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
class DeleteSpecificationUnitTests implements Serializable {
@@ -109,7 +109,6 @@ class DeleteSpecificationUnitTests implements Serializable {
assertThat(specification).isNotNull();
@SuppressWarnings({"unchecked", "deprecation"})
DeleteSpecification<Object> transferredSpecification = (DeleteSpecification<Object>) deserialize(
serialize(specification));
@@ -125,7 +124,6 @@ class DeleteSpecificationUnitTests implements Serializable {
assertThat(specification).isNotNull();
@SuppressWarnings({"unchecked", "deprecation"})
DeleteSpecification<Object> transferredSpecification = (DeleteSpecification<Object>) deserialize(
serialize(specification));

4
spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/PredicateSpecificationUnitTests.java
View File

@@ -38,7 +38,7 @@ import org.mockito.quality.Strictness;
*
* @author Mark Paluch
*/
@SuppressWarnings("serial")
@SuppressWarnings({ "unchecked", "deprecation" })
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
class PredicateSpecificationUnitTests implements Serializable {
@@ -107,7 +107,6 @@ class PredicateSpecificationUnitTests implements Serializable {
assertThat(specification).isNotNull();
@SuppressWarnings({"unchecked", "deprecation"})
PredicateSpecification<Object> transferredSpecification = (PredicateSpecification<Object>) deserialize(
serialize(specification));
@@ -123,7 +122,6 @@ class PredicateSpecificationUnitTests implements Serializable {
assertThat(specification).isNotNull();
@SuppressWarnings({"unchecked", "deprecation"})
PredicateSpecification<Object> transferredSpecification = (PredicateSpecification<Object>) deserialize(
serialize(specification));

14
spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/SpecificationUnitTests.java
View File

@@ -26,7 +26,6 @@ import jakarta.persistence.criteria.Root;
import java.io.Serializable;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
@@ -44,24 +43,16 @@ import org.mockito.quality.Strictness;
* @author Mark Paluch
* @author Daniel Shuy
*/
@SuppressWarnings("removal")
@SuppressWarnings({ "unchecked", "deprecation" })
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
class SpecificationUnitTests {
private Specification<Object> spec;
@Mock(serializable = true) Root<Object> root;
@Mock(serializable = true) CriteriaQuery<?> query;
@Mock(serializable = true) CriteriaBuilder builder;
@Mock(serializable = true) Predicate predicate;
@BeforeEach
void setUp() {
spec = (root, query, cb) -> predicate;
}
@Test // GH-1943
void emptyAllOfReturnsEmptySpecification() {
@@ -88,7 +79,6 @@ class SpecificationUnitTests {
assertThat(specification).isNotNull();
@SuppressWarnings({ "unchecked", "deprecation"})
Specification<Object> transferredSpecification = (Specification<Object>) deserialize(serialize(specification));
assertThat(transferredSpecification).isNotNull();
@@ -103,7 +93,6 @@ class SpecificationUnitTests {
assertThat(specification).isNotNull();
@SuppressWarnings({ "unchecked", "deprecation"})
Specification<Object> transferredSpecification = (Specification<Object>) deserialize(serialize(specification));
assertThat(transferredSpecification).isNotNull();
@@ -116,7 +105,6 @@ class SpecificationUnitTests {
Predicate secondPredicate = mock(Predicate.class);
Specification<Object> first = ((root1, query1, criteriaBuilder) -> firstPredicate);
Specification<Object> second = ((root1, query1, criteriaBuilder) -> secondPredicate);
first.and(second).toPredicate(root, query, builder);

4
spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/UpdateSpecificationUnitTests.java
View File

@@ -39,7 +39,7 @@ import org.mockito.quality.Strictness;
*
* @author Mark Paluch
*/
@SuppressWarnings("serial")
@SuppressWarnings({ "unchecked", "deprecation" })
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
class UpdateSpecificationUnitTests implements Serializable {
@@ -109,7 +109,6 @@ class UpdateSpecificationUnitTests implements Serializable {
assertThat(specification).isNotNull();
@SuppressWarnings({"unchecked", "deprecation"})
UpdateSpecification<Object> transferredSpecification = (UpdateSpecification<Object>) deserialize(
serialize(specification));
@@ -125,7 +124,6 @@ class UpdateSpecificationUnitTests implements Serializable {
assertThat(specification).isNotNull();
@SuppressWarnings({"unchecked", "deprecation"})
UpdateSpecification<Object> transferredSpecification = (UpdateSpecification<Object>) deserialize(
serialize(specification));