Spring/spring-data-jpa
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAJPA-1238 - Polishing.

Browse Source 
Formatting and Javadoc.

Original pull request: #270.
This commit is contained in:
Jens Schauder
2018-06-11 14:36:19 +02:00
parent 73b5898d72
commit d10c2022b6
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/main/java/org/springframework/data/jpa/repository/query/QueryUtils.java
View File

@@ -583,16 +583,17 @@ public abstract class QueryUtils {
/**
* Returns whether the given {@code propertyPathModel} requires the creation of a join. This is the case if we find a
* non-optional association.
* optional association.
*
* @param propertyPathModel must not be {@literal null}.
* @param forPluralAttribute
* @param forLeafProperty
* @return
* @param isPluralAttribute is the attribute of Collection type?
* @param isLeafProperty is this the final property navigated by a {@link PropertyPath}?
* @return wether an outer join is to be used for integrating this attribute in a query.
*/
private static boolean requiresJoin(Bindable<?> propertyPathModel, boolean forPluralAttribute, boolean forLeafProperty) {
private static boolean requiresJoin(Bindable<?> propertyPathModel, boolean isPluralAttribute,
boolean isLeafProperty) {
if (propertyPathModel == null && forPluralAttribute) {
if (propertyPathModel == null && isPluralAttribute) {
return true;
}
@@ -605,7 +606,8 @@ public abstract class QueryUtils {
if (!ASSOCIATION_TYPES.containsKey(attribute.getPersistentAttributeType())) {
return false;
}
if (forLeafProperty && !attribute.isCollection()) {
if (isLeafProperty && !attribute.isCollection()) {
return false;
}