Spring/spring-data-jpa
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAJPA-1405 - Ignore EclipseLink tests with empty collections for version 2.7.2+.

Browse Source 
Original pull request: #290.
This commit is contained in:
Jens Schauder
2018-08-17 12:17:57 +02:00
committed by Oliver Gierke
parent d47687c097
commit e1bf98e451
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/test/java/org/springframework/data/jpa/repository/EclipseLinkNamespaceUserRepositoryTests.java
View File

@@ -15,15 +15,20 @@
*/
package org.springframework.data.jpa.repository;
import static java.util.Arrays.*;
import static org.assertj.core.api.Assertions.*;
import static org.eclipse.persistence.Version.*;
import java.util.HashSet;
import java.util.Set;
import javax.persistence.Query;
import org.eclipse.persistence.Version;
import org.junit.Assume;
import org.junit.Ignore;
import org.junit.Test;
import org.springframework.data.jpa.repository.sample.UserRepository;
import org.springframework.data.util.Version;
import org.springframework.test.context.ContextConfiguration;
/**
@@ -36,6 +41,8 @@ import org.springframework.test.context.ContextConfiguration;
@ContextConfiguration(value = "classpath:eclipselink.xml")
public class EclipseLinkNamespaceUserRepositoryTests extends NamespaceUserRepositoryTests {
public static final Set<String> BROKEN_ECLIPSE_VERSIONS = new HashSet<String>(asList("2.7.2", "2.7.3", "2.7.4"));
/**
* Ignored until https://bugs.eclipse.org/bugs/show_bug.cgi?id=349477 is resolved.
*/
@@ -129,7 +136,7 @@ public class EclipseLinkNamespaceUserRepositoryTests extends NamespaceUserReposi
@Test // DATAJPA-1314
public void findByEmptyArrayOfIntegers() throws Exception {
assumeNotEclipseLink2_7_2();
assumeNotEclipseLink2_7_2plus();
super.findByEmptyArrayOfIntegers();
}
@@ -142,7 +149,7 @@ public class EclipseLinkNamespaceUserRepositoryTests extends NamespaceUserReposi
@Test // DATAJPA-1314
public void findByAgeWithEmptyArrayOfIntegersOrFirstName() {
assumeNotEclipseLink2_7_2();
assumeNotEclipseLink2_7_2plus();
super.findByAgeWithEmptyArrayOfIntegersOrFirstName();
}
@@ -155,7 +162,7 @@ public class EclipseLinkNamespaceUserRepositoryTests extends NamespaceUserReposi
@Test // DATAJPA-1314
public void findByEmptyCollectionOfIntegers() throws Exception {
assumeNotEclipseLink2_7_2();
assumeNotEclipseLink2_7_2plus();
super.findByEmptyCollectionOfIntegers();
}
@@ -168,14 +175,14 @@ public class EclipseLinkNamespaceUserRepositoryTests extends NamespaceUserReposi
@Test // DATAJPA-1314
public void findByEmptyCollectionOfStrings() throws Exception {
assumeNotEclipseLink2_7_2();
assumeNotEclipseLink2_7_2plus();
super.findByEmptyCollectionOfStrings();
}
private void assumeNotEclipseLink2_7_2() {
private void assumeNotEclipseLink2_7_2plus() {
Assume.assumeFalse("Empty collections seem to be broken in EclipseLink 2.7.2",
Version.getVersion().equals("2.7.2"));
Assume.assumeFalse("Empty collections seem to be broken in EclipseLink 2.7.2+",
Version.parse(getVersion()).isGreaterThanOrEqualTo(new Version(2, 7, 2)));
}
}