Spring/spring-data-jpa
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polishing.

Browse Source 
Replace Collection.class.isInstance with instanceof for type checking. Remove unnecessary type check for ConfigurableListableBeanFactory in postProcessBeanFactory method.

Closes #3580
This commit is contained in:
Seol_JY
2024-08-14 14:06:40 +09:00
committed by Mark Paluch
parent 3483e16657
commit f7aed2a333
3 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/config/JpaRepositoryConfigExtension.java
View File

@@ -195,7 +195,7 @@ public class JpaRepositoryConfigExtension extends RepositoryConfigurationExtensi
registerIfNotAlreadyRegistered(() -> {
Object value = AnnotationRepositoryConfigurationSource.class.isInstance(config) //
Object value = config instanceof AnnotationRepositoryConfigurationSource //
? config.getRequiredAttribute(ESCAPE_CHARACTER_PROPERTY, Character.class) //
: config.getAttribute(ESCAPE_CHARACTER_PROPERTY).orElse("\\");

8
spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/support/EntityManagerBeanDefinitionRegistrarPostProcessor.java
View File

@@ -55,13 +55,7 @@ public class EntityManagerBeanDefinitionRegistrarPostProcessor implements BeanFa
@Override
public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory) throws BeansException {
if (!ConfigurableListableBeanFactory.class.isInstance(beanFactory)) {
return;
}
ConfigurableListableBeanFactory factory = beanFactory;
for (EntityManagerFactoryBeanDefinition definition : getEntityManagerFactoryBeanDefinitions(factory)) {
for (EntityManagerFactoryBeanDefinition definition : getEntityManagerFactoryBeanDefinitions(beanFactory)) {
BeanFactory definitionFactory = definition.getBeanFactory();

2
spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/support/SimpleJpaRepository.java
View File

@@ -247,7 +247,7 @@ public class SimpleJpaRepository<T, ID> implements JpaRepositoryImplementation<T
* Some JPA providers require {@code ids} to be a {@link Collection} so we must convert if it's not already.
*/
if (Collection.class.isInstance(ids)) {
if (ids instanceof Collection) {
query.setParameter("ids", ids);
} else {
Collection<ID> idsCollection = StreamSupport.stream(ids.spliterator(), false)