Commit Graph

449 Commits

Author SHA1 Message Date
Oliver Gierke
4b7d5d37b6 Added Datanucleus tests. 2014-03-13 10:13:25 +01:00
Oliver Gierke
5438c44c8f DATAJPA-173 - Extended support for metadata detection on CRUD methods.
Extended the mechanism previously existing to detect @Lock annotations on redeclared CRUD methods into one being able to transport arbitrary metadata into the execution of CRUD methods.

Renamed LockModeRepositoryPostProcessor to CrudMethodMetadataPostProcessor, refactored the internals and added some metadata caching to avoid repeated reflection lookups to evaluate annotations.
2014-03-12 15:30:46 +01:00
Thomas Darimont
79b5330928 DATAJPA-491 - Support order by arbitrarily nested association paths with Querydsl.
Replaced custom left join generation logic with default Querydsl mechanisms including support for ordering by arbitrarily nested property paths. Added test cases that demonstrate ordering by nested association paths (>= 2 levels). Added additional test cases for sort by nested property path expressions based on querydsl meta model and plain string based path expressions.

Original pull request: #65.
2014-03-12 11:12:52 +01:00
Martin Baumgartner
512a78ea72 DATAJPA-494 - Fix template.mf to make sure auditing can be used on OSGi.
template.mf now contains an explicit Import-Package directive to make sure the relevant packages for the auditing functionality can be resolved in an OSGi environment. This hadn't been the case before as we don't explicitly refer to some classes necessary (mostly to prevent class loading errors in IDEs). The explicit declarations make sure the relevant Import-Package declarations are added even if Bundlor doesn't find any types that would explicitly require the imports.

JpaAuditingRegistrar now also explicitly hints to the class not being visible in case of auditing setup errors.

Original pull request: #62.
2014-03-11 12:47:14 +01:00
Thomas Darimont
d868d0bf8a DATAJPA-485 - Upgraded hibernate-jpamodelgen to 1.3.0.Final. 2014-03-10 12:17:32 +01:00
Oliver Gierke
d42a929d03 DATAJPA-493 - Upgraded to OpenJPA 2.3.0.
Upgraded to OpenJPA 2.3.0 and enabled test cases previously ignored because of bugs in previous versions.
2014-03-07 19:16:47 +01:00
Oliver Gierke
118245ebd4 DATAJPA-492 - Altered implementation of findAll(Iterable<ID>) to work around bug in OpenJPA.
Changed the implementation of SimpleJpaRepository.findAll(Iterable<ID>) as OpenJPA still doesn't correctly bind in-clauses by name. This has been originally reported in [0] and marked fixed for 2.3.0 but even an upgrade to this version (coming in a subsequent commit) requires the workaround.

[0] https://issues.apache.org/jira/browse/OPENJPA-2018
2014-03-07 18:41:10 +01:00
Oliver Gierke
dcc8ad7b73 DATACMNS-452 - Use DirectFieldAccessFallbackBeanWrapper from Spring Data Commons. 2014-03-06 19:31:17 +01:00
Thomas Darimont
f5718e608c DATAJPA-464 - Add support for returning subtypes of Repository Entity in JpaRepository.saveAndFlush.
Adopted generic method declaration from save method to saveAndFlush.

Original pull request: #58.
2014-03-06 17:33:32 +01:00
Thomas Darimont
5f89cfd430 DATAJPA-472 - Verify that pagination works with entities with @IdClass.
This works as expected with 3.6.10, 4.2.10, 4.3.4 but fails with  4.1.12.

Added test case to verify and track the issue with Hibernate 4.1.x. Renamed test-class from DataJpa269RepositoryWithCompositeKeyTests to RepositoryWithCompositeKeyTests.

Original pull request: #61.
2014-03-06 17:25:12 +01:00
Oliver Gierke
ee4c498134 DATAJPA-489 - Adapted API changes in RepositoryProxyPostProcessor. 2014-03-06 16:56:13 +01:00
Oliver Gierke
1f8487e77e DATAJPA-487 - Adapted to API changes in auditing configuration. 2014-03-06 10:31:06 +01:00
Oliver Gierke
c8ca0f80c4 DATAJPA-486 - Added support for sliced query execution.
Added support for Slice as return type for query methods. The execution will expand the requested page size by one to read one more element than actually requested. If that additional element is returned, it will considered to be an indicator for whether a next slice is available.

Related issues: DATACMNS-397.
2014-03-06 10:30:57 +01:00
Oliver Gierke
55735fb27b DATAJPA-485 - Upgraded to Hibernate profiles to 4.3.4 and 4.2.10. 2014-03-04 11:22:52 +01:00
Oliver Gierke
8a1b4365a2 DATAJPA-476 - Mitigate spec violations in Hibernate for query creation.
Hibernate invalidly returns null for getModel() on its PluralAttribute implementation which causes the necessity for joins not having been detected previously.

We now fall back to joining in case we don't find a Model and deal with a PluralAttribute.
2014-03-04 11:20:48 +01:00
Oliver Gierke
bc9ee616ef DATAJPA-484 - Improved registration of JpaMetamodelMappingContext.
Instead of creating an individual instance of JpaMetamodelMappingContext per repository we now register a unique instance with access to the metamodel of the EntityManager the repositories use under "jpaMappingContext".

Weakened the contract in JpaPersistentEntityImpl to allow multiple @Id properties (in case @IdClass is used). The mapping context now also allows looking up of embeddable types as they're considered entities in the context of Spring Data mapping metadata.
2014-03-03 17:39:08 +01:00
Oliver Gierke
26c64eca0f DATAJPA-483 - Fixed parameter binding detection with parentheses.
When a parameter was listed with parentheses we didn't detect a custom binding and fell back to the standard binding. This effectively disabled the array-to-collection binding which is currently necessary for in bindings as some persistence providers do not bind arrays to in-clauses correctly.

Tweaked the regular expression to detect the bindings to accept the optional parentheses.
2014-02-27 10:11:33 +01:00
Spring Buildmaster
8aa5fa5ca0 DATAJPA-469 - Prepare next development iteration. 2014-02-24 15:14:33 +01:00
Spring Buildmaster
bbb5cae6cd DATAJPA-469 - Release version 1.5.0.RELEASE. 2014-02-24 06:09:49 -08:00
Thomas Darimont
3c30ba2bba DATAJPA-469 - Prepare 1.5.0.RELEASE.
Updated change log, readme, notice. Updated links in index.xml to point to SD Commons documentation.

Original pull request: #60.
2014-02-24 15:04:24 +01:00
Christoph Strobl
7e2d7831a4 DATAJPA-470 - Update Documentation.
Update urls to point to spring.io. Added missing id tag to documentation sections. Fix some typos in reference manual. Update readme.md to use consistent set of database and dialect. Add missing end tag for 'para' in FAQ section. Update authors for proper rendering in PDF. Added productname tag. Added links to Stack Overflow.

Original pull request: #59.
2014-02-24 11:57:19 +01:00
Oliver Gierke
59d4e80010 DATAJPA-474 - Fixed documentation on CDI setup of EntityManagers.
Previously, the reference documentation was missing details of how to set up EntityManager instances for usage of Spring Data JPA repositories in a CDI context. Augmented the section on complete manual setup but also added an example of the necessary setup in a pure JavaEE context.
2014-02-23 16:12:10 +01:00
Oliver Gierke
10dd37a619 DATAJPA-473 - Fixed bug in binding detection in String queries.
Query parameter binding replacements were undone if a simple binding was contained in the query. Fixed that and also make sure we don't create superfluous multiple bindings for the same variable and binding type.
2014-02-23 14:11:06 +01:00
Oliver Gierke
992ccb5956 DATAJPA-471 - Ensure test succeed on Spring 4.
Annotated MappedTypeRepository test repository interface with @NoRepositoryBean to prevent it to fail the build on Spring 4.
2014-02-20 20:27:46 +01:00
Oliver Gierke
246eb989fc DATAJPA-469 - Upgraded to Spring Data Commons snapshots. 2014-02-19 20:08:58 +01:00
Marten Deinum
cba12aa148 DATAJPA-462 - Updated FAQ on how to integrate Spring Data JPA with an existing Hibernate data access layer. 2014-02-19 14:59:31 +01:00
Oliver Gierke
c0c1209130 DATAJPA-461 - Improve binding detection.
Improved the regular expression to detect binding detection to safely find as-is bindings.
2014-02-11 18:14:31 +01:00
Oliver Gierke
1d4b57f684 DATAJPA-461 - Polishing of binding implementation for StringQueries.
We now always create a ParameterBinding for all parameters to simplify the client code so that it can safely always lookup bindings and apply them.

Changed the setup of the regular expression to work with the keywords provided by the binding types to ease future extensions.

Added integration test to quickly verify the EclipseLink bug we're running into now for further reference.

Original pull request: #56.
2014-02-11 15:32:39 +01:00
Thomas Darimont
f8b0917c90 DATAJPA-461 - Fixed regression in parameter binding of arrays.
Enhanced binding of parameters in StringQueryParameterBinder to be able to deal with situations where a parameter value has to be converted to be correctly bound e.g. for parameter values in IN-expressions.

We now only convert array values to collections if the value is to be bound in the context of an IN-parameter. Previously we erroneously always converted an array value to a collection value which lead to problems if an array value was meant to be used "as-is" e.g. in cases where an user wants to query for a certain byte[].

Original pull request: #56.
2014-02-11 15:32:22 +01:00
Oliver Gierke
c85caf00d4 DATAJPA-458 - Added aop.xml to be used within Eclipse. 2014-02-06 19:21:26 +01:00
Oliver Gierke
112d76ac9d DATAJPA-459 - Suppress verbose output for Querydsl APT generation. 2014-02-06 19:21:07 +01:00
Oliver Gierke
75d6f26572 DATAJPA-454 - Fixed join creation in QueryUtils.
QueryUtils now only creates a join for collection properties that are explicitly annotated with an @ManyTo… annotation. This allows collection like properties like byte[] be referred to as non-collection property and thus not trigger a join when a derived query is created.
2014-02-06 19:19:27 +01:00
Spring Buildmaster
869be7eafc DATAJPA-450 - Prepare next development iteration. 2014-01-29 04:43:57 -08:00
Spring Buildmaster
d5e166b469 DATAJPA-450 - Release version 1.5.0.RC1. 2014-01-29 04:43:55 -08:00
Oliver Gierke
c6f486eee2 DATAJPA-450 - Prepare 1.5.0.RC1 release.
Upgraded to Spring Data build parent 1.3 RC1 and Spring Data Commons 1.7 RC1. Updated changelog and references from reference documentation. Switched to milestone repository.
2014-01-28 13:36:23 +01:00
Oliver Gierke
7b9b303f05 DATAJPA-453, DATAJPA-435 - Fixed BeanFactoryPostProcessor handling of BeanFactory hierarchies.
The AuditingBeanFactoryPostProcessor and EntityManagerBeanDefinitionPostProcessor now correctly lookup BeanDefinitions within BeanFactory hierarchies. Also, the EMBDPP registers the EntityManager bean definition in the BeanFactory, the source BeanDefinition for the EntityManagerFactory is found.
2014-01-27 12:41:57 +01:00
Oliver Gierke
7b5425322b DATAJPA-445 - Enable constructor injection for EntityManagers.
Enabling repositories now registers a BeanFactoryPostProcessor that will register a SharedEntityManagerCreator BeanDefinition for all EntityManagerFactory definitions available in the ApplicationContext.

We register the bean name of the EMF as qualifier for the BeanDefinition for the EntityManager to allow an explicit reference in multi-EMF scenarios.

Renamed default persistence unit to spring-data-jpa.
2014-01-25 23:55:37 +01:00
Oliver Gierke
655ad131d2 DATAJPA-444 - Prefer Hibernate 4.3 provider interface over legacy one.
Accessing the legacy persistence provider class in Hibernate 4.3 causes a warning being logged. As we generally want to detect the presence of Hibernate in general only, we now check for the Hibernate 4.3 persistence provider interface first to immediately find the new interface and thus avoid the warning.

Upgraded to Hibernate 4.3.1.
2014-01-24 17:12:44 +01:00
Oliver Gierke
cae3ce4532 DATAJPA-450 - Removed Spring dependency versions.
Added plugin repository and changed to libs-snapshot to correctly lookup Bundlor and other project dependencies.
2014-01-20 13:02:48 +01:00
Oliver Gierke
b1585377c2 DATACMNS-420 - Adapted test cases due to latest changes in Spring Data Commons. 2014-01-18 12:36:16 +01:00
Oliver Gierke
9640ea81ad DATAJPA-417 - Upgraded to EclipseLink 2.5.1.
Was able to upgrade to EclipseLink 2.5.1 and re-enable a previously ignored integration tests. However, some of the disabled test cases still fail despite the relevant bug being reported as fixed in 2.5.1.

Turned the workaround in QueryUtils into a TODO for removal as we don't want to strongly force EclipseLink users to upgrade to 2.5.x yet.
2014-01-17 17:12:20 +01:00
Oliver Gierke
d442bb5fa0 DATAJPA-448 - Added contribution guidelines.
Linked to the actual contribution guidelines maintained in the Spring Data Build project.
2014-01-14 13:41:13 +01:00
Oliver Gierke
f2bc6fc466 DATAJPA-442 - Enable CDI repositories to be instantiated eagerly.
From the CDI extension we now use the callback newly introduced in Spring Data Commons to enable it to trigger eager initialization.

See also: DATACMNS-416.
2014-01-13 12:04:14 +01:00
Oliver Gierke
8a4c04a524 DATAJPA-446 - Removed generic types from AuditingEntityListener. 2014-01-12 19:25:42 +01:00
Oliver Gierke
3f4eecf97e DATAJPA-443 - Upgraded to Hibernate 4.2.8 and 4.3.0. 2014-01-12 19:25:42 +01:00
Oliver Gierke
516977f722 DATAJPA-428 - Upgraded to snapshot of Spring Data build parent. 2014-01-12 19:25:42 +01:00
Thomas Darimont
5e8928f54f DATAJPA-444 - Improve detection of PersistenceProvider implementations.
Since the location of the Hibernate EntityManager implementation changed in Hibernate 4.3 to org.hibernate.jpa.HibernateEntityManager, we now support org.hibernate.jpa.HibernateEntityManager as well as  org.hibernate.ejb.HibernateEntityManager as a Hibernate PersistenceProvider.

Original pull request: #55.
2014-01-08 16:36:08 +01:00
Oliver Gierke
44994ff3e9 DATAJPA-435 - Let Sonar reuse existing test reports. 2013-12-11 13:21:54 +01:00
Thomas Darimont
429538fba8 DATAJPA-410 - Improved documentation on jpa:repository namespace.
We now mention that we require a bean with name transactionManager to be present if no transaction-manager-ref is defined.

Original pull request: #47.
2013-12-11 00:51:09 +01:00
Komi Serge Innocent
a0a98dfc57 DATAJPA-420 - Fixed count projection for manual queries with projections.
Original pull request: #52.
2013-12-10 23:13:56 +01:00