Spring/spring-data-mongodb
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polishing.

Browse Source 
Replace consecutive if-statements with loop.

Original pull request: #4545
See #4542
This commit is contained in:
Mark Paluch
2023-11-03 09:57:20 +01:00
parent e78e1978d5
commit cd16375fea
2 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/support/CrudMethodMetadataPostProcessor.java
View File

@@ -15,6 +15,7 @@
*/
package org.springframework.data.mongodb.repository.support;
import java.lang.reflect.AnnotatedElement;
import java.lang.reflect.Method;
import java.util.HashSet;
import java.util.Optional;
@@ -179,28 +180,25 @@ class CrudMethodMetadataPostProcessor implements RepositoryProxyPostProcessor, B
*/
DefaultCrudMethodMetadata(Class<?> repositoryInterface, Method method) {
Assert.notNull(repositoryInterface, "Repository interface must not be null");
Assert.notNull(method, "Method must not be null");
this.readPreference = findReadPreference(repositoryInterface, method);
this.readPreference = findReadPreference(method, repositoryInterface);
}
private Optional<ReadPreference> findReadPreference(Class<?> repositoryInterface, Method method) {
private static Optional<ReadPreference> findReadPreference(AnnotatedElement... annotatedElements) {
org.springframework.data.mongodb.repository.ReadPreference preference = AnnotatedElementUtils
.findMergedAnnotation(method, org.springframework.data.mongodb.repository.ReadPreference.class);
for (AnnotatedElement element : annotatedElements) {
if (preference == null) {
org.springframework.data.mongodb.repository.ReadPreference preference = AnnotatedElementUtils
.findMergedAnnotation(element, org.springframework.data.mongodb.repository.ReadPreference.class);
preference = AnnotatedElementUtils.findMergedAnnotation(repositoryInterface,
org.springframework.data.mongodb.repository.ReadPreference.class);
if (preference != null) {
return Optional.of(com.mongodb.ReadPreference.valueOf(preference.value()));
}
}
if (preference == null) {
return Optional.empty();
}
return Optional.of(com.mongodb.ReadPreference.valueOf(preference.value()));
return Optional.empty();
}
@Override

2
spring-data-mongodb/src/test/java/org/springframework/data/mongodb/repository/support/DefaultCrudMethodMetadataUnitTests.java
View File

@@ -27,6 +27,8 @@ import org.springframework.data.repository.CrudRepository;
import org.springframework.util.ReflectionUtils;
/**
* Unit tests for {@link DefaultCrudMethodMetadata}.
*
* @author Christoph Strobl
*/
class DefaultCrudMethodMetadataUnitTests {