Commit Graph

2407 Commits

Author SHA1 Message Date
Mark Paluch
18fa4deeb5 DATAMONGO-2209 - Polishing.
Convert spaces to tabs. Add ticket references to tests. Reformat code.

Original pull request: #649.
2019-02-22 12:07:11 +01:00
Sebastien Deleuze
717ca19ad1 DATAMONGO-2209 - Add ReactiveFluentMongoOperations Coroutines extensions.
This commit introduces Coroutines support for
ReactiveFluentMongoOperations API via Kotlin extensions that provide
suspendable functions prefixed by `await` or suffixed by `AndAwait` for
Mono based APIs.

Extensions for Flux will be added when Kotlin/kotlinx.coroutines#254
will be fixed.

Original pull request: #649.
2019-02-22 12:06:55 +01:00
Mark Paluch
dc38369f18 DATAMONGO-2072 - Polishing.
Slightly simplify method signature. Update docs.

Original pull request: #645.
2019-02-22 10:20:26 +01:00
Christoph Strobl
5b47648f49 DATAMONGO-2072 - Support Range in repository between queries.
We now support o.s.d.domain.Range as method parameter for between queries. This allows more fine grained control over the inclusion/exclusion of the upper/lower bounds. Up till now between required 2 parameters which had been strictly bound to excluding bounds using $gt and $lt.

Original pull request: #645.
2019-02-22 10:20:06 +01:00
Mark Paluch
ddad63f28e DATAMONGO-2207 - Remove version for managed Kotlin dependencies.
Versions are managed by kotlin-bom.
2019-02-21 09:55:46 +01:00
Mark Paluch
aab1649e87 DATAMONGO-2206 - Polishing.
Reformat code. Convert spaces to tabs. Use mockk version property to define mockk version. Author tags.

Original pull request: #646.
2019-02-20 11:47:41 +01:00
Sebastien Deleuze
120b7bab2c DATAMONGO-2206 - Migrate Kotlin tests to Mockk.
Original pull request: #646.
2019-02-20 11:47:41 +01:00
Mark Paluch
cbed57ee2b DATAMONGO-2105 - Remove default MongoMappingContext bean registration through @EnableMongoRepositories.
We now no longer register a MongoMappingContext bean when using @EnableMongoRepositories. Previously, we attempted to find a MongoMappingContext bean by name and if there was no such bean, we registered a new one. Additionally, the MappingContext was registered without considering SimpleTypes.

Bean discovery using aImportBeanDefinitionRegistrar is error-prone due to its ordering and timing nature because there is no guarantee that all beans are already registered.

Original Pull Request: #642
2019-02-19 09:28:50 +01:00
Mark Paluch
b8f1062ac2 DATAMONGO-2199 - Polishing.
Align copyright years with forked code. Add customization markers to identify code blocks that were altered (in comparison to the original code) for future fork updates.

Original pull request: #643.
2019-02-18 13:51:03 +01:00
Mark Paluch
271b624c56 DATAMONGO-2198 - Polishing.
Remove final keywords from method arguments. Typos, remove commented code. Simplify test.

Original pull request: #643.
2019-02-18 13:38:13 +01:00
Christoph Strobl
8e21cc181e DATAMONGO-2199 - Introduce JSON parser capable of binding parameters.
We moved in and adapted some classes from the MongoDB Java driver in order to bind parameters to placeholders while parsing a JSON string. This allows us to move off the deprecated JSON.parse method that will be removed with the 4.0 version of the driver.

Original pull request: #643.
2019-02-18 13:38:02 +01:00
Christoph Strobl
45f4b5087c DATAMONGO-2199 - Move tests to AssertJ.
Original pull request: #643.
2019-02-18 13:37:59 +01:00
Christoph Strobl
f7f004ec8a DATAMONGO-2199 - Fix deprecation warnings.
Fix those deprecations with alternatives available. Some still have to remain in code as it is unclear which API to use with the 4.x driver.
Leave some TODOs in the code to find those spots when upgrading to the 4.0 MongoDB Java Driver.

Original pull request: #643.
2019-02-18 13:37:41 +01:00
Christoph Strobl
89fde7f8e9 DATAMONGO-2198 - Upgrade to MongoDB Java Driver 3.10
Fix tests failing due to changed String rendering of Document.

Original pull request: #643.
2019-02-18 13:37:34 +01:00
Mark Paluch
9f58c78e43 DATAMONGO-2187 - Updated changelog. 2019-02-13 11:47:53 +01:00
Christoph Strobl
b54cd4e391 DATAMONGO-2195 - Documentation update.
Original pull request: #641.
2019-02-07 15:13:01 +01:00
Mark Paluch
7500ba18fd DATAMONGO-2195 - Throw OptimisticLockingFailureException on delete only in repositories.
OptimisticLockingFailureException is now thrown only when deleting an entity through a repository and no longer when using the Template API.

Original pull request: #641.
2019-02-07 15:12:58 +01:00
Christoph Strobl
4ecf20ce4c DATAMONGO-2195 - Consider version when removing an entity.
We now consider a potential @Version when removing an entity.

MongoOperations#remove(Object) and MongoOperations#remove(Object, String) include the version of the object to remove if the entity is versioned. Opposed to save(Object), remove(Object) does not throw OptimisticLockingFailureException if a versioned entity could not be removed. This behavior is subject to be changed in a future release. Throwing OptimisticLockingFailureException on failed delete on Template API level was not introduced to not break existing application code.

MongoRepository now also considers the entities version, following the very same logic as MongoOperations.
To remove an entity without version check use MongoOperations#remove(Query,…) or MongoRepository#deleteById(…).

Original pull request: #641.
2019-02-07 15:09:58 +01:00
Christoph Strobl
e8a3b6935e DATAMONGO-2196 - Remove applies WriteConcern to single Document delete operations.
We now make sure to apply the WriteConcern correctly when calling deleteOne on MongoCollection.

Original pull request: #641.
2019-02-07 15:09:51 +01:00
Mark Paluch
3a97b3fbf1 DATAMONGO-2193 - Polishing.
Reformat code.

Original pull request: #640.
2019-02-05 11:44:11 +01:00
Christoph Strobl
f4c9cdcacb DATAMONGO-2193 - Fix String <> ObjectId conversion for non-Id properties.
We now make sure to only convert valid ObjectId Strings if the property can be considered as id property.

Original pull request: #640.
2019-02-05 11:44:08 +01:00
Mark Paluch
cd8402f4ba DATAMONGO-2077 - Polishing.
Abbreviate AggregationMethodReference factory methods. Fix deprecation tag. Update documentation.

Original pull request: #639.
2019-02-05 11:09:30 +01:00
Christoph Strobl
3811ddf912 DATAMONGO-2077 - Enhance SpEL aggregation support.
Added aggregation method detection for:
- trim, ltrim, trim
- arrayToObject, objectToArray, indexOfArray
- dateFromString, dateFromParts, isoDateFromParts, dateToParts
- mergeObjects
- convert, toBool, toDate, toDecimal, toDouble, toInt, toLong, toObjectId, toString
- range

Original pull request: #639.
2019-02-05 10:59:38 +01:00
Christoph Strobl
9cc7fc2a08 DATAMONGO-1855 - Polishing
Introduce base class to share code between imperative and reactive GridFs.

Original Pull Request: #637
2019-01-29 10:32:56 +01:00
Mark Paluch
f40861beff DATAMONGO-1855 - Initial reactive GridFS support.
We now support reactive GridFS using MongoDB's reactive GridFS API. Files can be consumed and provided as binary stream.

ReactiveGridFsOperations operations = …;

Publisher<DataBuffer> buffers = …
Mono<ObjectId> id = operations.store(buffers, "foo.xml");

Flux<DataBuffer> download = operations.getResource("foo.xml").flatMap(ReactiveGridFsResource::getDownloadStream);

Original Pull Request: #637
2019-01-29 10:32:35 +01:00
Christoph Strobl
33e4e38e4a DATAMONGO-2189 - Polishing.
Assert returned object is not the same as the saved one and move helper method.

Original Pull Request: #638
2019-01-28 11:34:14 +01:00
Mark Paluch
915385b710 DATAMONGO-2189 - Fix AfterSaveEvent to contain the saved entity in ReactiveMongoTemplate.insert(…).
ReactiveMongoTemplate.insert(…) now uses the saved entity when emitting AfterSaveEvent. This change affects usage of immutable objects that are using Id generation. Previously, the to-be-saved entity instance was used which left the Id unpopulated.

Original Pull Request: #638
2019-01-28 11:33:50 +01:00
Christoph Strobl
e0a12d77f7 DATAMONGO-2182 - Polishing.
Introduce base class for common Querydsl query execution tasks that can be used for imperative and reactive implementation.
Fix test issues due to context caching where indices are not recreated when dropping the collection during test setup.
Update reference documentation.

Original Pull Request: #635
2019-01-23 10:31:12 +01:00
Mark Paluch
16051106c0 DATAMONGO-2182 - Add Querydsl support for reactive repositories.
We now support execution of Querydsl Predicates using reactive MongoDB repositories. Reactive repositories are only required to add ReactiveQuerydslPredicateExecutor to their declaration to enable Querydsl.

public interface PersonRepository extends ReactiveMongoRepository<Person, String>, ReactiveQuerydslPredicateExecutor<Person> {

   // additional query methods go here
}

PersonRepository repository = …;

QPerson person = new QPerson("person");

Flux<Person> result = repository.findAll(person.address.zipCode.eq("C0123"));

Original Pull Request: #635
2019-01-22 15:07:03 +01:00
Christoph Strobl
2f60d08019 DATAMONGO-2188 - Polishing.
Undo deprecation and transition to configuration option allowing to disable the index creation. Index creation will remain in the codebase as it is used in a lot of places to configure required geo index structures in MongoDB without which query execution would fail.

Original Pull Request: #636
2019-01-22 14:49:23 +01:00
Mark Paluch
5c79ff387e DATAMONGO-2188 - Expose IndexResolver.
We now provide IndexResolver to resolve and derive index definitions from Mongo entities.

MongoMappingContext mappingContext = new MongoMappingContext();
IndexResolver indexResolver = IndexResolver.create(mappingContext);
Iterable<? extends IndexDefinitionHolder> definitions = indexResolver.resolveIndexFor(MyEntity.class);

Original Pull Request: #636
2019-01-22 14:48:04 +01:00
Mark Paluch
33fa79b29f DATAMONGO-2188 - Deprecate auto-index creation & introduce configuration to disable it.
Auto-index creation can now be disabled by setting MongoMappingContext.setAutoIndexCreation(false). This configuration prevents automatic index creation on application startup and during access to entities.

Original Pull Request: #636
2019-01-22 14:47:12 +01:00
Mark Paluch
8f3dacd55e DATAMONGO-2145 - Updated changelog. 2019-01-10 14:15:38 +01:00
Mark Paluch
4ffd1e10e8 DATAMONGO-2144 - Updated changelog. 2019-01-10 12:26:34 +01:00
Mark Paluch
f1a18040bb DATAMONGO-2143 - Updated changelog. 2019-01-10 11:01:20 +01:00
Christoph Strobl
0f1536f136 DATAMONGO-2168 - Polishing.
MetadataBackedField no longer fails when Path detects reference to field within java.lang.Class. This can happen when splitting the property name via camel case where the first part matches to class which resolves to the getClass() call on java.lang.Object. When then the 2nd part also maps to a method (like getName()) on Class an error would be thrown.

Original Pull Request: #631
2019-01-09 17:34:49 +01:00
Mark Paluch
d8bfe68b07 DATAMONGO-2168 - Convert assertions to AssertJ.
Original Pull Request: #631
2019-01-09 17:34:49 +01:00
Mark Paluch
2da0ecbe72 DATAMONGO-2168 - Do not map type key in QueryMapper.
QueryMapper now excludes the type key in during mapping and retains the value as-is. This change fixes an issue in which type keys were attempted to be mapped using the entity model. Type key resolution for _class failed silently while other type keys such as className failed in property path resolution and the failure became visible.

Original Pull Request: #631
2019-01-09 17:34:49 +01:00
Mark Paluch
8ad16c1f23 DATAMONGO-2155 - Polishing.
Reduce visibility of MappedUpdated to package-protected to avoid exposure. Rename UpdateDefinition.incVersion() to inc().

Original pull request: #625.
2019-01-09 16:35:38 +01:00
Christoph Strobl
4be3fe006f DATAMONGO-2155 - Introduce UpdateDefinition.
Original pull request: #625.
2019-01-09 16:35:38 +01:00
Oliver Drotbohm
103de476cd DATAMONGO-2155 - Polishing.
Original pull request: #625.
2019-01-09 16:35:38 +01:00
Christoph Strobl
630da43b69 DATAMONGO-2155 - Bypass mapping for already mapped updates.
We now make sure that mapped updates (as in doSaveVersioned and doUpdate) are mapped only once as mapping is required only once. Mapping already mapped query/update objects comes with undesired side-effects such as following invalid property paths or reduction of type information availability.

We now make sure to map key/value pairs of Map like properties to the values domain type, and apply potentially registered custom converters to the keys.
Fixed invalid test for DATAMONGO-1423 as this one did not check the application of the registered converter.

Original pull request: #625.
2019-01-09 16:35:34 +01:00
Mark Paluch
5c79e26046 DATAMONGO-2173 - Polishing.
Set interrupted thread state after catching InterruptedException. Fix potential NPE by checking the cursor. Streamline generics to not hide class-level generic types.

Original pull request: #634.
2019-01-09 12:59:46 +01:00
Christoph Strobl
c9d441027a DATAMONGO-2173 - Translate and forward exceptions during CursorReadingTask#start() to ErrorHandler.
We now make sure to translate and pass on errors during the cursor initialization procedure to the configured error handler.

Original pull request: #634.
2019-01-09 12:59:37 +01:00
Christoph Strobl
161a983c5d DATAMONGO-2174 - Fix InvalidPersistentPropertyPath exception when updating documents.
MetadataBackedField.getPath() now returns null instead throwing an error for fields that are not part of the domain model. This allows adding any field when updating an entity.

Original pull request: #633.
2019-01-09 10:34:18 +01:00
Mark Paluch
9288472fd9 DATAMONGO-2179 - Fixed broken auditing for entities using optimistic locking via batch save.
The previous implementation of (Reactive)MongoTemplate.doInsertBatch(…) prematurely initialized the version property so that the entity wasn't considered new by the auditing subsystem. Even worse, for primitive version properties, the initialization kept the property at a value of 0, so that the just persisted entity was still considered new. This mean that via the repository route, inserts are triggered even for subsequent attempts to save an entity which caused duplicate key exceptions.

We now make sure we fire the BeforeConvertEvent before the version property is initialized or updated. Also, the initialization of the property now sets primitive properties to 1 initially.

Related tickets: DATAMONGO-2139, DATAMONGO-2150.

Original Pull Request: #632
2019-01-07 15:56:25 +01:00
Mark Paluch
7d5d0bbdfc DATAMONGO-2181 - Consider repository collection name in ReactiveMongoRepository.saveAll(…).
We now consider the collection name that is bound to the repository when inserting entities of which all are new. Previously, the collection name was derived from the entity.

Original Pull Request: #632
2019-01-07 15:55:26 +01:00
Mark Paluch
eacc085863 DATAMONGO-2170 - Polishing.
Use ObjectUtils to compote hash code as hash code implementation contained artifacts that do not belong there. Extract test method.

Original pull request: #629.
2019-01-07 13:10:49 +01:00
Christoph Strobl
9f6f60c769 DATAMONGO-2170 - Return null instead of empty string for IndexInfo#getPartialFilterExpression when not set.
We now return null instead of an empty string when calling IndexInfo#getPartialFilterExpression. The method has been marked to return null vales before and we’re complying to that contract and return value expectation.

Original pull request: #629.
2019-01-07 13:10:39 +01:00
Mark Paluch
2a45695ef3 DATAMONGO-2175 - Update copyright years to 2019. 2019-01-02 14:11:18 +01:00