Spring/spring-data-neo4j
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

caching field-reflection in PropertyFieldAccessors

Browse Source
This commit is contained in:
Michael Hunger
2011-03-31 14:29:02 +02:00
parent 098a61646e
commit 29a9d64834
2 changed files with 21 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-data-neo4j/src/main/java/org/springframework/data/graph/neo4j/fieldaccess/ConvertingNodePropertyFieldAccessorFactory.java
View File

@@ -46,7 +46,7 @@ public class ConvertingNodePropertyFieldAccessorFactory implements FieldAccessor
@Override
public FieldAccessor<GraphBacked<PropertyContainer>> forField(final Field field) {
return new ConvertingNodePropertyFieldAccessor(field, conversionService);
return new ConvertingNodePropertyFieldAccessor(conversionService, DelegatingFieldAccessorFactory.getNeo4jPropertyName(field),field.getType());
}
private boolean isSerializableField(final Field field) {
@@ -67,8 +67,8 @@ public class ConvertingNodePropertyFieldAccessorFactory implements FieldAccessor
public static class ConvertingNodePropertyFieldAccessor extends PropertyFieldAccessorFactory.PropertyFieldAccessor {
private final ConversionService conversionService;
public ConvertingNodePropertyFieldAccessor(final Field field, final ConversionService conversionService) {
super(field, conversionService);
public ConvertingNodePropertyFieldAccessor(ConversionService conversionService, String propertyName, Class fieldType) {
super(conversionService,propertyName,fieldType);
this.conversionService = conversionService;
}
@@ -88,7 +88,7 @@ public class ConvertingNodePropertyFieldAccessorFactory implements FieldAccessor
}
private Object deserializePropertyValue(final Object value) {
return conversionService.convert(value, field.getType());
return conversionService.convert(value, fieldType);
}
}

33
spring-data-neo4j/src/main/java/org/springframework/data/graph/neo4j/fieldaccess/PropertyFieldAccessorFactory.java
View File

@@ -43,7 +43,7 @@ public class PropertyFieldAccessorFactory implements FieldAccessorFactory<GraphB
@Override
public FieldAccessor<GraphBacked<PropertyContainer>> forField(final Field field) {
return new PropertyFieldAccessor(field,conversionService);
return new PropertyFieldAccessor(conversionService,DelegatingFieldAccessorFactory.getNeo4jPropertyName(field),field.getType());
}
private boolean isNeo4jPropertyType(final Class<?> fieldType) {
@@ -57,12 +57,14 @@ public class PropertyFieldAccessorFactory implements FieldAccessorFactory<GraphB
}
public static class PropertyFieldAccessor implements FieldAccessor<GraphBacked<PropertyContainer>> {
protected final Field field;
private final ConversionService conversionService;
protected final String propertyName;
protected final Class<?> fieldType;
public PropertyFieldAccessor(final Field field, ConversionService conversionService) {
this.field = field;
public PropertyFieldAccessor(ConversionService conversionService, String propertyName, Class fieldType) {
this.conversionService = conversionService;
this.propertyName = propertyName;
this.fieldType = fieldType;
}
@Override
@@ -74,9 +76,9 @@ public class PropertyFieldAccessorFactory implements FieldAccessorFactory<GraphB
public Object setValue(final GraphBacked<PropertyContainer> graphBacked, final Object newVal) {
final PropertyContainer propertyContainer = graphBacked.getPersistentState();
if (newVal==null) {
propertyContainer.removeProperty(getPropertyName());
propertyContainer.removeProperty(propertyName);
} else {
propertyContainer.setProperty(getPropertyName(), newVal);
propertyContainer.setProperty(propertyName, newVal);
}
return newVal;
}
@@ -87,17 +89,16 @@ public class PropertyFieldAccessorFactory implements FieldAccessorFactory<GraphB
}
protected Object doGetValue(final GraphBacked<PropertyContainer> graphBacked) {
Class<?> type = field.getType();
Object value = graphBacked.getPersistentState().getProperty(getPropertyName(), getDefaultValue(type));
if (value == null || type.isInstance(value)) return value;
if (conversionService!=null) {
return conversionService.convert(value,type);
PropertyContainer element = graphBacked.getPersistentState();
if (element.hasProperty(propertyName)) {
Object value = element.getProperty(propertyName);
if (value == null || fieldType.isInstance(value)) return value;
if (conversionService!=null) {
return conversionService.convert(value, fieldType);
}
return value;
}
return value;
}
private String getPropertyName() {
return DelegatingFieldAccessorFactory.getNeo4jPropertyName(field);
return getDefaultValue(fieldType);
}
private Object getDefaultValue(final Class<?> type) {