DATAGRAPH-1303 - Ensure that unrelated annotation don’t break OGM metadata.

This commits adds two tests ensuring that OGM 3.2.15 and 3.1.21 don’t fail on unrelated, package private annotations any more.

spring-data-neo4j/src/test/java/org/springframework/data/neo4j/mapping/AnnotationScanningTests.java

@@ -0,0 +1,54 @@
+/*
+ * Copyright 2011-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.data.neo4j.mapping;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.neo4j.ogm.metadata.AnnotationsInfo;
+import org.neo4j.ogm.session.SessionFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.data.neo4j.test.Neo4jIntegrationTest;
+import org.springframework.test.context.junit4.SpringRunner;
+
+/**
+ * @author Michael J. Simons
+ * @soundtrack Metallica - S&M2
+ */
+@RunWith(SpringRunner.class)
+public class AnnotationScanningTests {
+
+	@Autowired
+	private SessionFactory sessionFactory;
+
+	@Test
+	public void shouldBeAbleToWorkWithAnnotatedAnnotations() {
+		AnnotationsInfo annotations = sessionFactory.metaData().classInfo("TheEndpointController").annotationsInfo();
+		assertThat(annotations.get("org.springframework.data.neo4j.mapping.datagraph1303.EndpointController"))
+				.isNotNull().extracting(i -> i.get("value"))
+				.isEqualTo("foobar");
+	}
+
+	@Configuration
+	@Neo4jIntegrationTest(
+			domainPackages = { "org.springframework.data.neo4j.mapping.datagraph1303" },
+			repositoryPackages = { "org.springframework.data.neo4j.mapping.datagraph1303" }
+	)
+	static class Config {
+	}
+}

spring-data-neo4j/src/test/java/org/springframework/data/neo4j/mapping/datagraph1303/DomainObject.java

@@ -0,0 +1,26 @@
+/*
+ * Copyright 2011-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.data.neo4j.mapping.datagraph1303;
+
+import org.neo4j.ogm.annotation.NodeEntity;
+
+/**
+ * @author Michael J. Simons
+ * @soundtrack Metallica - S&M2
+ */
+@NodeEntity
+public class DomainObject {
+}

spring-data-neo4j/src/test/java/org/springframework/data/neo4j/mapping/datagraph1303/Endpoint.java

@@ -0,0 +1,33 @@
+/*
+ * Copyright 2011-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.data.neo4j.mapping.datagraph1303;
+
+import java.lang.annotation.Documented;
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * @author Michael J. Simons
+ * @soundtrack Metallica - S&M2
+ */
+@Documented
+@Retention(RetentionPolicy.RUNTIME)
+@Target(ElementType.TYPE) @interface Endpoint {
+
+	String id() default "";
+}

spring-data-neo4j/src/test/java/org/springframework/data/neo4j/mapping/datagraph1303/EndpointController.java

@@ -0,0 +1,40 @@
+/*
+ * Copyright 2011-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.data.neo4j.mapping.datagraph1303;
+
+import java.lang.annotation.Documented;
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+import org.springframework.core.annotation.AliasFor;
+import org.springframework.stereotype.Controller;
+
+/**
+ * @author Michael J. Simons
+ * @soundtrack Metallica - S&M2
+ */
+@Controller
+@Documented
+@Endpoint
+@Retention(RetentionPolicy.RUNTIME)
+@Target(ElementType.TYPE)
+@interface EndpointController {
+
+	@AliasFor(annotation = Endpoint.class, attribute = "id")
+	String value();
+}

spring-data-neo4j/src/test/java/org/springframework/data/neo4j/mapping/datagraph1303/TheEndpointController.java

@@ -0,0 +1,24 @@
+/*
+ * Copyright 2011-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.data.neo4j.mapping.datagraph1303;
+
+/**
+ * @author Michael J. Simons
+ * @soundtrack Metallica - S&M2
+ */
+@EndpointController("foobar")
+public class TheEndpointController {
+}