Spring/spring-data-neo4j
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enhance warning message for missing entity ids.

Browse Source
This commit is contained in:
Gerrit Meier
2024-01-22 16:36:40 +01:00
parent 0983960de8
commit c5d3458217
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/main/java/org/springframework/data/neo4j/core/mapping/DefaultNeo4jPersistentEntity.java
View File

@@ -265,7 +265,8 @@ final class DefaultNeo4jPersistentEntity<T> extends BasicPersistentEntity<T, Neo
if (this.isRelationshipPropertiesEntity()) {
Supplier<String> messageSupplier = () -> String.format(
"The class `%s` for the properties of a relationship "
+ "is missing a property for the generated, internal ID (`@Id @GeneratedValue Long id`) "
+ "is missing a property for the generated, internal ID (`@Id @GeneratedValue Long id` "
+ "or `@Id @GeneratedValue String id`) "
+ "which is needed for safely updating properties",
this.getUnderlyingClass().getName());
Assert.state(this.getIdDescription() != null && this.getIdDescription().isInternallyGeneratedId(), messageSupplier);

4
src/test/java/org/springframework/data/neo4j/core/mapping/Neo4jMappingContextTest.java
View File

@@ -95,7 +95,7 @@ class Neo4jMappingContextTest {
Arrays.asList(IrrelevantSourceContainer.class, InvalidRelationshipPropertyContainer.class,
IrrelevantTargetContainer.class)));
schema.initialize();
}).withMessage("The class `org.springframework.data.neo4j.core.mapping.Neo4jMappingContextTest$InvalidRelationshipPropertyContainer` for the properties of a relationship is missing a property for the generated, internal ID (`@Id @GeneratedValue Long id`) which is needed for safely updating properties");
}).withMessage("The class `org.springframework.data.neo4j.core.mapping.Neo4jMappingContextTest$InvalidRelationshipPropertyContainer` for the properties of a relationship is missing a property for the generated, internal ID (`@Id @GeneratedValue Long id` or `@Id @GeneratedValue String id`) which is needed for safely updating properties");
}
@Test // GH-2214
@@ -107,7 +107,7 @@ class Neo4jMappingContextTest {
Arrays.asList(IrrelevantSourceContainer3.class, InvalidRelationshipPropertyContainer2.class,
IrrelevantTargetContainer.class)));
schema.initialize();
}).withMessage("The class `org.springframework.data.neo4j.core.mapping.Neo4jMappingContextTest$InvalidRelationshipPropertyContainer2` for the properties of a relationship is missing a property for the generated, internal ID (`@Id @GeneratedValue Long id`) which is needed for safely updating properties");
}).withMessage("The class `org.springframework.data.neo4j.core.mapping.Neo4jMappingContextTest$InvalidRelationshipPropertyContainer2` for the properties of a relationship is missing a property for the generated, internal ID (`@Id @GeneratedValue Long id` or `@Id @GeneratedValue String id`) which is needed for safely updating properties");
}
@Test // GH-2118