Spring/spring-data-redis
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use Integer return type for Number return types except Double and Float.

Browse Source 
Lettuce's ValueOutput doesn't RESP 3 long values so we must use IntegerOutput instead.

Closes #3090
This commit is contained in:
Mark Paluch
2025-01-13 14:35:13 +01:00
parent cbe5ecf158
commit 0d23031969
2 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/org/springframework/data/redis/connection/ReturnType.java
View File

@@ -73,7 +73,11 @@ public enum ReturnType {
return ReturnType.BOOLEAN;
}
if (ClassUtils.isAssignable(Long.class, javaType)) {
if (ClassUtils.isAssignable(Double.class, javaType) || ClassUtils.isAssignable(Float.class, javaType)) {
return ReturnType.VALUE;
}
if (ClassUtils.isAssignable(Number.class, javaType)) {
return ReturnType.INTEGER;
}

13
src/test/java/org/springframework/data/redis/connection/ReturnTypeUnitTests.java
View File

@@ -34,8 +34,19 @@ class ReturnTypeUnitTests {
@ParameterizedTest // DATAREDIS-1245
@ValueSource(classes = { List.class, ArrayList.class, LinkedList.class })
void shouldConsiderListsAsMultiType(Class<?> listClass) {
assertThat(ReturnType.fromJavaType(listClass)).isEqualTo(ReturnType.MULTI);
}
@ParameterizedTest // GH-3090
@ValueSource(classes = { Integer.class, Long.class, Number.class })
void shouldConsiderIntegerType(Class<?> listClass) {
assertThat(ReturnType.fromJavaType(listClass)).isEqualTo(ReturnType.INTEGER);
}
@ParameterizedTest // GH-3090
@ValueSource(classes = { Double.class, Float.class, String.class })
void shouldConsiderValueType(Class<?> listClass) {
assertThat(ReturnType.fromJavaType(listClass)).isEqualTo(ReturnType.VALUE);
}
}