Make RedisAccessor abstract.

Closes #2494
Original pull request: #2645
This commit is contained in:
John Blum
2023-07-17 14:03:37 -07:00
committed by Mark Paluch
parent 4ace2ac385
commit 5a12140b49
2 changed files with 7 additions and 4 deletions

View File

@@ -29,7 +29,7 @@ import org.springframework.lang.Nullable;
* @author John Blum
* @see org.springframework.beans.factory.InitializingBean
*/
public class RedisAccessor implements InitializingBean {
public abstract class RedisAccessor implements InitializingBean {
/** Logger available to subclasses */
protected final Log logger = LogFactory.getLog(getClass());

View File

@@ -41,7 +41,7 @@ class RedisAccessorUnitTests {
RedisConnectionFactory mockConnectionFactory = mock(RedisConnectionFactory.class);
RedisAccessor redisAccessor = new RedisAccessor();
RedisAccessor redisAccessor = new TestRedisAccessor();
assertThat(redisAccessor.getConnectionFactory()).isNull();
@@ -61,7 +61,7 @@ class RedisAccessorUnitTests {
void getRequiredConnectionFactoryWhenNull() {
assertThatIllegalStateException()
.isThrownBy(() -> new RedisAccessor().getRequiredConnectionFactory())
.isThrownBy(() -> new TestRedisAccessor().getRequiredConnectionFactory())
.withMessage("RedisConnectionFactory is required")
.withNoCause();
}
@@ -71,7 +71,7 @@ class RedisAccessorUnitTests {
RedisConnectionFactory mockConnectionFactory = mock(RedisConnectionFactory.class);
RedisAccessor redisAccessor = spy(new RedisAccessor());
RedisAccessor redisAccessor = spy(new TestRedisAccessor());
doReturn(mockConnectionFactory).when(redisAccessor).getRequiredConnectionFactory();
@@ -81,4 +81,7 @@ class RedisAccessorUnitTests {
verify(redisAccessor, times(1)).getRequiredConnectionFactory();
verifyNoMoreInteractions(redisAccessor);
}
static class TestRedisAccessor extends RedisAccessor { }
}