Fix SRP exception on select in transaction

DATAREDIS-220
This commit is contained in:
Jennifer Hickey
2013-07-15 17:40:50 -07:00
parent 992421031a
commit a18a8d4c7e
6 changed files with 22 additions and 1 deletions

View File

@@ -592,6 +592,7 @@ public class SrpConnection implements RedisConnection {
try {
if (isPipelined()) {
pipeline(pipeline.select(dbIndex));
return;
}
client.select(dbIndex);
} catch (Exception ex) {

View File

@@ -98,6 +98,12 @@ public abstract class AbstractConnectionIntegrationTests {
connection = null;
}
@Test
public void testSelect() {
// Make sure this doesn't throw Exception
connection.select(1);
}
@Test
@IfProfileValue(name = "runLongTests", value = "true")
public void testExpire() throws Exception {

View File

@@ -141,6 +141,11 @@ public class JedisConnectionPipelineIntegrationTests extends
super.testZRevRangeByScoreWithScoresOffsetCount();
}
@Test(expected = RedisSystemException.class)
public void testSelect() {
super.testSelect();
}
// Overrides, usually due to return values being Long vs Boolean or Set vs
// List

View File

@@ -274,6 +274,10 @@ public class JRedisConnectionIntegrationTests extends AbstractConnectionIntegrat
super.testZRevRangeByScoreWithScoresOffsetCount();
}
@Test(expected = UnsupportedOperationException.class)
public void testSelect() {
super.testSelect();
}
// Jredis returns null for rPush
@Test

View File

@@ -123,7 +123,7 @@ public class LettuceConnectionIntegrationTests extends AbstractConnectionIntegra
@Test(expected = UnsupportedOperationException.class)
public void testSelect() {
connection.select(1);
super.testSelect();
}
@Test

View File

@@ -60,6 +60,11 @@ public class LettuceConnectionPipelineIntegrationTests extends
public void testMultiDiscard() {
}
@Test(expected=UnsupportedOperationException.class)
public void testSelect() {
super.testSelect();
}
// Overrides, usually due to return values being Long vs Boolean or Set vs
// List