Commit Graph

829 Commits

Author SHA1 Message Date
Jennifer Hickey
7c96b80e54 Make LettuceConnectionFactory thread-safe 2013-04-15 14:27:28 -07:00
Jennifer Hickey
3d4b3cfd32 Fix tests for Redis 2.6 2013-04-12 20:15:35 -07:00
Jennifer Hickey
d565786fef Fix SubscriptionConnectionTests timing issues 2013-04-12 20:14:51 -07:00
Jennifer Hickey
7d485d6463 Upgrade to SRP 0.5
DATAREDIS-132, DATAREDIS-130, DATAREDIS-152

- Upgrade to fix broken config_get in SRP 0.2

- Fix syntax errors in sort methods

- Fix syntax errors in zRange/zRevRange methods 
with offset and count
2013-04-12 11:01:18 -07:00
Jennifer Hickey
aaa28495be Fix SRP exec not returning results of commands
executed in the tx

DATAREDIS-123

- Close pipeline on exec if not explicitly
opened by user and return results of closePipeline,
not result of exec command

- Close pipeline on discard if not explicitly
opened by user
2013-04-11 15:19:32 -07:00
Jennifer Hickey
7813a13f7a Add option to disable Lettuce connection sharing 2013-04-10 17:34:29 -07:00
Jennifer Hickey
0a702bf4af Share native connection between LettuceConnections
to minimize socket usage

DATAREDIS-126
2013-04-10 15:09:11 -07:00
Jennifer Hickey
f4f9f06356 Fix SRP zRevRangeByScore incorrect parameter ordering
DATAREDIS-167
2013-04-09 17:29:53 -07:00
Jennifer Hickey
f6c44dba78 Fix Lettuce and RJC zRevRangeByScore incorrect parameter ordering
DATAREDIS-167

- Fix min/max parameter ordering

- Fix Lettuce NPEs during transactions

- Fix LettuceConnection not passing offset/count to zRevRangeByScoreWithScores
2013-04-09 17:13:01 -07:00
Jennifer Hickey
a01db2b732 Add back synchronization to avoid corrupted subscription input/output streams
- Prevent simultaneous write of subscribe/unsubscribe using the same Connection

- Fix test failure by re-initializing "done" state of SubscriptionTask between runs and adding waits
2013-04-04 23:29:42 -07:00
Jennifer Hickey
8fbabb7eae Add connection pool timeout to test 2013-04-04 20:56:23 -07:00
Jennifer Hickey
6f1739a681 Fix SubscriptionTask leaving open connections
DATAREDIS-124

- Close connection when SubscriptionTask is canceled and subscribing thread is unblocked

- Ensure non-blocking Lettuce and SRP only attempt
to close subscriptions if active

- Cleanup unecessary synchronization between
SubscriptionTask methods, now that connection is
no longer set to null

- Cleanup unused monitor notify when SubscriptionTask thread ends
2013-04-04 14:59:51 -07:00
Jennifer Hickey
2291edae67 Fix messages not received if listening on channel and pattern
DATAREDIS-165

Infinite loop in PatternSubscriptionTask causing
broken pipes and unreceived messages
2013-04-04 11:27:28 -07:00
Jennifer Hickey
78ad1a7cd4 Fix NPEs and incorrect results in several ops within a Lettuce transaction
DATAREDIS-164
2013-04-02 16:54:48 -07:00
Jennifer Hickey
5bd03c0aa5 Ignore irrelevant tests of blocking ops in transactions 2013-04-02 16:24:06 -07:00
Jennifer Hickey
d34cf27996 Fix Jedis and RJC continuing to use pipeline after closed
DATAREDIS-162, DATAREDIS-163
2013-04-02 15:49:56 -07:00
Jennifer Hickey
c5c3a81f42 Fix Jedis brPop executes twice in a transaction
DATAREDIS-159
2013-04-01 16:45:40 -07:00
Jennifer Hickey
4e13ac5b86 Fix Jedis persist does not execute as part of a transaction
DATAREDIS-160
2013-04-01 16:44:51 -07:00
Jennifer Hickey
634e8ccd72 Add tests for Jedis ops in transactions 2013-04-01 16:34:17 -07:00
Jennifer Hickey
8ec6b79e09 Fix JedisConnection execute does not return correct results
DATAREDIS-158
2013-04-01 16:08:38 -07:00
Jennifer Hickey
63a79a4ebb Fix SRP zCount/zInterStore methods executing synchronously when pipelining
DATAREDIS-142
2013-04-01 10:32:12 -07:00
Jennifer Hickey
90affe90cb Fix RJC ping executing synchronously while in pipeline 2013-04-01 10:28:45 -07:00
Jennifer Hickey
a421238403 Fix RJC zRevRangeWithScores returns incorrect results
DATAREDIS-137
2013-04-01 10:27:39 -07:00
Jennifer Hickey
97ebd34b2d Fix Lettuce zCount/zInterStore ops executing synchronously while in pipeline
DATAREDIS-140
2013-04-01 10:22:33 -07:00
Jennifer Hickey
a40555ed19 Fix Lettuce exec to return null when pipelining
DATAREDIS-139
2013-04-01 10:17:19 -07:00
Jennifer Hickey
b3a0deebf8 Fix Jedis dbSize and flush ops executing synchronously while in pipeline or tx
DATAREDIS-141
2013-04-01 10:07:32 -07:00
Jennifer Hickey
fb25e79380 Fix NPE when deserializing a null Map
DATAREDIS-138
2013-04-01 09:53:08 -07:00
Jennifer Hickey
323f8097a7 Only run SRP getRange tests if Redis version >= 2.4 2013-03-31 11:09:25 -07:00
Jennifer Hickey
14087cbdc4 Fix SRP continuing to use pipeline after closed
DATAREDIS-157
2013-03-31 11:06:26 -07:00
Jennifer Hickey
65535d08ec Rename test context file for case-sensitivity 2013-03-31 11:04:13 -07:00
Jennifer Hickey
b968b85ff4 Enable long-running tests via system property 2013-03-31 10:02:21 -07:00
Jennifer Hickey
a1fb8aad69 Add connection integration tests
- Add tests for all Connection methods

- Add tests for all Connection methods through pipeline

- Clean up DB between Connection test runs

- Reduce sleeps in pub/sub tests to improve execution time
2013-03-30 21:28:51 -07:00
Jennifer Hickey
b518fa16bf Modify connection tests to reuse connection factories
- Use Spring integration test support to instantiate ConnectionFactory
once per instance of test class (instead of per method)

- Minimizes number of connection factories and thus connections
in pooled scenarios
2013-03-27 14:58:23 -07:00
Jennifer Hickey
ae3869f0ec Add RedisProperties Lettuce tests 2013-03-27 14:55:01 -07:00
Jennifer Hickey
22e1c9da9b Fix JedisConnection transaction discard
DATAREDIS-135
2013-03-21 18:16:57 -07:00
Jennifer Hickey
57edca0785 Fix Jredis sort to store results under new key
DATAREDIS-135

- Also fix NPE on parsing null getPattern in
DefaultSortParameters
2013-03-21 18:02:56 -07:00
Jennifer Hickey
8553552d2b Fix Lettuce and SRP blpop/brpop issues
- DATAREDIS-127 Fix Lettuce NPE on timeout

- DATAREDIS-128 Fix SRP arg array conversion and NPE
on timeout
2013-03-20 15:07:42 -07:00
Jennifer Hickey
9642b7ea72 Merge branch 'DATAREDIS-117' of github.com:porcelijn/spring-data-redis into porcelijn-DATAREDIS-117
Conflicts:
	src/test/java/org/springframework/data/redis/connection/AbstractConnectionIntegrationTests.java
	src/test/java/org/springframework/data/redis/connection/jedis/JedisConnectionIntegrationTests.java
2013-03-19 09:46:04 -07:00
Tijn Porcelijn
27a7ab0738 Fix for (hash) increment treats long values as int
While the (hash) increment() method accepts a long argument (and Redis
HINCRBY/INCRBY/DECRBY treats arguments as 64 bits), it is cast to a
32bits signed int in the JedisConnection class.

 - Removed offensive (& unnecessary) casts

 - Extended integration tests with incrBy, decrBy and hIncrBy to
   demonstrate handling of large numbers

 - Fixed typos in test support
   (CollectionTestParams, AbstractConnectionIntegrationTests)

Issue: DATAREDIS-117
2013-03-19 11:15:59 +01:00
Jennifer Hickey
c05c0aaaa0 Cleanup test application context 2013-03-14 16:41:09 -07:00
Jennifer Hickey
f45875f628 Add missing client types to parameterized tests 2013-03-14 16:39:46 -07:00
Jennifer Hickey
0a7e3dd204 Clean up Connection integration tests
- Test multi for all applicable connection types

- Clean up unused code

- Remove redundant long-running pubsub test
2013-03-14 15:17:45 -07:00
Jennifer Hickey
ca00877e64 Use connection pools in all tests
The test suite creates a lot of connections. Use connection pooling where possible to minimize risk of Socket BindExceptions.
2013-03-14 15:10:47 -07:00
Jennifer Hickey
a406417efd Fix intermittent SRP Pub/Sub test failures
SRP unsubscribes asynchronously, so occasionally not all messages were delivered prior to unsubscribe. Test will now unsubscribe on connection close instead.
2013-03-14 14:52:44 -07:00
Jennifer Hickey
223ec79c7e Fix Connection Pub/Sub tests
- Use correct argument order in publish calls

- Assert that messages were received
2013-03-08 13:27:28 -08:00
Jennifer Hickey
d46bee7e57 Revert "convertAndSend returns the nr of targeted channels"
- DATAREDIS-118

- Change method return type back to void to fix backwards
compatibility issues

- Modify tests to assert specific clients receive or
don't receive messages vs comparing expected client counts
2013-03-06 16:40:00 -08:00
Costin Leau
34725d0ca5 next development version 2013-02-13 18:16:06 +02:00
Spring Buildmaster
cc354f8552 Release version 1.0.3.RELEASE 2013-02-13 08:06:31 -08:00
Costin Leau
5f24495d00 remove invalid javadoc 2013-02-13 17:58:33 +02:00
Costin Leau
17a71ae510 update changelog 2013-02-13 17:36:29 +02:00