Commit Graph

2811 Commits

Author SHA1 Message Date
John Blum
8fefea7dce Fix compilation failure in LettuceConnection.
Compilation failure was caused by a missing local variable declaration ('command', which was declared as 'redisCommand') on line 1036.

Closes #2756
2023-10-23 12:59:00 -07:00
John Blum
a0ddc0ec0f Safely add and register the MessageListener to Topic mapping.
Given addListener(:MessageListener, :Collection<Topic>) could be called concurrently from the addMessageListener(:MessageListener, Collection<Topic>) method by multiple Threads, and the RedisMessageListenerContainer Javadoc specifically states that it is safe to call the addMessageListener(..) method conurrently without any external synchronization, and the registeration (or mapping) of listener to Topics is a componund action, then a race condition is possible.

Closes #2755
2023-10-23 12:44:36 -07:00
John Blum
5778dec7b5 Apply consistent Exception variable names to all catch blocks.
We now consistently align with the core Spring Framework's use of 'ex' as the variable name for Exceptions handled in catch blocks, and 'ignore' for all Exceptions thrown, but ignored by framework code. Both 'ex' and 'ignore' were appropriately used based on the context and nautre of the Exception handler in the catch block.

Additionally, we use the 'expected' variable name for Exception thrown in tests where the thrown Exception is the expected outcome of the test case.

Only 1 exception exists to these name conventions, and that is 'nested', which was necessarily used in ScanCursor due to the nested try-catch blocks.

Applied consistent use of String.format(..) to Exception messages requiring formatting.

Formatted catch block according to source code formatting style.

Closes #2748
Original pull request: #2749
2023-10-19 09:38:19 +02:00
Mark Paluch
89229afe54 Polishing.
Add since tag. Reformat code.

See #2601
2023-10-19 09:32:36 +02:00
John Blum
c9b194c1bf After release cleanups.
See #2711
2023-10-13 08:09:34 -07:00
John Blum
727ff4f2f4 Prepare next development iteration.
See #2711
2023-10-13 08:09:32 -07:00
John Blum
8368692ebe Release version 3.1.5 (2023.0.5).
See #2711
2023-10-13 08:01:14 -07:00
John Blum
4328325b0b Prepare 3.1.5 (2023.0.5).
See #2711
2023-10-13 08:00:48 -07:00
Christoph Strobl
bb5b30fe00 Update native-image runtime hints.
Closes: #2729
2023-10-13 07:54:26 +02:00
Mark Paluch
3684484e61 Correctly apply Reactive zadd NX/XX command flags.
We now correctly apply if exists/if not exists constraints on the reactive zadd command.

Previously, we only considered upsert which wasn't sufficient to apply xx/nx.

Closes #2731
2023-10-12 10:03:25 +02:00
Mark Paluch
a0c8136d6b Polishing.
Remove superfluous versions. Improve make clean by removing stale pid files.

See #2711
2023-10-11 14:47:05 +02:00
John Blum
0815313f29 Upgrade to Maven Wrapper 3.9.5.
See #2724
2023-10-04 18:22:43 -07:00
John Blum
0a83027d00 Update CI properties.
See #2711
2023-10-04 17:46:55 -07:00
Mark Paluch
f86edd5bbc Fix broken unit tests.
Closes #2720
2023-09-28 14:41:33 +02:00
Mark Paluch
6a51b3da24 Refine RedisSerializer implementations.
This commit polishes up method ordering, introduces Javadoc where missing and updates nullability annotations and argument names.

Closes #1097
2023-09-21 14:59:19 +02:00
Mark Paluch
31f5539645 After release cleanups.
See #2686
2023-09-15 10:55:35 +02:00
Mark Paluch
49c971d11f Prepare next development iteration.
See #2686
2023-09-15 10:55:34 +02:00
Mark Paluch
a3bae21df9 Release version 3.1.4 (2023.0.4).
See #2686
2023-09-15 10:52:26 +02:00
Mark Paluch
7cef80e340 Prepare 3.1.4 (2023.0.4).
See #2686
2023-09-15 10:52:12 +02:00
Mark Paluch
d36dbdcd68 Remove changelog shipped with the binaries.
Closes #2131
2023-09-14 11:19:06 +02:00
John Blum
711832440f Polish enhanced switch statements.
See #2705
Original pull request: #2706
2023-09-11 16:52:31 -07:00
Junghoon Ban
e34872db50 Change switch statements to switch expressions.
Remove unused default branches.

Closes #2705
Original pull request: #2706
2023-09-11 16:50:51 -07:00
John Blum
c64b22b9d2 Polish for #2696.
Closes #2701
Original pull request: #2696
2023-09-06 17:15:10 -07:00
Mingyuan Wu
cf940ce639 Fix wrong asserted code in ConvertingCursor.
Pull Request: #2696
2023-09-06 16:53:07 -07:00
Junghoon Ban
518a07c328 Add missing anchor to reference docs.
Closes #2700
2023-09-06 14:15:21 +02:00
Mark Paluch
732bf26a08 After release cleanups.
See #2642
2023-08-18 14:07:36 +02:00
Mark Paluch
d0b0bc4219 Prepare next development iteration.
See #2642
2023-08-18 14:07:34 +02:00
Mark Paluch
be3a2d54a1 Release version 3.1.3 (2023.0.3).
See #2642
2023-08-18 14:04:04 +02:00
Mark Paluch
d689fcee53 Prepare 3.1.3 (2023.0.3).
See #2642
2023-08-18 14:03:49 +02:00
Mark Paluch
98707a8318 Polishing.
Replace qualified class name access of inner classes with simple names and imports.

Remove Java 8 guards. Extend supported temporal types in Jsr310Converters. Remove superfluous converter annotations.

Simplify tests.

See #2677
Original pull request: #2681
2023-08-17 09:15:02 +02:00
John Blum
d89641e3a0 Register Converters for Offset java.time types in JSR310Converters.
We now appropriately handle OffsetDateTime and OffsetTime the same as all other java.time types, supported as simple types on Spring application (persistent) entity classes.

Closes #2677
2023-08-17 09:00:09 +02:00
Mark Paluch
2b9b8c2c9b Polishing.
Use Regex to capture the various styles of CLUSTER NODES endpoint representations.

See #2678
Original pull request: #2679
2023-08-16 11:54:23 +02:00
Sorokin Evgeniy
0e0f34a4a4 Add support for bracket-less IPv6 addresses to CLUSTER NODES Converter.
Closes #2678
Original pull request: #2679
2023-08-16 11:54:22 +02:00
Mark Paluch
bbf5daebf4 Upgrade to Lettuce 6.2.6.RELEASE.
Also, bump netty to 4.1.96.

Closes #2680
2023-08-16 10:32:50 +02:00
Julia Lee
ce1383f1d2 Update CI properties.
See #2642
2023-08-14 11:29:43 -04:00
Julia Lee
f4fb7011d7 Upgrade to Maven Wrapper 3.9.4.
See #2675
2023-08-14 07:55:33 -04:00
Mark Paluch
05ae96f88d Polishing.
Tweak wording around thread-safety. Include notices in connection factories.

Reformat asciidoc.

See #2653
Original pull request: #2667
2023-08-10 11:10:08 +02:00
John Blum
91affcb77a Edit ref docs and Javadoc for connection classes to clearly state the Thread-safety guarantees.
Closes #2653
Original pull request: #2667
2023-08-10 11:09:50 +02:00
Mark Paluch
49abd4efd6 Polishing.
Replace topic label with assertion message. Reorder methods to align with Spring style.

See #2662
Original pull request: #2663
2023-08-08 10:28:08 +02:00
John Blum
1ddfd4d69b Simplify logic in RedisMessageListenerContainer and supporting classes.
Closes #2662
Original pull request: #2663
2023-08-08 10:28:08 +02:00
John Blum
e05df75c01 Fix spelling in SynchronizingMessageListener.SubscriptionSynchronizion.
Additionally, cleanup compiler warnings.

Closes #2656
Original pull request: #2657
2023-08-08 09:43:33 +02:00
Mark Paluch
b939613edb Polishing.
Use createMono/createFlux syntax instead of using the template for wrapper creation.

See #2658
Original pull request: #2659
2023-08-07 15:52:18 +02:00
John Blum
c7ded601ef Rename Function Lambda parameter to match command interface in (Default) ReactiveXxxOperations.
Cleanup compiler warning.

Fix unnatural line breaks.

Closes #2658
Original pull request: #2659
2023-08-07 15:52:18 +02:00
John Blum
07ce47566c Upgrade to Lettuce 6.2.5.RELEASE.
Closes #2660
2023-08-04 14:44:03 -07:00
John Blum
6769b4b4f7 Polish for RedisSerializationContext.
Closes #2651
Original pull request: #2652
2023-07-27 15:49:18 -07:00
zhoukq
31bdc36aba Assign 'tuple' to 'stringTuple' in DefaultRedisSerializationContextBuilder.string().
Currently, the builder method incorrectly assigns 'tuple' SerializationPair<String> argument to 'hashValueTuple'.

Closes #2651
Original pull request: #2652
2023-07-27 15:48:45 -07:00
Mark Paluch
2d16225462 Polishing.
Make fields final where possible. Reintroduce end of line comment markers to avoid reformatting into unreadable format. Replace HashSet per command instance with String to reduce memory footprint.

Tweak Javadoc wording to represent what we actually expect. Reorder methods.

See #2640
Original pull request: #2644
2023-07-18 10:52:47 +02:00
John Blum
5a52c9c295 Polishing.
Additionally, applied Java 17 syntax, cleaned up compiler warnings, and edited Javadoc.

Closes #2644
Original pull request: #2640
2023-07-18 09:53:43 +02:00
Thach Le
f4d5711efd Fix misordered 'final static' modifiers.
Per the Java Language Specification (Java 17; https://docs.oracle.com/javase/specs/jls/se17/html/jls-8.html#jls-8.3.1), 'static' should appear before 'final'.

This is also consistent with source code analysis tools, like Checkstyle, rules: https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/modifier/ModifierOrderCheck.html.

Original pull request: #2640
2023-07-18 09:53:42 +02:00
Mark Paluch
4ec93a2e86 After release cleanups.
See #2615
2023-07-14 13:57:59 +02:00